ElkArte Community

Elk Development => Bug Reports => Exterminated Bugs => Topic started by: augras on April 20, 2018, 05:16:39 am

Title: [SOLVED]Icons right on a topic doesn't work
Post by: augras on April 20, 2018, 05:16:39 am
Hi,
The icons like in the attachment doen't work : only move the topic works, the others no (maybe also delete works but i didn't validated). Each time it asks to validate but nothing happen after.
The buttons under the post, to do the same thing are working.
Philippe
Title: Re: Icons right on a topic doesn't work
Post by: augras on April 22, 2018, 10:17:18 am
Hi,
i'm alone to have it or really nobody has an idea ?
Philippe
Title: Re: Icons right on a topic doesn't work
Post by: Jason on April 22, 2018, 11:25:57 am
@augras can you share the screenshot from your website.
Title: Re: Icons right on a topic doesn't work
Post by: augras on April 22, 2018, 11:45:16 am
Hi,
a larger screenshot.
Philippe
Title: Re: Icons right on a topic doesn't work
Post by: Jason on April 22, 2018, 12:34:44 pm
I checked mine to, Pinning doesn't work in my forum
Title: Re: Icons right on a topic doesn't work
Post by: augras on April 22, 2018, 01:03:41 pm
Thank you Jason for your answer.
The others icons works for you ? On the screen shot the topics are locked but i can't unlocked by a click on the icon.
Philippe
Title: Re: Icons right on a topic doesn't work
Post by: augras on April 24, 2018, 09:44:36 am
Hi,
is it a general bug or just Jason and me are with it ?
Philippe
Title: Re: Icons right on a topic doesn't work
Post by: radu81 on April 24, 2018, 10:20:35 am
Seems fine on my forum, but I use the BeSocial version. https://screenshots.firefox.com/qV206rzRqTNCB191/www.skodaclub.it
Title: Re: Icons right on a topic doesn't work
Post by: augras on April 24, 2018, 11:08:39 am
Thanks for your answer radu81,
but sorry, your are not looking at the good place ! Look at the screenshot some posts before. Your topics are already pinned and locked and that works here. But if you want to do it you can have completely on right the four icons shown on my first post to do it (or checkbox, or text if my memory is good) : these icons doesn't work.
Philippe
Title: Re: Icons right on a topic doesn't work
Post by: emanuele on April 24, 2018, 11:58:20 am
@radu81 these are the quick-moderation in form of "icons" (in contrast with checkboxes).
It may very well be a bug, not sure what changed in 1.1 that could break them, but to check.
Title: Re: Icons right on a topic doesn't work
Post by: Jason on April 24, 2018, 12:54:43 pm
@emanuele Thanks for acknowledging. We will wait for the fix.
Title: Re: Icons right on a topic doesn't work
Post by: augras on April 24, 2018, 02:03:18 pm
Thanks to check it,
philippe
Title: Re: Icons right on a topic doesn't work
Post by: emanuele on April 25, 2018, 08:24:45 am
I think the quickmoderation icons have been broken since a while.
Anyway, MessageIndex.controller.php, change:
Code: [Select]
			// Just convert to the other method, to make it easier.
foreach ($this->_req->post->topics as $topic)
$actions[(int) $topic] = $this->_req->post->qaction;
}
to:
Code: [Select]
			// Just convert to the other method, to make it easier.
foreach ($this->_req->post->topics as $topic)
$actions[(int) $topic] = $this->_req->post->qaction;
}
else
{
$actions = $this->_req->actions;
}
Title: Re: Icons right on a topic doesn't work
Post by: augras on April 25, 2018, 09:41:17 am
Thanks emmanuele,
i will try toonight.
Philippe

EDIT1
I just tested and it works fine.
Thank you,
Philippe