Re: This darn editor... stop screwing my undo!!! xD
Reply #1 – April 19, 2016, 09:46:04 am
Anything is possible! The undo/redo thing is just a plugin, so no different from being able to disable drafts for a user, just would need to add the option to the look/layout area. That said, what is it messing up / doing wrong?
Re: This darn editor... stop screwing my undo!!! xD
Reply #2 – April 19, 2016, 10:01:10 am
@Spuds It does very weird things with the cursor and it breaks normal undo to boot. I say just let the button click do its own thing without interfering with any keyboard shortcuts. Edit: btw, @ mentions seem to be broken. I thought it was just that I was trying PHP7 on my local install, but it's here too.
Re: This darn editor... stop screwing my undo!!! xD
Reply #8 – April 19, 2016, 04:16:14 pm
I'm not seeing the mention pulldown in the quick reply area (with the full editor) but its fine on the post screen.
Re: This darn editor... stop screwing my undo!!! xD
Reply #10 – April 20, 2016, 05:42:29 am
emanuele
Global Moderator
Well, if there is no pull down for sure doesn't work and it can be javascript broken client-side, or the data not fetched server-side. If there is the pull down but it still doesn't work it could be javascript client-side not properly storing the member id in the form, or server side not properly using the id. So there are a couple of possibilities. BTW, apparently uploaded avatars are completely missing... realized only now. xD
Re: This darn editor... stop screwing my undo!!! xD
Reply #11 – April 20, 2016, 05:45:20 am
Ah, with JS disabled they don't seem to work? Interesting, I thought it was just like the automatic URL linking.
Re: This darn editor... stop screwing my undo!!! xD
Reply #12 – April 22, 2016, 05:15:52 pm
emanuele
Global Moderator
Nope, since it seemed a bit bothersome to have to parse the message on post to take out the names, look-up the members table potentially multiple times, etc. I went for the lazy way: cutting down all the edge cases, the idea is the pull down saves the selected member id and is sent to the server, then php uses this to send the notification.
Re: This darn editor... stop screwing my undo!!! xD
Reply #14 – December 04, 2016, 09:04:09 am
emanuele
Global Moderator
hmm.... Okay, now I feel like I have an idea. Bug one: 1) click reply, 2) start typing, 3) after a while use ctrl+z (or click the button, => anything you have typed is gone. Bug two: 1) click reply, 2) start typing, 3) after a while use ctrl+z (or click the button, 4) the whole post is gone, 5) start typing again, 6) after a while use ctrl+z (or click the button, => the undo doesn't work any more. Of course, since I'm using a... peculiar system, more testing is recommended. ETA: actually this should really go to bug reports, right?