As per screenshot. IMHO it would be better to have some dots instead of truncating the whole word...
What do you think? :)
Note: this happens in both linktrees.
.linktree:last-child>span {
display: block;
overflow: hidden;
max-width: 25em;
}It's caused by overflow: hidden.. Not sure if we can simply remove it..
EDIT: since I discovered that the topic title can't be longer than what I have set it at right now (didn't know there was a limit) I think you could fix it the way you said without having any other issue. If you want to be picky replace hidden with "visible" perhaps... But just to be picky :P
Found another one, just next to the time I posted this you can see the re: Topic title ecc that gets truncated as well...
I'd suggest to put
overflow: visible;
max-width: 100%;
instead of the original
overflow: hidden;
max-width: 15em;
for .post_subject. It should show up correctly on all resolutions and auto-align correctly, due to the small font there shouldn't be any problems with that. :D
The problem (one of them) was discussed here: http://www.elkarte.net/community/index.php?topic=2046.15 Not sure if we could add
text-overflow: ellipsis;
to that, it may help but you may have to shorten the max width a bit more as well.
Hmm wait we should clarify what we are talking about each time because the issues I spoke about are 2 :P
If you meant the linktree the width doesn't even seem to affect it at all since it's too short anyways... So I'd just change the "hidden" to "visible" and that's it, due to the topic title limit it should be fixed without edge cases or any other problems.
If you meant the .post_subject - The max-width doesn't seem to affect it too much because the float is on the right side and the topic title max lenght seems to make it impossible for it to break the 100% or even 40%, the first change that I notice is when I drop it to 39%, then it starts cutting it, at least on my screen (which is kinda wide though - 1920 * 1080).
:)
P.s. Missed that topic (kinda old...) and the issue is still there so I think that this reminder is a good thing ;D
Adding a text-overflow: ellipsis; doesn't seem to break anything. But I didn't test it too much.
About 100% VS 25em, there is also to consider that the subject in the linktree is... well, probably nothing more than a quick reminder because close to the upper linktree there is already the big "topic: " with the subject, so have the full one is not
so strictly important.
Actually, I seem to remember at some point it was proposed to not even show it and stop at the upper level of the hierarchy (board for the topic, category for the board, etc.).
And something similar applies to the subject of each message: they are there as reminder and in the remote case someone changes the subject, but is more like a reminder for when you have multiple tabs open to find at a glance what you are reading. Cutting it is a way to balance the need to know where you are, with the annoyance from having the same line of text repeated the same way for 25 times in each page of the topic.
That, too. Yet seeing the linktree being truncated like that is not very nice to me, I could agree on leaving the topic title truncated with dots in the replies though for the reasons you mentioned. Then... Your call on this one :)
Added the css suggested by
@Spuds to the site here, let me know if it looks better and if there is something broken.
Seems to be working :) At least on a 1920*1080px screen.
Good!
I think I forgot to commit it to 1.0.3... xD
ETA: tracked for 1.0.4 https://github.com/elkarte/Elkarte/issues/1996
Not to be rude but organizing your work in a better way would be the best choice both for you but also for ElkArte. I know you can do it, otherwise I wouldn't be saying it ;)
Fill out a commit TO-DO list on paper and then review all of the points in it before releasing the new version, at least that's what I would do :P
That's why I trakced it. :P
I don't know how much reliable can GitHub be, that's why I suggested the old good paperwork ;D Either way it's fine as long as you keep your stuff more organized with a good list.
If I'm going to be tracked, I'd better get a raise .... Oh wait, If I get any money that may set an expectation that my work will be correct, never mind :P :D
Nope, paperwork doesn't work when multiple people on multiple countries are working together.
Full story:
http://www.elkarte.net/community/index.php?topic=1881.0
Discursive version: this board is for "your" convenience. In theory, when a bug is confirmed, it should be tracked at github, so that a milestone (and some labels) can be assigned and the bug cannot be missed during the work for the release. Though, devs are lazy, so from time to time it happens they fix bugs on-the-fly or think they can remember things, so bugs are not tracked and in very few cases it happens some of those misses the release. :P
Well, at least there is something for 1.0.4. ;)
Post a topic, make it sticky in this section, lock it and write down ALL issues in there as well, or better, links to them on GitHub. When a new version is released you wipe it out and replace it with a new TO-DO list.
Make Spuds local mod in this section to supply the fact he is not using a moderator membergroup (for testing purposes, I know).
Elapsed time: 5 minutes (or less, actually, since you have this one in the list xD)
Elapsed time each time: 30 seconds
Pros:
Impossible to miss anything anymore
Ability to check the whole list before releasing in a more organized and simple way
Cons:
30 seconds wasted for each bug
I think it worths it. Lol
TL;DR: a forum is not a bug tracker. Trust me.
we are all humans, we all make mistakes or simply forget things and copy-paste does not work on emanuele's PC :D
https://github.com/emanuele45/Dialogo/commit/20eb39c0270c17e3c007bdc9ae47443c28fa46c1