Text only | Text with Images

ElkArte Community

Elk Development => Bug Reports => Exterminated Bugs => Topic started by: nwsw on March 05, 2015, 12:17:48 pm

Title: 1.02 default theme, besocial variant, More... button offset by 1 pixel
Post by: nwsw on March 05, 2015, 12:17:48 pm
Pointed out by some of our users. Here is the simple fix that I used. (https://github.com/nwsw/Elkarte/commit/3c4bb5eaaeb91add803b32b0d13e261776e07fdf)

Screen grab from this forum is attached.
Title: Re: 1.02 default theme, besocial variant, More... button offset by 1 pixel
Post by: emanuele on March 05, 2015, 12:35:50 pm
Out of curiosity, what browser?
Title: Re: 1.02 default theme, besocial variant, More... button offset by 1 pixel
Post by: Spuds on March 05, 2015, 03:26:22 pm
Good catch .. looks that way in pale moon, have not checked others.

The fix seems like a good choice to me as it only targets the top menu which is where the alignment tweak was needed.
Title: Re: 1.02 default theme, besocial variant, More... button offset by 1 pixel
Post by: emanuele on June 13, 2015, 03:18:56 pm
Was that one ever fixed?
Title: Re: 1.02 default theme, besocial variant, More... button offset by 1 pixel
Post by: Burke Knight on June 13, 2015, 03:23:38 pm
It seems still a little off, to me. Not as bad as was, though.
More so, when looking at own post, too.
Title: Re: 1.02 default theme, besocial variant, More... button offset by 1 pixel
Post by: Flavio93Zena on June 17, 2015, 11:45:34 pm
There's a "top: -1px;" in .listlevel1.subsections that causes it. No idea why it's there at all, lol, I fixed it in inspect element by just removing it, and it causes no visual issues with anything else. Still, the OP suggested a good fix for it as well, that should be removing it from just that spot.
Title: Re: 1.02 default theme, besocial variant, More... button offset by 1 pixel
Post by: emanuele on July 25, 2015, 05:36:35 pm
Since the -1px was added in 1.0.3, probably for a reason (but unfortunately the reason has been forgot), I now removed it from the site, so please everybody, have a look around maybe with different browser and let me know if is broken. :P
Title: Re: 1.02 default theme, besocial variant, More... button offset by 1 pixel
Post by: Flavio93Zena on July 25, 2015, 05:42:52 pm
Roger that. Nothing in sight so far.
Title: Re: 1.02 default theme, besocial variant, More... button offset by 1 pixel
Post by: emanuele on July 25, 2015, 05:47:41 pm
You have bad sight. :P

So, the problem is that the fix was applied only partially: the main problem was the top menu (see attachment gif), but without the #main_menu the fix breaks the "more" button.
So, the proper fix would be to add the id as well.

I just changed again the css adding #main_menu.
Title: Re: 1.02 default theme, besocial variant, More... button offset by 1 pixel
Post by: Flavio93Zena on July 25, 2015, 06:36:09 pm
Coolio :) And LOL sorry if I can't see a pixel in a flat background on a css code I've never seen ;D
Title: Re: 1.02 default theme, besocial variant, More... button offset by 1 pixel
Post by: Spuds on July 26, 2015, 12:10:14 pm
SeaMonkey :P
Title: Re: 1.02 default theme, besocial variant, More... button offset by 1 pixel
Post by: emanuele on July 26, 2015, 12:17:22 pm
That works better than FireFox! :P

Spoiler (click to show/hide)
Title: Re: 1.02 default theme, besocial variant, More... button offset by 1 pixel
Post by: Flavio93Zena on July 26, 2015, 12:30:48 pm
Glad I ain't the only one --> http://virtualinteractivege.com/index.php?topic=154.0
Title: Re: 1.02 default theme, besocial variant, More... button offset by 1 pixel
Post by: Spuds on July 26, 2015, 02:39:30 pm
It probably does work better, especially on XP :P
Title: Re: 1.02 default theme, besocial variant, More... button offset by 1 pixel
Post by: Flavio93Zena on July 26, 2015, 03:15:57 pm
Yeah and on Windows 98-like themes ;D
Title: Re: 1.02 default theme, besocial variant, More... button offset by 1 pixel
Post by: emanuele on July 26, 2015, 05:58:44 pm
/me doesn't use XP on a daily basis since... about 5 years ago! LOL
Title: Re: 1.02 default theme, besocial variant, More... button offset by 1 pixel
Post by: Flavio93Zena on July 26, 2015, 07:49:07 pm
Same :P
Title: Re: 1.02 default theme, besocial variant, More... button offset by 1 pixel
Post by: Spuds on July 27, 2015, 07:02:07 am
I've had to run it full time over the last couple of weeks (virtual box) as I was lax in keeping one of my cad programs up to date and now refuse to pay 2.5K to "upgrade" :P  Thankfully my old version runs great in the vbox !
Title: Re: 1.02 default theme, besocial variant, More... button offset by 1 pixel
Post by: emanuele on July 27, 2015, 07:20:35 am
WOW!

I should have it on my old laptop that I turn on once in a blue moon... actually even less. lol
BTW, I always preferred win 2000. O:-)
Title: Re: 1.02 default theme, besocial variant, More... button offset by 1 pixel
Post by: Flavio93Zena on July 27, 2015, 09:43:25 am
Just wondering how the topic derailed from a non-fixed bug to a fixed bug and then to Windows versions... LOL.
Title: Re: 1.02 default theme, besocial variant, More... button offset by 1 pixel
Post by: Spuds on July 27, 2015, 10:38:52 am
Way to derail a derailed topic :P
Text only | Text with Images