Skip to main content
Topic: [ADDON] Titled / Descriptive Links (Read 11469 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

Re: [ADDON] Titled / Descriptive Links

Reply #16

LOL. He is on holiday I supposed. He'll be back soon, I think.

Re: [ADDON] Titled / Descriptive Links

Reply #17

Granted!  ;)

Re: [ADDON] Titled / Descriptive Links

Reply #18

Quote from: Jorin – It seems the addon has another problem with links.

http://www.sueddeutsche.de/auto/abgaswerte-renault-ruft-wegen-zu-hoher-abgaswerte-autos-zurueck-1.2824623

If I post this link in a post, it is invisible. If I edit the post then, the code is:

[url=http://www.sueddeutsche.de/auto/abgaswerte-renault-ruft-wegen-zu-hoher-abgaswerte-autos-zurueck-1.2824623][/url]
http://www.elkarte.it/community/index.php?topic=13.msg48#msg48
Seems to work as expected.
Is it the only one giving issues?
Bugs creator.
Features destroyer.
Template killer.

Re: [ADDON] Titled / Descriptive Links

Reply #19


No. Yesterday a user posted this link:

[url=http://www.mak-boerse.de/fahrzeug/toyota-yaris-hybrid-comfort-klimaautom-8-fach-bereift-/abea660aece0427084fc28042a7a2049#/][/url]

It is invisible, only visible when editing the post.

Test it here:


Also not working. So not a problem of the addon but of Elk. Can you split the posts about these URLs please?

Forgot the Chrome check. Will make it tomorrow.  :-[



Re: [ADDON] Titled / Descriptive Links

Reply #22

@radu81 this problem is likely a problem with the addon. ;)
Bugs creator.
Features destroyer.
Template killer.

Re: [ADDON] Titled / Descriptive Links

Reply #23

QuoteTest it here:


Also not working. So not a problem of the addon but of Elk. Can you split the posts about these URLs please?
that's why I did the test, try to edit or quote this message to see the missing link.
sorry for my bad english

Re: [ADDON] Titled / Descriptive Links

Reply #24

I tried the two links on my local and they both worked fine, returning  the title from the website.

I'm not sure why it would add a blank link, there is a check for that condition.  But somehow when the site page fetch occurs and fails its inserting the blank.

I've added a couple of additional checks to perhaps catch this condition, so replace your old file with this one (in your sources/subs directory) and see if you still get blank ones.

Note its not going to fix/prevent someone from adding blank ones, thats really a bit of a elkarte bug IMO

Re: [ADDON] Titled / Descriptive Links

Reply #25

Tried, thanks. With this file the link is showing the URL (not the page title), but that's better then before!

http://www.mak-boerse.de/fahrzeug/toyota-yaris-hybrid-comfort-klimaautom-8-fach-bereift-/abea660aece0427084fc28042a7a2049#/

Re: [ADDON] Titled / Descriptive Links

Reply #26

Good  :D  ... that is what is supposed to happen (showing of the original link) should it be unable to fetch the page.  

As to why it  failed .... This  generally indicates a timeout or page fetch error (40x, 50x) that occurred when your server attempted to fetching the remote page that the link points to. 

I did try the link on two different sites / servers and it resolved fine, so the timeout or other is something with your server, but at least now the addon is not leaving it blank when that happens.

Re: [ADDON] Titled / Descriptive Links

Reply #27

Thank you very mutch!  :)

Re: [ADDON] Titled / Descriptive Links

Reply #28

Not working in v1.1

Re: [ADDON] Titled / Descriptive Links

Reply #29

Try the version attached, it should install and work fine.  That said, a couple of notes

  • Its going to be more robust in converting links if you have curl installed (PHP extension).  In updating this I found a couple of small improvements that we can make in  1.0.11 / 1.1.1 for sites that don't have curl but instead rely on old methods to work.
  • In 1.1 it will convert links inside of code tags.  I could fix this in the addon, but instead want to fix it in 1.1.1, so be aware of that limitation.