Skip to main content ↑ ↓
Topic: Censoring setting reversed (Read 2180 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

Censoring setting reversed

QuoteIgnore case when censoring.

If that is checked, then it will not ignore case, but will, if unchecked.
Should be reversed, due to the wording, eh?

My test was:
:BKE would then get changed to BurkeKnight Enterprises

If have it checked, then when do :bke all it showed was :bke in the test.
But, if unchecked it: :bke changed to BurkeKnight Enterprises

Re: Censoring setting reversed

Reply #1 –

Works fine here (see attach).

Just to be sure: did you save the setting between a test and the other?
Because in fact the interface may lead to confusion: the test is done on the saved settings, and settings are not saved until you click on "save".

@Spuds I wonder if tests should (with a warning?) use the displayed settings.
Bugs creator.
Features destroyer.
Template killer.

Re: Censoring setting reversed

Reply #2 –

Yes, I had saved. I had tested it both with caps and without, on both settings after saving, and even leaving admin and returning.

These are taken today, with saved setting of ignore case. First was test using no caps and 2nd with caps.
They both should have changed, if it was following the ignore case.

Edit: Does it make any difference that you have Check only Whole Words checked?

EDIT 2: Yes! That was it! I tested with that checked, and it works as is supposed to.
So, this issue is only when that is unchecked.

Re: Censoring setting reversed

Reply #3 –

Ohhh.... yes, I was looking at the regexp and missed the str_ireplace below.
Yup, it looks like that bit of logic is reversed.
Bugs creator.
Features destroyer.
Template killer.

Re: Censoring setting reversed

Reply #4 –

Looks like another confirmed bug for me. ;)

Just trying to help out, however I can, my friend. :)

Re: Censoring setting reversed

Reply #5 –

Fixed: https://github.com/emanuele45/Dialogo/commit/18c7a49b7444fef77c9baf72aab5e607c0b8091e
And added some tests: https://github.com/emanuele45/Dialogo/commit/cff47042b4f75214e5e8c9914c0f31a73f3be6f9
Should make more difficult to break it in the future.

And of course thanks for reporting it! ;D
Bugs creator.
Features destroyer.
Template killer.

Re: Censoring setting reversed

Reply #6 –

Works. Thank you. :)
 

Re: Censoring setting reversed

Reply #7 –

Once in I while I'm able to actually fix something! :P
Bugs creator.
Features destroyer.
Template killer.