Elk Development => Feature Discussion => Exterminated Features => Topic started by: Jorin on April 27, 2015, 07:44:57 am
Title: Notify me if I am quoted
Post by: Jorin on April 27, 2015, 07:44:57 am
Some forums notify my if one of my posts is quoted from another user. Do you plan to offer this function (maybe optional, switch it off and on in user settings. And when yes, put an option for notifies when @username is used, please!) too?
Title: Re: Notify me if I am quoted
Post by: emanuele on April 27, 2015, 10:32:22 am
By chance, it's a couple of days I'm working on a more consistent (hopefully) notification system, and this post of yours made me want to give it a try: https://github.com/emanuele45/Dialogo/commit/6836ac4a8a2dd46141cf7b3b82d0938f574aa6a0
Title: Re: Notify me if I am quoted
Post by: Jorin on April 27, 2015, 04:41:22 pm
Great! Do you have a test system to play with future features?
Title: Re: Notify me if I am quoted
Post by: emanuele on April 27, 2015, 05:26:05 pm
Not really yet... also because at the moment it's still an early work in progress (there isn't even a user interface to set the type of notifications lol). When the features will stabilize a bit I may be able to install it on the .it domain, that would give everybody a place to play, but for the moment, unless someone comes up with an automated way to install and set it up it would be quite time consuming (and I prefer to mess with the code LOL). Of course, if there is anyone willing to do and maintain the installs I'd be happy to support the bug fixing. ;D
Title: Re: Notify me if I am quoted
Post by: Spuds on April 27, 2015, 08:01:39 pm
I'd say we are still in the break while building mode ;D so a bit early to show 1.1 in action. But ... BUT ... don't worry, you will be seeing it in action I promise !
Title: Re: Notify me if I am quoted
Post by: Jorin on April 28, 2015, 02:13:12 am
I asked not because of myself. ;) Maybe it's good to have a board to play with, try new functions, optimize them in handling and layout before publishing them. Just my 2 cents. ;)
Title: Re: Notify me if I am quoted
Post by: emanuele on April 28, 2015, 03:39:52 am
Yep, true. I guess, if we want to respect the September deadline for the beta, it should arrive here... more or less in June/July in a "no-major-features-but-not-yet-frozen" state (i.e. alpha).
Title: Re: Notify me if I am quoted
Post by: Eliana Tamerin on April 30, 2015, 10:54:34 pm
Quote from: emanuele – Yep, true. I guess, if we want to respect the September deadline for the beta, it should arrive here... more or less in June/July in a "no-major-features-but-not-yet-frozen" state (i.e. alpha).
That's great news. Too bad my one production forum using Elk has shut down. :(
Title: Re: Notify me if I am quoted
Post by: Spuds on May 01, 2015, 08:11:34 am
Bummer ... start another, convert an existing, just do it ! :D
Title: Re: Notify me if I am quoted
Post by: Keiro on May 02, 2015, 12:37:41 am
Quote from: Jorin – Great! Do you have a test system to play with future features?
@emanuele I believe I mentioned that I/my company has given you a test platform to mess with. Although... we'll need to move it to a separate server and set it up for automated testing and the like...
makes note to do this ASAP
Title: Re: Notify me if I am quoted
Post by: emanuele on May 02, 2015, 04:21:23 pm
Yep, I remember. What I think Jorin was thinking at was an installed up-and-running forum with the most recent development version of Elk. To have that, though, what we need is at least a cron job able to either: a) drop any existing data, fetch the HEAD of the development branch, install and secure the install, let people play with it, or b) fetch the HEAD of the development branch, upgrade any existing data to the latest version, let people play with it. "a" should be easier than "b", even though "b" is probably more desirable. Actually, now that I think again about that, I think I have around somewhere a python script I put together for playing able to download the latest version from github and perform the install. Adding few features (like make all files not writable and fetch from a particular branch) should be enough to have almost the desired effect.
Title: Re: Notify me if I am quoted
Post by: Keiro on May 03, 2015, 12:19:16 am
Quote from: emanuele – Yep, I remember. What I think Jorin was thinking at was an installed up-and-running forum with the most recent development version of Elk. To have that, though, what we need is at least a cron job able to either: a) drop any existing data, fetch the HEAD of the development branch, install and secure the install, let people play with it, or b) fetch the HEAD of the development branch, upgrade any existing data to the latest version, let people play with it. "a" should be easier than "b", even though "b" is probably more desirable. Actually, now that I think again about that, I think I have around somewhere a python script I put together for playing able to download the latest version from github and perform the install. Adding few features (like make all files not writable and fetch from a particular branch) should be enough to have almost the desired effect.
Crons? Should be easily doable. I'll get with you ASAP and see if I can help you rework the testing environment to do that for you. But... as far as I'm thinking, it shouldn't be an issue to do both. Or one or the other. B is probably the best way to go forward, given that with a live test forum that people can mess with, you'll be able to find bugs faster and be able to merge fixes into the stable branch.
I should also probably implement a spam-bot prevention measure via http or something similar to ensure the server doesn't get blacklisted.
Edit: Actually, come to think of it, doing both is probably a good idea. Makes it easier for seeing how people might break a stable forum install and/or compromise it while also testing the code changes in the development install.
Title: Re: Notify me if I am quoted
Post by: Jorin on May 03, 2015, 12:20:39 am
I thought of a board to play with only for you which are working on ElkArte. Not for the public. Of course you could show some screenshots of new features to the public. ;)
Title: Re: Notify me if I am quoted
Post by: emanuele on May 03, 2015, 08:09:04 am
Quote from: Keiro – But... as far as I'm thinking, it shouldn't be an issue to do both.
It's a development technical issue: we agreed on making the upgrade able to upgrade only starting from a "final" version, not from any arbitrary development release/state, so there is basically no simple way to "upgrade" any arbitrary "dev-build" to another dev-build if the two builds differ in the database structure. The only reliable way is to do it manually.
Quote from: Jorin – I thought of a board to play with only for you which are working on ElkArte. Not for the public. Of course you could show some screenshots of new features to the public. ;)
Ahh... Well, we have local test sites. Mine are all messed up because I use the dev space to test any kind of thing like addons, themes, random scripts I need for any reason, random dev builds with different database structures, etc. Also I use the same db for 1.0 and 1.1, so it becomes even more messy. LOL
I don't really feel like posting screenshots just because there is any sort of things around in that testing area and most of them are not really professional... lol
Title: Re: Notify me if I am quoted
Post by: emanuele on May 04, 2015, 03:12:37 pm
Do not expect many screenshots, but since I have just finished that I'll post it. :P
The way the members are supposed to configure their notifications in 1.1. Still WIP, because I did the first commit about 10 minutes ago, but quite similar to what I was aiming at. O:-)
Title: Re: Notify me if I am quoted
Post by: Spuds on May 04, 2015, 07:08:22 pm
Looks sweeeeeet :D
Title: Re: Notify me if I am quoted
Post by: ahrasis on May 05, 2015, 12:35:28 am
Quote from: Jorin – - immediate e-mail, no alert - daily e-mail, no alert - weekly e-mail, no alert
Actually I designed it exactly to always have the alert and additionally emails (or other ways with addons).
Title: Re: Notify me if I am quoted
Post by: Jorin on May 05, 2015, 03:20:31 am
Ah, okay. A bit of misunderstanding. O:-)
Title: Re: Notify me if I am quoted
Post by: emanuele on May 05, 2015, 04:04:29 am
I thought it was rather straightforward: want notification yes/no, if yes "how".
What would you see?
Title: Re: Notify me if I am quoted
Post by: Jorin on May 05, 2015, 04:08:15 am
You're right, I'm wrong. Looking at the screenshot again it is now clear. It's different than we know from SMF and other ElkArte options, but it's totally clear when you can read. O:-)
Title: Re: Notify me if I am quoted
Post by: emanuele on May 05, 2015, 07:14:27 am
If it is not clear "at first sight" it may be a problem, so if you have suggestions feel free to share. ;D
Actually, to take in consideration there is also the fact that the screenshot is static, you cannot interact with it and see what happens on the various elements... :(
Title: Re: Notify me if I am quoted
Post by: Jorin on May 06, 2015, 01:28:37 am
Hm, the more I look at it, the more I like it. :D
Maybe you should try to change all settings and options to the same style? One button to activate/deactivate an option and right behind it the list of possible options. Like in your screenshot. Seems better then the checkpoint to activate/deactivate and the list of options in a new row then, like it is in SMF and ElkArte now.
And while you are at it, clean the admin backend and make it more efficient and transparent please. O:-) I think @radu81 made some suggestions before how you could try this. I could make a small sketch if you want. ;)
ElkArte has a lot to offer, many functions and options to change. But the backend is some kind of mixed up and I often have to search a few pages for the function I need (although I am using SMF and ElkArte for roundabout thirteen years now).
Edit: Here's a little experiment: http://www.elkarte.net/community/index.php?topic=2625.0
Title: Re: Notify me if I am quoted
Post by: emanuele on May 06, 2015, 08:19:16 am
ehm... yes, I myself do use the search in the admin panel quite often! LOL
For the notifications I's my intention to turn that way most if not all of them, for the rest of the options it depends on what they do, but it may be something to consider. And I agree also on the "cleanup & re-organize" of the admin panel, it's not something "easy"[1], but it would be a very nice thing to have. nods
One thing I worked on (and still have to polish it up) is the addons/modules[2], that now can be all enabled before use in a central place (but as I said that's still something I'm working on and I still have to clear up my mind as well).
1 In the sense that it will take a bit of time and maybe rethink some parts↵
2 Do not concentrate on what a "module" is, just take it like that, they exists. lol↵
Title: Re: Notify me if I am quoted
Post by: emanuele on May 06, 2015, 09:07:43 am
Looking again at screenshot I feel it's not very clear that the mention is always sent... there may be to tweak the wording.
Title: Re: Notify me if I am quoted
Post by: Eliana Tamerin on May 06, 2015, 11:00:47 pm
Title: Re: Notify me if I am quoted
Post by: emanuele on May 07, 2015, 05:26:41 am
Good idea Eliana! Will try!
Quick question: at the moment I set up a way to restrict some methods by the "notification system" (for example for likes I disabled the emails). Now I was preparing the admin panel and I started thinking: why not give admins the option to enabled/disable some ways to notify instead of leaving it to the "code"? What would you think? Spoiler (click to show/hide)
Yeah, I know it's a badly worded question. lol
Let's put it that way: should the code be responsible for not allowing members to ask for immediate notification by email on likes, or should be the admin able to decide that based on his/her possibilities? (i.e. good mail server/service for the forum that is not recognized as spammer even if it sends out a lot of very similar emails in maybe a short period of time)
Title: Re: Notify me if I am quoted
Post by: Eliana Tamerin on May 07, 2015, 02:27:15 pm
Quick question: at the moment I set up a way to restrict some methods by the "notification system" (for example for likes I disabled the emails). Now I was preparing the admin panel and I started thinking: why not give admins the option to enabled/disable some ways to notify instead of leaving it to the "code"? What would you think? Spoiler (click to show/hide)
Yeah, I know it's a badly worded question. lol
Let's put it that way: should the code be responsible for not allowing members to ask for immediate notification by email on likes, or should be the admin able to decide that based on his/her possibilities? (i.e. good mail server/service for the forum that is not recognized as spammer even if it sends out a lot of very similar emails in maybe a short period of time)
Makes sense to me.
I like the ability for admins on heavily-stressed servers to turn off immediate emails, for example. Restricting to a Daily Email/Weekly Email would relieve a lot of stress, especially since those could be scheduled to sent out a non-peak periods.
Some admins might even prefer to turn off emails altogether and only rely on notifications.
Title: Re: Notify me if I am quoted
Post by: ahrasis on May 07, 2015, 02:47:50 pm
Agreed. It is a should have for admin.
Title: Re: Notify me if I am quoted
Post by: emanuele on May 07, 2015, 04:30:25 pm
Does it make sense?
Title: Re: Notify me if I am quoted
Post by: Jorin on May 07, 2015, 11:50:44 pm
Needs a lot of space, but is awesome! :)
Title: Re: Notify me if I am quoted
Post by: ahrasis on May 08, 2015, 01:17:30 am
I like that way rather than the drop down. It is easier. But toggle to close each would be nice if that list becomes longer.
Title: Re: Notify me if I am quoted
Post by: emanuele on May 08, 2015, 11:48:20 am
Sorry for the confusion, but this is the admin panel! There an admin can enable/disable notifications and the way members can select to receive notifications. For example in the first screenshot, only @mentions and quotes are enabled, on the first any user can request a daily summary email of their mentions, while only notifications are available for quotes (i.e. members cannot ask to receive emails).
Title: Re: Notify me if I am quoted
Post by: Joshua Dickerson on May 08, 2015, 03:49:05 pm
I think I would want multiple notifications for some things. For instance, if someone registers on a closed forum I would want something on the page and something sent to my email if I am not on the page. So, this page would need to be reworked. I think a tab with multiple selections per type of notification would be what I want here.
Title: Re: Notify me if I am quoted
Post by: emanuele on May 08, 2015, 05:31:54 pm
I'm not sure I understand.
Title: Re: Notify me if I am quoted
Post by: ahrasis on May 08, 2015, 08:09:16 pm
Quote from: Joshua Dickerson – I think I would want multiple notifications for some things. For instance, if someone registers on a closed forum I would want something on the page and something sent to my email if I am not on the page. So, this page would need to be reworked. I think a tab with multiple selections per type of notification would be what I want here.
I can already see that in the images posted by emanuele. I only understand that you want notification to be managed in one page. I agree with that as it will be very admin friendly.
Title: Re: Notify me if I am quoted
Post by: Eliana Tamerin on May 09, 2015, 01:06:24 am
No. It's clear what Enable the notification of this event does, even if the wording is muddy. Maybe something like Enable user notifications of this event ?
It's not clear what Immediate Email, Daily Email or Weekly Email options do. Perhaps a header above it to organize this, saying: Enable user emails of this event, a check of which would enable all three email options by default, underneath which your three email option checks would be placed?
Title: Re: Notify me if I am quoted
Post by: emanuele on May 09, 2015, 03:15:14 pm
If wording it's the only problem that's good! :P There is a not, but it's at the very top (outside the screenshot) and... I feel it is not really enough.
Title: Re: Notify me if I am quoted
Post by: meetdilip on May 17, 2015, 07:50:29 am