ElkArte Community

Project Support => Support => Topic started by: Jorin on July 26, 2016, 04:41:42 am

Title: Links underlinings
Post by: Jorin on July 26, 2016, 04:41:42 am
Works fine, but my underlined links are now not underlined. Does this addon overwrite my CSS settings?
Title: Re: Re: [ADDON] Titled / Descriptive Links
Post by: Jorin on August 02, 2016, 06:40:12 am
push  :-[
Title: Re: Re: [ADDON] Titled / Descriptive Links
Post by: emanuele on August 02, 2016, 09:18:02 am
Example? O:-)
Title: Re: Re: [ADDON] Titled / Descriptive Links
Post by: Jorin on August 02, 2016, 09:22:29 am
Sure:
http://forum-alternative-antriebe.de/index.php/topic,5049.msg92906.html#msg92906

Links are not underlined, but they should when hovered (hovered?). Code from my custom.css:

Code: [Select]
a, a:link, a:visited {
color: #469AC9;
text-decoration: none;
}
a:hover, a:hover:visited {
color: #469AC9;
text-decoration: underline;
}
Title: Re: Re: [ADDON] Titled / Descriptive Links
Post by: emanuele on August 02, 2016, 11:21:20 am
custom_light.css:
Code: [Select]
.bbc_link:link, .bbc_link:visited {
color: #469AC9;
/* box-shadow: 0 -1px 0 #cedccb inset; */
box-shadow: none;
}
Restore the box-shadow and the underline is back. ;)
Title: Re: Re: [ADDON] Titled / Descriptive Links
Post by: Jorin on August 03, 2016, 12:52:43 am
Sorry, no, it's not.  :(

I tried:

Code: [Select]
.bbc_link:link, .bbc_link:visited, {
color: #469AC9;
box-shadow: 0 -1px 0 #cedccb inset;
text-decoration: none;
}

Code: [Select]
.bbc_link:link, .bbc_link:visited, {
color: #469AC9;
box-shadow: 0 -1px 0 #cedccb inset;
text-decoration: underline;
}

...and many more, but none works.
Title: Re: Re: [ADDON] Titled / Descriptive Links
Post by: emanuele on August 03, 2016, 11:22:57 am
Your current:
(Link-3966)

Removing the box-shadow:none at line 117 of custom_light.css:
(Link-3968)
Title: Re: Re: [ADDON] Titled / Descriptive Links
Post by: Jorin on August 03, 2016, 11:40:45 pm
I want them only underlined when hovered.  :-[
Title: Re: Re: [ADDON] Titled / Descriptive Links
Post by: Jorin on August 05, 2016, 01:14:56 am
@Ruth helped me via a message. With this code:

Code: [Select]
a:hover, a:hover:visited {
    color: #469AC9;
    text-decoration: underline;
    box-shadow: 0 -1px 0 #469AC9 inset;
}

.bbc_link:hover {
    color: #469AC9;
    /* box-shadow: 0 -1px 0 #469AC9 inset; */
    text-decoration: underline;
}

...it works, but why?

My custom.css now looks at this:

Code: [Select]
a, a:link, a:visited {
color: #469AC9;
text-decoration: none;
}
a:hover, a:hover:visited {
color: #469AC9;
text-decoration: underline;
box-shadow: 0 -1px 0 #469AC9 inset;
}
.signature a:hover {
text-decoration: underline;
}
a.new_win:link, a.new_win:visited {
color: #469AC9;
}
a.new_win:link:hover, a.new_win:visited:hover {
text-decoration: underline;
}
.bbc_link:link, .bbc_link:visited, {
color: #469AC9;
box-shadow: 0 -1px 0 #cedccb inset;
text-decoration: underline;
}
.bbc_link:hover {
color: #469AC9;
text-decoration: underline;
}
.ic_section_header>a:visited {
color: #666;
}

Is there still a mistake in the code? Something I should optimize? The code seems to work though.  :)

Edit: No, not working. There must be a mistake.  :o  In board index the links now are double underlined and in the table with recent topics above my index the underline is much thicker then in the posts.  :o
Title: Re: Re: [ADDON] Titled / Descriptive Links
Post by: Jorin on August 05, 2016, 01:24:45 am
Okay, back to the beginning. With this code in my css file the links are looking good, except the ones using this addon:

Code: [Select]
a, a:link, a:visited {
color: #469AC9;
text-decoration: none;
}
a:hover, a:hover:visited {
color: #469AC9;
text-decoration: underline;
}
.signature a:hover {
text-decoration: underline;
}
a.new_win:link, a.new_win:visited {
color: #469AC9;
}
a.new_win:link:hover, a.new_win:visited:hover {
text-decoration: underline;
}
.bbc_link:link, .bbc_link:visited {
color: #469AC9;
/* box-shadow: 0 -1px 0 #cedccb inset; */
box-shadow: none;
}
.ic_section_header>a:visited {
color: #666;
}

s you can see here in this post (http://forum-alternative-antriebe.de/index.php/topic,5758.msg90143.html#msg90143), normal links (usernames for example) are looking good, but the links to extern pages are not underlined.

So, it seems the addon uses a special css code not inside the custom css file?
Title: Re: Re: [ADDON] Titled / Descriptive Links
Post by: emanuele on August 05, 2016, 01:46:57 am
The addon doesn't add any CSS.
And for that reason it has nothing to do with the problems you are facing.
Really, nothing at all.

Quote from: Jorin – I want them only underlined when hovered.  :-[
Sorry, I missed that part.
Well, then the code Ruth gave you worked simply because it uses the "hover" modifier:
Code: [Select]
a:hover {
...
}
that is supposed to apply styles exactly when you hover the link with the pointer.

If I got it right, the reason you are getting two underline could be for one of two reasons:
1) you used both box-shadow and text underline, but you should use only one of the two, not both,
2) bootstrap is using some style the (again) conflicts with your desired design.

I would suggest you to restore the code proposed by Ruth and let see what the cause of the double underlining is. ;)
Title: Re: Re: [ADDON] Titled / Descriptive Links
Post by: Jorin on August 05, 2016, 01:54:04 am
Quote from: emanuele – The addon doesn't add any CSS.
And for that reason it has nothing to do with the problems you are facing.
Really, nothing at all.

Okay, I believe you!

I will "install" the custom css file within another theme, so we can test without irritating my users. As Schwarzenegger said: "I'll be back!"  :D
Title: Re: Re: [ADDON] Titled / Descriptive Links
Post by: Jorin on August 05, 2016, 02:38:03 am
Okay, now I have Ruth's code with the default theme. My custom.css:

Code: [Select]
a, a:link, a:visited {
color: #469AC9;
text-decoration: none;
}
a:hover, a:hover:visited {
    color: #469AC9;
    text-decoration: underline;
    box-shadow: 0 -1px 0 #469AC9 inset;
}

.bbc_link:hover {
    color: #469AC9;
    /* box-shadow: 0 -1px 0 #469AC9 inset; */
    text-decoration: underline;
}
.signature a:hover {
text-decoration: underline;
}
a.new_win:link, a.new_win:visited {
color: #469AC9;
}
a.new_win:link:hover, a.new_win:visited:hover {
text-decoration: underline;
}
.bbc_link:link, .bbc_link:visited {
color: #469AC9;
/* box-shadow: 0 -1px 0 #cedccb inset; */
box-shadow: none;
}
.ic_section_header>a:visited {
color: #666;
}

Now links are double underlined in board index. It seems the double line depends on the size of the text. The bigger the text size the more the double line is visible. Links inside a post are looking good though.
Title: Re: Re: [ADDON] Titled / Descriptive Links
Post by: emanuele on August 05, 2016, 07:47:13 am
I can't see any underlining at all in any page...
Title: Re: Re: [ADDON] Titled / Descriptive Links
Post by: Jorin on August 05, 2016, 12:43:52 pm
Because you can't see my default theme. Hm... Do you need an account?
Title: Re: Re: [ADDON] Titled / Descriptive Links
Post by: emanuele on August 05, 2016, 07:18:09 pm
Either an account, or let guests pick themes. Up to you.
Title: Re: Re: [ADDON] Titled / Descriptive Links
Post by: Jorin on August 08, 2016, 06:46:22 am
Send you a message with the login.

I installed the attached file from @Ruth today. There now is an underline, but it's somehow different from the others:

- It is thicker then 1 px.
- The space between the text above the line and the line itself is bigger/higher then other links.
- It seems this is a shadow and not a line.

Not happy, sorry, Ruth.  :-\
Title: Re: Re: [ADDON] Titled / Descriptive Links
Post by: Ruth on August 08, 2016, 08:15:53 am
It's okay, Jorin...it was just a try. ;) . I was using the shadow as a line and did not notice that those lines were different to the others
Title: Re: Re: [ADDON] Titled / Descriptive Links
Post by: emanuele on August 08, 2016, 11:21:03 am
Apparently Ruth was not that far.
Title: Re: Re: [ADDON] Titled / Descriptive Links
Post by: Jorin on August 09, 2016, 03:07:25 am

As you can see here:

http://forum-alternative-antriebe.de/index.php/topic,5936.msg93128.html#msg93128

...the space between the text and the line of the mention@username and the link to an extern page is different. In signatures are now two underlines.  :D

It's the second addon I have problems with and the addon author seems to have no solution (or seems to be not interested to find one). That's sad. Does anyone know what's with @Spuds?
Title: Re: Re: [ADDON] Titled / Descriptive Links
Post by: Ruth on August 09, 2016, 05:01:21 am
Maybe it can be a problem of the browser you are using; I have tried Opera, Firefox and IE right now. It looks different if I hover over the name of the poster with Opera.

But I cannot see another difference between the lines...and I don't see any line twice in the signatures?
Title: Re: Re: [ADDON] Titled / Descriptive Links
Post by: emanuele on August 09, 2016, 04:46:21 pm
For the @ thingy you can change:
Code: [Select]
.bbc_link:hover {
    text-decoration: underline;
}
to:
Code: [Select]
.bbc_link:hover, .bbc_mention a:hover {
    text-decoration: underline;
}

Regarding signatures I can't see the double underline... What browser are you using?
Title: Re: Re: [ADDON] Titled / Descriptive Links
Post by: Jorin on August 10, 2016, 01:00:48 am
Quote from: emanuele – For the @ thingy you can change:
Code: [Select]
.bbc_link:hover {
    text-decoration: underline;
}
to:
Code: [Select]
.bbc_link:hover, .bbc_mention a:hover {
    text-decoration: underline;
}

Okay, the links edited by the addon and the mention links are looking good now, they are fixed. But now every other text/page link (for example in forum index the list of recent topics on the top of the forum) is not underlined anymore. But they should be. The goal is: Every link should be blue and underlined when hovered. Except graphics as links, they should not be underlined. We are close!  :)

Quote from: emanuele – Regarding signatures I can't see the double underline... What browser are you using?

Actually the IE on my office's computer. I can check it with Chrome later this day.

Quote from: emanuele –
Quote from: Jorin – It seems the addon has another problem with links.

http://www.sueddeutsche.de/auto/abgaswerte-renault-ruft-wegen-zu-hoher-abgaswerte-autos-zurueck-1.2824623

If I post this link in a post, it is invisible. If I edit the post then, the code is:

[url=http://www.sueddeutsche.de/auto/abgaswerte-renault-ruft-wegen-zu-hoher-abgaswerte-autos-zurueck-1.2824623][/url]
http://www.elkarte.it/community/index.php?topic=13.msg48#msg48
Seems to work as expected.
Is it the only one giving issues?

I remember I had this problem with an external link a few days ago. I can observe this a few days though.
Title: Re: Re: [ADDON] Titled / Descriptive Links
Post by: Jorin on August 19, 2016, 01:01:53 am
Any news on this? I did not check it with chrome, sorry, but I think it looks the same with Chrome then with IE. Where are my lines? Want them back!  :(
Title: Re: Re: [ADDON] Titled / Descriptive Links
Post by: emanuele on August 19, 2016, 07:46:44 am
The problem is that if the css issue was in its own topic (since it's not a problem with the addon), it was easier to spot, here lost in the middle of a discussion about other stuff it's much more difficult. ;)

I'll try to split it up as much as possible and bring the discussion to support.
Title: Re: Links underlinings
Post by: emanuele on August 19, 2016, 07:54:37 am
Let's start from scratch for a second.
Exactly: what do you want to obtain?
You want any link (those in posts, the ones around the interface, etc. "any" with the meaning each and every link that ever appears in the page) underlined when hovered?
You want some link underlined when hovered? (If so which ones exactly.)
Title: Re: Links underlinings
Post by: Jorin on August 22, 2016, 01:01:05 am
I want it as it was before I installed the addon which is not guilty of this situation.  ;)


Oh, great. Where are the points of my list gone? I edited the post and the points are... well, gone!  :o
Title: Re: Links underlinings
Post by: emanuele on August 22, 2016, 06:09:48 pm
Could you try browsing here:
http://www.elkarte.it/community/index.php
and tell me what is missing?
Title: Re: Links underlinings
Post by: Jorin on August 23, 2016, 01:15:14 am
- Text of the menu buttons are underlined on hover. Shouldn't be, sorry, I forgot that.
- Some links don't have the link color (see recent posts list above the index, there the board and author names. They should have the link color). All links should have the link color, only category titles should not.
- "Forum Stats" should have link color too.
- Breadcrumb links are underlined on hover. Shouldn't be.
- I don't see any signatures, so to be clear: Links in signatures should have link color and be underlined when hovered.
- Images all over the board (in signatures and posts) should not be underlined if hovered or not.

Summary:

- Images should not be underlined as standard and not be underlined when hovered.
- Text links should have the link color and underlined when hovered.
- Category names should be underlined when hovered, but not have the link color.
- Buttons (menu buttons, breadcrumb, other buttons around the board) and the text on these buttons should not have the link color and not be underlined when hovered.
Title: Re: Links underlinings
Post by: emanuele on August 23, 2016, 09:33:15 am
Quote from: Jorin – I want it as it was before I installed the addon which is not guilty of this situation.  ;)
Could it be you based your theme on besocial (that has this very behaviour) and then switched for some reason to light and you lost it? ;)

Now, what is missing?
Title: Re: Links underlinings
Post by: Jorin on August 24, 2016, 01:40:58 am
Quote from: emanuele – Could it be you based your theme on besocial (that has this very behaviour) and then switched for some reason to light and you lost it? ;)

No, I used the light variant from the start and never changed that.


Nothing, it looks good now!  :)
Title: Re: Links underlinings
Post by: emanuele on August 24, 2016, 08:02:36 am
The custom used there is the one attached to this post, enjoy! :D
Title: Re: Links underlinings
Post by: Jorin on August 25, 2016, 01:33:58 am
Thank you! I changed the button link text color to dark grey:

Code: [Select]
.linktree a:hover,
.listlevel1 a:hover {
text-decoration: none !important;
}
.buttonlist a:hover {
    color: #464646;
text-decoration: none !important;
}

...now it's perfect. Thank you very much! I really appreciate your help very much! You made my day!  :)
Title: Re: Links underlinings
Post by: emanuele on August 25, 2016, 02:05:10 am
YAY! :D
Title: Re: Links underlinings
Post by: Jorin on August 25, 2016, 02:43:36 am
Oppps... The buttons with page numbers inside threads have underlined text when hovered, but they shouldn't. So I added:

Code: [Select]
.pagelinks a:hover {
text-decoration: none !important;
}

...and it works!  :D