Skip to main content
Topic: iOS 10 not showing editor buttons (Read 21560 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

Re: iOS 10 not showing editor buttons

Reply #90

Quote from: ahrasis – Just to be sure, I should look into the missing bbccode icons and emoticons errors, right?
Yes, this is how I see it on my forum 
image1.png
sorry for my bad english

Re: iOS 10 not showing editor buttons

Reply #91

1.5 was just recently released (after more than a year) but it has a bug where it strips bbc "code" indentation (tabs/spaces), I reported this when it was in beta but it was not fixed until the pending 2.0 branch. 

The 1.5 branch in our beta is "custom" as it does have the fix that I proposed for the code tag, so its good to go, I think we could include it in 1.0.10, although I should roll the 1.5.1 change back to it.

Still be nice to know what in the current branch broke with the latest ios on mobile so we could avoid it in the future.

Re: iOS 10 not showing editor buttons

Reply #92

So we do customize it a bit and that's great. Just to note, in 1.5.1 there is a "serious bug fix" which I think its fix should be included into our file as well. https://github.com/samclarke/SCEditor/issues/542

Re: iOS 10 not showing editor buttons

Reply #93

Quote from: radu81 –
Quote from: ahrasis – I found this (http://stackoverflow.com/a/35714835) just now which I think can help debugging; but I am rushing to finish some jobs for the time being. I'll try to look into it later.
I tried to install it in windows but without success. From the exe file I saw the name of the iphone, told me that I am connected but no device available from firefox when using Shift + F8.
I get it working by clicking Chrome Desktop and selecting the relevant tab on the left. And I use x64 version to suit my OS.

Re: iOS 10 not showing editor buttons

Reply #94

I posted a quick reply to find fault and I get this:
QuoteTypeError: undefined is not an object (evaluating '$['sceditor'].prototype')  jquery.sceditor.elkarte.js:183:30
TypeError: undefined is not an object (evaluating '$.sceditor.plugins')  splittag.plugin.js:24:12
TypeError: undefined is not an object (evaluating '$.sceditor.plugins')  drafts.plugin.js:293:12
TypeError: undefined is not an object (evaluating '$.sceditor.plugins')  mentioning.plugin.js:142:12
ReferenceError: Can't find variable: QuickReply  index.php:665:36
ReferenceError: Can't find variable: InTopicModeration  index.php:694:51
TypeError: undefined is not an object (evaluating '$.sceditor.locale')  index.php:4:13
TypeError: undefined is not an object (evaluating '$.sceditor.BBCodeParser')  index.php:589:28

Other warnings are the same:
QuoteInvalid CSS property declaration at: ;  jquery.sceditor.css:85:42
Unexpected CSS token: :  font-awesome.min.css:4:1924
Unexpected CSS token: :  font-awesome.min.css:4:2087
Unexpected CSS token: :  font-awesome.min.css:4:2253
Unexpected CSS token: :  font-awesome.min.css:4:2424
Unexpected CSS token: :  font-awesome.min.css:4:2597
Unexpected CSS token: $  index.php:84:15
Unexpected CSS token: $  index.php:85:16

Re: iOS 10 not showing editor buttons

Reply #95

I couldn't find anything really useful here actually. I attached here the picture of the only main error I can really confirm (which we already knew) which is:
QuoteTypeError: undefined is not an object (evaluating '$editor_data['message'].css')  index.php:638:28

Except for the minor css warning, others cannot be reproduced, so I don't think they are the problems.

The test is from my 1.0 site, please pm me if you want me to test on yours.

Re: iOS 10 not showing editor buttons

Reply #96

Quote17:35:04.626 ReferenceError: Can't find variable: elk_Toggle  index.php:193:44
17:35:04.633 TypeError: undefined is not an object (evaluating '$.sceditor.locale')  index.php:4:13
17:35:04.638 ReferenceError: Can't find variable: quickQuote  index.php:877:13
17:35:04.648 ReferenceError: Can't find variable: all_elk_mentions  index.php:51:45
17:35:06.222 Blocked a frame with origin "https://googleads.g.doubleclick.net" from accessing a frame with origin "http://www.skodaclub.it".  The frame requesting access has a protocol of "https", the frame being accessed has a protocol of "http". Protocols must match.
 ads:1:54964

Quote17:33:14.311 Unexpected CSS token: : hive-6d3fb9876cad879ca4a902a42b83e2081376745c.css:4:45464
17:33:14.325 Unexpected CSS token: : hive-6d3fb9876cad879ca4a902a42b83e2081376745c.css:8:2140
17:33:14.338 Unexpected CSS token: : hive-6d3fb9876cad879ca4a902a42b83e2081376745c.css:8:2303
17:33:14.348 Unexpected CSS token: : hive-6d3fb9876cad879ca4a902a42b83e2081376745c.css:8:2469
17:33:14.357 Unexpected CSS token: : hive-6d3fb9876cad879ca4a902a42b83e2081376745c.css:8:2640
17:33:14.365 Unexpected CSS token: : hive-6d3fb9876cad879ca4a902a42b83e2081376745c.css:8:2813

Re: iOS 10 not showing editor buttons

Reply #97

@ahrasis since apparently you have both a debugger and an iOS that doesn't show the icons (right?), would you mind testing it on elkarte.it? So that I can put up code and we can see if we can find something? I can provide you with an account, just let me know (or register yourself and I'll take care of approving the account).

What you posted confirms more or less what was reported before. Now the problem is identify the cause.
Bugs creator.
Features destroyer.
Template killer.

Re: iOS 10 not showing editor buttons

Reply #98

You can pm me the account for testing, I'll test it for you. And just post the code for testing in here. I'll help change it and see its outcome.

In the meantime, I think this is the only thing that should be look into as it reproduces, again and again:
Quote18:29:39.526 TypeError: undefined is not an object (evaluating '$editor_data['message'].css')  index.php:474:28
18:29:39.533 TypeError: null is not an object (evaluating 'g[h].parentNode.parentNode.parentNode.previousElementSibling.querySelector')  hive-731ed43c2d14d764a2d4367069694cfa1c5eecb6.js:215:482
18:29:40.759 Blocked a frame with origin "https://googleads.g.doubleclick.net" from accessing a frame with origin "http://www.skodaclub.it".  The frame requesting access has a protocol of "https", the frame being accessed has a protocol of "http". Protocols must match.
ads:1:54985

Re: iOS 10 not showing editor buttons

Reply #99

I think I found something .... well I know I did but lets see if it fixes the issue.   Use the attached file and let me know.

Re: iOS 10 not showing editor buttons

Reply #100

 Thank you Spuds, it's working! 8) 8)
sorry for my bad english

Re: iOS 10 not showing editor buttons

Reply #101

awesome sauce !

 

Re: iOS 10 not showing editor buttons

Reply #102

Great! So, no need further testing right?

One more question, what did you find @Spuds?
Last Edit: November 29, 2016, 07:53:14 pm by ahrasis

Re: iOS 10 not showing editor buttons

Reply #103

Seems like its working now so no need to test further ... but thank you for your help as it made me dig a bit deeper.

The issue is
Code: [Select]
!/OS [5-9](_\d)+ like Mac OS X/i.test(userAgent);
is being used to determine editor support or not ... thats forward (and fragile) looking instead of min level looking ... so that was changed to
Code: [Select]
/OS [0-4](_\d)+ like Mac/i.test(userAgent)

That change was added for version 1.4.7 but the ElkArte 1.0 branch is on 1.4.5 since at the time of 1.0.9 that was the current release.  Also 1.4.7 was (and is) very broken in other areas.

ElkArte 1.1 is currently using a version of 1.4.7, which is really 1.4.5 with some  specific fixes (1.4.7) backported to it (including the above), specifically ones that fixed issues without creating others.  If you are wondering what 1.4.6 is, well its 1.4.5 but refactored into modules (also broken).

I intend to update the current version 1.5.1 with a needed fix and use that for 1.1 RC1.   The next editor release is going to be be 2.0, hopefully that one will be really stable, but I don't know if it will hit in time for 1.1 final.

Re: iOS 10 not showing editor buttons

Reply #104

Quote from: ahrasis – Great! So, no need further testing right?
no, it's ok now, tested with iphone 5, and also 4 users on my forum confirmed that is working fine now. Thanks ahrasis for your help and thanks to all that contributed in this topic
sorry for my bad english