Skip to main content ↑ ↓
Topic: Post w/o subject locks out post body editing (Read 2359 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

Post w/o subject locks out post body editing

Here's a good one.  Make a new post, edit an old one, whatever.  Delete the subject and click post.  You get a warning on the subject field that says please fill out this line.  But after that you can't edit the body even if you fill out the subject.  You have to reload the page somehow (click post, reload button, etc.) to get the body back to allowing editing.

Re: Post w/o subject locks out post body editing

Reply #1 –

Code: [Select]
function submitThisOnce(oControl)
{
	// oControl might also be a form.
	var oForm = 'form' in oControl ? oControl.form : oControl,
		aTextareas = oForm.getElementsByTagName('textarea');

	for (var i = 0, n = aTextareas.length; i < n; i++)
		aTextareas[i].readOnly = true;

	return !elk_formSubmitted;
}

hmm... I always wondered if this code was really necessary or not...

Funnily enough, if you have the wiz editor enabled, you can still write.

 emanuele feels submitThisOnce can be deprecated and converted to a dummy function...
Bugs creator.
Features destroyer.
Template killer.

Re: Post w/o subject locks out post body editing

Reply #2 –

Well at the very least it needs fixing.  And unrelated this reminds me on your list of oldurl exclusions you should also exclude not just xml but also js .  So things like jsmodify don't become oldurls.

Re: Post w/o subject locks out post body editing

Reply #3 –

jsmodify is xml, so it's already excluded. ;)
Bugs creator.
Features destroyer.
Template killer.

Re: Post w/o subject locks out post body editing

Reply #4 –

Hmm.  I ran into something js that slipped through.  Too long to remember.  Probably me being stupid.