ElkArte Community

Elk Development => Bug Reports => Exterminated Bugs => Topic started by: TE on December 31, 2013, 09:10:20 am

Title: Homepage bugz
Post by: TE on December 31, 2013, 09:10:20 am
Mainly for @Spuds

The boxes on the homepage are not equal in width (blame me  :P ), this should fix it:

Code: (home.css) [Select]
.box div {
    width: 100%;
}
Title: Re: Homepage bugz
Post by: emanuele on December 31, 2013, 09:16:22 am
https://github.com/elkarte/elkarte.net

/me whistles innocently :P

And we need two addons:
1) mark as solved,
2) topics labels. :P (Or I could just finish the tags addon I was working on :P)
Title: Re: Homepage bugz
Post by: Spuds on December 31, 2013, 09:56:36 am
Quote from: TE – Mainly for @Spuds

The boxes on the homepage are not equal in width (blame me  :P ), this should fix it:

Code: (home.css) [Select]
.box div {
    width: 100%;
}
All updated.  I also had to add the additional browser box-sizing tags, at least in FF the layout was, well not box sized.  Should be all good now. 

Still chasing around a few bugs from the directory moves, probably need to add in a redirect directive for all the links that are now wrong :P
Title: Re: Homepage bugz
Post by: Spuds on December 31, 2013, 10:01:54 am
Quote from: emanuele – https://github.com/elkarte/elkarte.net

/me whistles innocently :P

And we need two addons:
1) mark as solved,
2) topics labels. :P (Or I could just finish the tags addon I was working on :P)
It was never clear to me what that was for  O:-) So that should reflect what we have installed on the site?  (so adding in the new home page and css should be done in that repo?)

Do you know if those mods licensed so we can convert them?
Title: Re: Homepage bugz
Post by: TE on January 01, 2014, 04:50:58 am
Quote from: Spuds – All updated.  I also had to add the additional browser box-sizing tags, at least in FF the layout was, well not box sized.  Should be all good now.  
great.

Quote from: emanuele – https://github.com/elkarte/elkarte.net

/me whistles innocently :P

And we need two addons:
1) mark as solved,
2) topics labels. :P (Or I could just finish the tags addon I was working on :P)

yep, both addons would help a lot.. "topic solved" is from @[SiNaN]  (still have a copy here), we should ask him regarding the license  ;)

elkarte.net repo: Totally forgot  that repo O:-) but it is completely outdated anyway. I think we'd need something which automatically synchronizes that repo with the server website. Dunno if  Github (api) or the server supports that?
Title: Re: Homepage bugz
Post by: emanuele on January 01, 2014, 06:51:38 am
@Spuds yes, I think the idea was to have it sync'ed with the live site providing a way to easily replicate it.

@TE we have to improve the @ thingy not to stop when non-alphabetic chars are used, otherwise [SiNaN] will never get the notification... :(
Title: Re: Homepage bugz
Post by: Spuds on January 01, 2014, 09:04:23 am
Quote from: emanuele – @Spuds yes, I think the idea was to have it sync'ed with the live site providing a way to easily replicate it.
Should be possible with the API or just the basic commands I would think.  A site to github, one way thing.
Quote from: emanuele –
@TE we have to improve the @ thingy not to stop when non-alphabetic chars are used, otherwise [SiNaN] will never get the notification... :(
Do you know if the restriction is in our code or in the atwho code?  

Quotetopic solved" is from @[SiNaN]  (still have a copy here), we should ask him regarding the license  ;)
In looking around I've found ones from [SiNaN],  Grudge,  Jay Bachatero, even a Simpledesk version ... They seem to have a common base and then each offer some different options.  

Anyway I've started on our version, hope to have the basics addon done soon so we can play with it, then we can decide what other features it may need.
Title: Re: Homepage bugz
Post by: emanuele on January 01, 2014, 09:14:19 am
Quote from: Spuds –
Quote from: emanuele – @TE we have to improve the @ thingy not to stop when non-alphabetic chars are used, otherwise [SiNaN] will never get the notification... :(
Do you know if the restriction is in our code or in the atwho code? 
I think atwho... but it should be possible to "hook" into the filter... or not, I did it a while ago and already forgot almost everything. lol

Quote from: Spuds – Anyway I've started on our version, hope to have the basics addon done soon so we can play with it, then we can decide what other features it may need.
You are darn too fast! :P
BTW, that would be a good way to find out if Elk needs more hooks or things like that. O:-)
Title: Re: Homepage bugz
Post by: [SiNaN] on January 01, 2014, 09:46:08 am
Just to note, I think I had told emanuele that he could do whatever he wanted with the Topic Solved mod and that still stands, in case you need it or a part of it.
Title: Re: Homepage bugz
Post by: Spuds on January 01, 2014, 10:53:32 am
Quote from: [SiNaN] – Just to note, I think I had told emanuele that he could do whatever he wanted with the Topic Solved mod and that still stands, in case you need it or a part of it.
Thank you !!
Title: Re: Homepage bugz
Post by: emanuele on January 01, 2014, 11:17:39 am
:+100:

Yes, now that you said I remember! (Is it not yet time for Johnny Mnemonic's technology? O:-))
Title: Re: Homepage bugz
Post by: [SiNaN] on January 01, 2014, 01:26:01 pm
No problem. Just make the mentioning thing work with my name and we'll be even. :P
Title: Re: Homepage bugz
Post by: emanuele on January 01, 2014, 05:07:02 pm
Done!
https://github.com/emanuele45/Dialogo/commit/0267c4335dd7ef1bdf1f9fc667cba3d2002c1287
Title: Re: Homepage bugz
Post by: [SiNaN] on January 01, 2014, 06:39:16 pm
Thanks! I'll test it once you guys update the site. ;)
Title: Re: Homepage bugz
Post by: Spuds on January 02, 2014, 05:16:58 pm
QuoteBTW, that would be a good way to find out if Elk needs more hooks or things like that. O:-)
It did need a few, and a few fixes / tweaks in a couple of areas ... https://github.com/elkarte/Elkarte/pull/1210

The first pass of the addon is here:  https://bitbucket.org/spuds_/solved-topics.  Not sure what other features we want, sooooo
Title: Re: Homepage bugz
Post by: Aaron on January 02, 2014, 06:48:15 pm
Another bit: can we get a redirect for /index.php to /community/index.php when the query string isn't empty, or at least when $_GET['topic'] is set? Helps when clicking through old links on GitHub (and SEO of course).

(Probably should've created a new topic for this. Oh well.)
Title: Re: Homepage bugz
Post by: Spuds on January 02, 2014, 07:08:29 pm
Thats one of my todo's .... nginx has been fighting me with the change, and its winning  :( 

I'll try again tonight, as I think I was working with the wrong location block with my rewrite command.
Title: Re: Homepage bugz
Post by: Spuds on January 03, 2014, 11:49:19 am
Should be a bit better now on the redirects ... still some quirks that I'll work on but for now a link like:
http://www.elkarte.net/index.php?topic=877 should become a permanent redirect with /community/ added in and going to http://www.elkarte.net/ should just show the home page
Title: Re: Homepage bugz
Post by: forumsearch0r on January 03, 2014, 08:28:43 pm
Once you're in the board, you can't go back to the portal, or have I just missed the link?
Title: Re: Homepage bugz
Post by: TE on January 04, 2014, 03:22:14 am
Quote from: forumsearch0r – Once you're in the board, you can't go back to the portal, or have I just missed the link?
The "portal" page is just a landing page, the content is almost static and there is IMO no reason to go back to that page..
Title: Re: Homepage bugz
Post by: forumsearch0r on January 05, 2014, 01:23:21 pm
Depends on what's on that page, right? I'd assume that the board logo goes back to the site index, not to the index of a subpage (the board).
Title: Re: Homepage bugz
Post by: emanuele on January 05, 2014, 03:25:22 pm
Playing with it, created an svg version. :D