Is there an option somewhere to put it back how it was? Or dare I say how it's supposed to be. :P
It seems there's not short of going and disabling quick reply entirely. What was wrong with honor the collapsed state of quick reply?
If you have QR enabled
at all, the board should use it. Don't like QR? Disable it.
And we let you fold it why then? This is change for change's sake.
Click on the arrow on the right? :P
Yes I know we can collapse. But by forcing it open when I click quote it's pointless. I truly don't understand the push to eliminate the post page.
Why not skip the post page entirely and put all of the options, the post page has, right into the quick reply section (close a topic, attach a file, etc)? I could live with that (no: I would love to see that in action!), it would be much faster to reply in a topic (and it would look more like social networking). :)
That's where they want to go it seems. Not a fan myself.
Ahhh... the quote.
Okay, as a quick fix, remove this part from topic.js:
if (this.bCollapsed)
{
this.bCollapsed = !this.bCollapsed;
this.swap(false, false);
}
About the post page... dunno to me looks a duplication, but if you want it I'm not against keeping it.
Will there be a modification to put the ability to attach a file, close the topic, etc to quick reply? And skip the post page? O:-)
Yes please keep it. Thank you.
And it was fixing topic.js to turn this behavior off that was causing problems with the minimizer I posted in the other thread. But thanks for the fix.
Just a quick question: can you
@scripple describe a bit how you use the quick reply?
Not joking, I'm really interested in understand it, because wouldn't be for attachments and preview I'd use only that, so I'm biased on one side, instead you seem to use the quick reply in a way rather different, including the expand/collapse (thing that I have never ever used).
So it seems you keep the quick reply collapsed (minimal I suppose, just the textarea, right?), you open it just to answer "in some cases" (which?) and then you close it (so now you "expand-post-and-close-it", correct?).
You want the quote to always go to the post page, is there a specific reason? (The box too small? You use the WYSIWYG when quoting?).
In case you don't quote you always use the quick reply? Or just seldom?
I'm really trying to gather some informations to see if there is some good alternative for everybody. ;D
For example I know I tend to use the full post page for the quoted text because of the ctrl+enter splitting of the quoted text that is not available in the simple textarea of the quick reply. But that happens only if I have to split quotes.
If you use the "full" editor (i.e. the one will all the buttons), quote a message and you obtain something like:
[quote]
this is a quoted message
with more than one line
[/quote]
If you put the cursor in the empty line:
[quote]
this is a quoted message
<---- CURSOR HERE
with more than one line
[/quote]
and use ctrl+enter from the keyboard, it splits the quoted text to:
[quote]
this is a quoted message[/quote]<--- the cursor is here
[quote]
with more than one line
[/quote]
You have now split the quote without having to copy the quote tag or write a new one, etc. to end up with:
[quote]
this is a quoted message[/quote]
This is my reply to the first line
[quote]
with more than one line
[/quote]
And here I answer your second line.
Cool. You need to make a manual for all this stuff (like STRG+B)! :D
ehhh... yes, on day or another... O:-)
I use the quick reply pretty rarely, only for very simple replies where I'm already at the bottom of the page. I also use it from a script in an addon but I can easily remove that if it eventually comes down to QR being all or nothing. My issue with expanding the box via a script is that that's not how the other collapsed areas in elk work. It breaks the UI. If a user makes a choice to collapse something then you shouldn't expand it automatically when a clear alternative path (the post page in this case) exists. It's like a short cut from having to go into look and layout and click a box and click save. Except now it's an inconsistent short cut.
I especially avoid quick reply on mobile on my forum because I have animated smileys and they slow down the page when typing. So I always use the post page where I load alternate static smileys. (And before you ask, the users voted not to go to static smileys everywhere.)
But for quoting I find the QR annoying because of the default small box size and the lack of the ctrl+enter feature. I also find it annoying because if I'm quoting multiple recent messages the post page always has a predictable number of post pages but QR is subject to the pagination of the standard reading pages. I'd probably leave QR open and use it more if quotes always went to the post page like the reply button does. And that's also something I find a little odd that two buttons right next to each other behave so differently, but I guess there's no other way to let people who like the QR box use quotes.
So if the majority really thinks this is how QR and quoting should work, as long as the post page isn't going away I guess I can live with having to turn off the QR and leave it off. But if you're going that route maybe it shouldn't be collapsible and there should be some hint how to turn it off. I know a lot of users never explore the huge list of options in the look and layout page.
Just for reference, I changed that behavior, discussed here: http://www.elkarte.net/community/index.php?topic=1435.msg9618#msg9618
ETA:
split quote should work fine and the box not be small if you have enabled "use full editor in qr" or whatever that option is called in look and layout
Make sense.
Usually I don't ask others to change what they do, I try to understand why they do something. ;) Of course once in a while I sneak in the code something odd that may or may not be welcome... It happens. O:-)
That's actually an interesting solution.
So in the post page all the smiley that appear in the posts below are different from the ones that usually are around, did I get it right?
/me knows the feeling. O:-)
Well, they are not exactly "next to each other", one is next to each message, the other is at the beginning or at the end of the page, but okay. :P
I think I added the js code because it seemed somehow not illogical, the idea I had of the general usage was that you either have it on or do not have it at all. I never understood the reason to have it closed, I never see an actual use for that state. Now you say that you keep it close in order to "force" the quote to go to the post page and is a hint.
So, thank you very much for taking the time to describe your use-case, very appreciated. :)
I'd have another question if you don't mind, how do you feel about multi-quoting?
I opened
a topic (http://www.elkarte.net/community/index.php?topic=1449.0) a while ago trying to collect ideas. Reading your description, it may look like a kind of multi-quote may help in your case (in the sense that it would give you much more freedom and "easiness" on the process), but I'm not entirely sure. You may pick quotes while you are reading and then put them back all at once in the editor (or one at the time while answering) in the post page.
Of course I'm just throwing around ideas while writing.
Personally I'd be in favor of removing the post page if we of course moved attachments and all the other features into the topic (display template) view.
Yes that is correct. The smileys in the post below and the smileys in the editor selection row and popup are all replaced with static single frame versions of the animated smileys that appear on normal reading pages.
You're right. I always think they are together. And then when I go to hit reply to my brain it's like "Where is the damn reply button???". No idea why that association exists or why it won't go away.
You're welcome. Thanks for discussing with an open mind.
I've done plenty of replies that quoted multiple posts. Especially with my image annotation tending to have people leave several comments on a single post as they annotate various images. An easy way to check the posts I'd like quoted and then when I press quote would put them all in with a line space between them would be quite handy.
/me should remember to remove the js (I'm messing with some other stuff I prefer to finish before switching branch to avoid even bigger messes)
So we are going to revert https://github.com/elkarte/Elkarte/pull/1575/files ? Just trying to understand what we are doing.
I'd say just that piece:
+ // Collapsed on a quote, expand it but don't update the user setting
if (this.bCollapsed)
{
- window.location.href = elk_prepareScriptUrl(this.opt.sScriptUrl) + 'action=post;quote=' + iMessageId + ';topic=' + this.opt.iTopicId + '.' + this.opt.iStart;
- return false;
+ this.bCollapsed = !this.bCollapsed;
+ this.swap(false, false);
}
not the entire stuff that to me still makes a lot of sense.
I'd think you could remove most of those changes TBH ... meaning why have a minimize at all on the qr area or why save the expand/collapse state? If whats wanted is the original way then I think having the multiple options (yuk) in the profile should be set back and add better descriptions of what the behavior will be with each option. Just please give me a hook so I can write an addon :D