ElkArte Community

Elk Development => Bug Reports => Exterminated Bugs => Topic started by: scripple on October 06, 2015, 11:07:10 pm

Title: Upgrade to 1.0.5 Font Awesome Error
Post by: scripple on October 06, 2015, 11:07:10 pm
Trying to upgrade to 1.0.5 tonight.  I get a not found on the following resource.

"forum/themes/default/webfonts/fontawesome-webfont.woff2?v=4.4.0"

Indeed there is no woff2 version in the webfonts directory.  css/font-awesome.css doesn't mention it but the .min.css version does.  Something is broken here.
Title: Re: Upgrade to 1.0.5 Font Awesome Error
Post by: emanuele on October 07, 2015, 02:12:28 am
Arg...

/me blames @Spuds :P
Title: Re: Upgrade to 1.0.5 Font Awesome Error
Post by: Jorin on October 07, 2015, 02:16:53 am
Great! I did not update till now.  :D
Title: Re: Upgrade to 1.0.5 Font Awesome Error
Post by: Spuds on October 07, 2015, 05:55:17 am
Yeah its missing in the 1.0.5 package file. I missed it when I made the commit (a new file vs a changed file thing).  You just need to add that file to your /themes/default/webfonts directory.

Other than a file not found annoyance in the dev window, I don't think there is any negative impact.  The woff2 should be the same as the woff file that is included, but woff2 is more compressed for browsers that support that format.  I've attached that one file to this post as well.

I blame my incompetence on age, and maybe booze, but mostly age :P
Title: Re: Upgrade to 1.0.5 Font Awesome Error
Post by: scripple on October 07, 2015, 10:18:20 pm
What about the css and min.css not being in sync?
Title: Re: Upgrade to 1.0.5 Font Awesome Error
Post by: Spuds on October 08, 2015, 06:10:40 am
Remove the .css and leave the min.css version, its whats called for from the sources.  We moved to using the .min.css to save having to compress a file that no one would customize anyway. 

The upgrade script should have removed the old .css file, its not part of the repo any longer.
Title: Re: Upgrade to 1.0.5 Font Awesome Error
Post by: emanuele on October 09, 2015, 08:29:07 am
I guess I didn't realize and didn't remove the css one... :(
Title: Re: Upgrade to 1.0.5 Font Awesome Error
Post by: Spuds on October 09, 2015, 04:48:51 pm
It was probably in one of my rambling commit messages.  Then again I did not remember that the updater needed to be changed when I made the commit, so really my mistake on this one.
Title: Re: Upgrade to 1.0.5 Font Awesome Error
Post by: emanuele on April 25, 2016, 05:22:28 am
Did we forget again about that or it was fixed?
Title: Re: Upgrade to 1.0.5 Font Awesome Error
Post by: Spuds on April 25, 2016, 09:19:50 am
Should have been fixed here starting at 1.0.6 https://github.com/elkarte/Elkarte/commit/39d8dcfed6a78af023f5e808daeef4d2f41e50d4
Title: Re: Upgrade to 1.0.5 Font Awesome Error
Post by: emanuele on April 25, 2016, 09:39:01 am
Great! :D