Text only | Text with Images

ElkArte Community

Elk Development => Feature Discussion => Exterminated Features => Topic started by: Frenzie on August 26, 2017, 03:20:17 pm

Title: Should m.youtube.com be auto-embedded?
Post by: Frenzie on August 26, 2017, 03:20:17 pm
Someone browsing on a cellphone or tablet might post a link like this:

https://m.youtube.com/watch?v=bMrs8Lrjz0I

Obviously it'd be very easy to add here (https://github.com/elkarte/Elkarte/blob/c58a9e6ecf9ea836d77d02a2ff458b7413b755bf/themes/default/scripts/elk_jquery_embed.js#L176). The question is, should we? It's not an "official" sharing link.
Title: Re: Should m.youtube.com be auto-embedded?
Post by: Spuds on August 26, 2017, 05:18:38 pm
I don't see any harm in adding that, seems like a good thing to support IMO
Title: Re: Should m.youtube.com be auto-embedded?
Post by: ahrasis on August 26, 2017, 07:17:55 pm
I always thought mobile links will normally redirected to normal links if we are using browsers in desktop but will not be vice versa / the other wway around. So, I think it should be good to add that.
Title: Re: Should m.youtube.com be auto-embedded?
Post by: Frenzie on August 27, 2017, 03:56:51 am
Alright, PR sent: https://github.com/elkarte/Elkarte/pull/2980

PS When I said "someone might post" of course I meant "someone posted this a few hours ago". :P
Title: Re: Should m.youtube.com be auto-embedded?
Post by: emanuele on August 27, 2017, 05:08:31 am
Merged, I'll grab it for RC2 that I hope to pack today.
Text only | Text with Images