Print Page - Index.css - Minor issue with curly bracket spacing

Title: Index.css - Minor issue with curly bracket spacing
Post by: Lou on February 13, 2016, 10:14:36 am

Starts about line 1511 in index.css. Issue is the spaceing between .letterspacing and the '{'.

Currently is...

/* Basic cells. */
.table_grid td, .letterspacing{
    padding: 5px 8px;
    border-bottom: 1px solid #ccc;
}

Should be...

Code: [Select]

/* Basic cells. */
.table_grid td, .letterspacing {
    padding: 5px 8px;
    border-bottom: 1px solid #ccc;
}

Title: Re: Index.css - Minor issue with curly bracket spacing
Post by: Burke Knight on February 13, 2016, 10:27:11 am

Should have no effect, so not really a bug.
I've seen many people use one line and no spacing.

Code: [Select]

.table_grid td, .letterspacing{padding:5px 8px;border-bottom:1px solid #ccc;}

Title: Re: Index.css - Minor issue with curly bracket spacing
Post by: Lou on February 13, 2016, 10:49:17 am

True dat. :) Simply an issue and mostly cosmetic, but I could not determine a good place to put the post. Maybe someone can move this to the Theme section or delete the post if they want?

Title: Re: Index.css - Minor issue with curly bracket spacing
Post by: emanuele on February 13, 2016, 06:40:34 pm

I guess bug reports is fine. ;)
Not something I'd fix in a micro, but something to have a look in 1.1. :)

Title: Re: Index.css - Minor issue with curly bracket spacing
Post by: Joshua Dickerson on February 13, 2016, 10:32:26 pm

@Lou, submit a pull-request :D. We need more people committing.

Title: Re: Index.css - Minor issue with curly bracket spacing
Post by: Lou on February 14, 2016, 10:37:49 am

Well, I have just been traumatized on a Sunday by GitHub by creating an account and forking Elkarte over to my account.

I am fairly certain God is punishing me at this point. :)

Title: Re: Index.css - Minor issue with curly bracket spacing
Post by: Lou on February 14, 2016, 10:54:12 am

Lucky me. :) It looks like the errant bracket spacing has already been fixed in the repository. I guess that change was made after I had made the zip download that I installed Elkarte with. I suppose I could submit the changes for the Member Options and see if they are acceptable.

Title: Re: Index.css - Minor issue with curly bracket spacing
Post by: Spuds on February 14, 2016, 10:59:28 am

LOL ... Another happy GIT user :P

That bracket could have been fixed in the development branch by me, I know I did some CSS reformatting / layout stuff for 1.1

ElkArte Community

Elk Development => Bug Reports => Exterminated Bugs => Topic started by: Lou on February 13, 2016, 10:14:36 am