Re: Sensiolab insight
Reply #4 –
To determine one is a bug, one thing, and to rewrite the code while eliminating it is another. While it should sound simple to the experts in coding, it is not so simple, at least for people like me. Moreover people with no coding knowledge or experience.
Even trying to add an option to install a new variant from admin CP seems difficult enough for me unless I have a lot of time for it.
While doing it, I can also see most code have changed from 1.0 to 1.1 making it more difficult to understand and keep up with.
So, unless "the very easy things" are specifically outline, like may be in a sticky post, for general coders they may feel like finding a needle in a hay stack, which they do not have time for.
If listed, I think they can surely be sorted out gradually, one by one.
Re: Sensiolab insight
Reply #7 –
Sounds like those two are so egregious that no one wants to refactor them. Hmm... sounds familiar...
The one and only time I debugged SMF's upgrader, I chased many a wild goose in the form of spaghetti code only to realize that the fix was in a single line of Javascript.
Re: Sensiolab insight
Reply #9 –
Install and upgrade are two huge P.I.T.A.
What I did so far is basically just a moving around things and splitting down to try to understand what the various parts do (the two files ToRefactorCore.php and LegacyCode.php are an example of the early state of the work).
Anyway, even only the fact that now install and upgrade use the db abstraction layer is a major step forward. nods