ElkArte Community

Project Support => General ElkArte discussions => Topic started by: emanuele on April 01, 2013, 07:28:20 pm

Title: That theme is WHITE!
Post by: emanuele on April 01, 2013, 07:28:20 pm
Subject says it all! :P

And some parts don't work properly...
Title: Re: That theme is ugly!
Post by: TestMonkey on April 01, 2013, 08:01:16 pm
Lol. Noes, it's ... too white (hah, not sure), and yes, some parts are slightly strangely behaving.
I changed back the default (since you said that), but I enabled the selection of themes.

The white theme is at: http://www.elkarte.net/index.php?theme=3

And in the repo at: https://github.com/elkarte/elkarte.net/tree/master/elk/themes/minimalist

And zipped attached to this post, for who wants to give it a test run at home.
Title: Re: That theme is ugly!
Post by: Spuds on April 01, 2013, 08:18:26 pm
I haz retina damage now ... thanks!
Title: Re: That theme is ugly!
Post by: TestMonkey on April 01, 2013, 08:44:29 pm
What does it need, some darker/fadeout instead of purely white?
Title: Re: That theme is ugly!
Post by: Spuds on April 01, 2013, 08:46:37 pm
Don't know ... maybe some light greys for the div backgrounds?
Title: Re: That theme is ugly!
Post by: TestMonkey on April 01, 2013, 09:06:42 pm
Yep! Just to note quickly, the moderation trick is nice, it surely saves space and even if you're not a fan of, it's only for mod-type of actions

The buttons look too curve-ish though, we probably want that changed.
Title: Re: That theme is ugly!
Post by: Trekkie101 on April 02, 2013, 06:43:36 am
Selection of themes is back off... ;P
Title: Re: That theme is ugly!
Post by: TestMonkey on April 02, 2013, 06:55:57 am
I don't know why that happened! I set it back on.
Gremlins, methinks. Or Ema.
Title: Re: That theme is ugly!
Post by: Trekkie101 on April 02, 2013, 06:58:43 am
How did it turn green also :?
Title: Re: That theme is ugly!
Post by: TestMonkey on April 02, 2013, 07:03:08 am
Hah! I added also another theme, a color scheme variation, from the themes repository. Actually we could make a different color scheme default?

I (heavily) prefer the white-ish (and its js tricks), and anyway it's a theme in the works, not a variation, but we need to tweak it more :D
Title: Re: That theme is ugly!
Post by: TestMonkey on April 02, 2013, 07:47:07 am
Quote from: TestMonkey – I don't know why that happened! I set it back on.
Gremlins, methinks. Or Ema.
It was a bug. Or Ema, of course (this part always stands.  O:-) )

Not yet on the site, it will work once updated.
Title: Re: That theme is ugly!
Post by: emanuele on April 02, 2013, 08:01:42 am
/me didn't do anything!
...or at least I don't remember... :P
Title: Re: That theme is WHITE!
Post by: TestMonkey on April 02, 2013, 08:39:09 am
Nah, but someone must be the default. :)

Btw it looks like it's not Elk-ish, but inherited from 2.1. You may want to add it to your cherry-picking list. I do not believe I will bother to, sorry.
Title: Re: That theme is ugly!
Post by: emanuele on April 02, 2013, 08:55:16 am
That's the reason I find lame release a beta and not use it live... you will never discover all such "tiny" issues if you don't have a quite active testing user base.

/me takes note.
BTW it's already quite difficult to cherry-pick. :P
Title: Re: That theme is ugly!
Post by: tycms on April 02, 2013, 09:23:16 am
In case you didn't notice, this is how the regular members see the "Report Post" button. Do you intend to keep it like this?
(http://i48.tinypic.com/a9mqs0.png)

If it is the member's own post, then it is like this:
(http://i49.tinypic.com/10z7a11.png)
Title: Re: That theme is ugly!
Post by: Feature Cat on April 02, 2013, 09:36:53 am
Quote from: tycms – In case you didn't notice, this is how the regular members see the "Report Post" button. Do you intend to keep it like this?
(http://i48.tinypic.com/a9mqs0.png)

If it is the member's own post, then it is like this:
(http://i49.tinypic.com/10z7a11.png)

Ouch, thanks for reporting!
Title: Re: That theme is ugly!
Post by: tycms on April 02, 2013, 10:46:19 am
Is it really desirable to keep the "new" icon to the left of the topic title? (I know that this is inherited from SMF 2.1) When a topic is read, the topic title moves to the left whereas all the unread topic titles stay to the right of the "new" icons. Isn't this a rather inconsistent layout?

One more thing about the "new" icon: In case someone wants to remove it in SMF 2.0.x, it is possible to do this without editing the code just by replacing it with a transparent icon. In SMF 2.1 layout this is not possible.

p.s.
Well, I realize that this is controversial. In this layout the "new" icons are all aligned to the left, whereas in the old curve theme they are scattered all round depending on the title lengths. Aligning the topic titles or the "new" icons... It depends on how you look at things.
Title: Re: That theme is WHITE!
Post by: emanuele on April 02, 2013, 11:30:17 am
Aha I was not dreaming! I think I saw that dropdown menu some time ago, but I completely forgot about it, thanks!

And well...the "new" on the left is one of the things that would move somewhere else in my own theme. O:-)
Title: Re: That theme is WHITE!
Post by: tycms on April 02, 2013, 06:08:58 pm
This is how guests see the topic icons:

(http://i47.tinypic.com/vphwci.png)

Is the "poll" icon really needed there together with "locked topic" and "sticky topic" icons? It seems that a rearrangement is needed even if it is kept there. In general you could rethink about the design of topic icons and message icons as an whole.
Title: Re: That theme is WHITE!
Post by: Spuds on April 03, 2013, 10:51:05 am
The topic icons and the report to moderator pulldown items were addressed in a recent commit (and will show up here when they do!) ... thanks for reporting.

Title: Re: That theme is WHITE!
Post by: emanuele on April 04, 2013, 07:49:45 am
Quote from: TestMonkey – Yep! Just to note quickly, the moderation trick is nice, it surely saves space and even if you're not a fan of, it's only for mod-type of actions
I planned to add a similar trick for go up/down and pages (i.e. "move" or so...and maybe linktree and jump-to too), not yet sure where put it exactly yet, probably up-left corner or lower-right.

Quote from: TestMonkey – The buttons look too curve-ish though, we probably want that changed.
I told you it's far from finished! :P
/me is not a theme guy, he needs quite a bit of time to change themes. O:-)
Title: Re: That theme is WHITE!
Post by: tycms on April 04, 2013, 09:05:56 am
On my local install (created from ElkArte repo today) on/off images are missing in the "core features" part of the administration center. (index.php?action=admin;area=corefeatures)

These are probably incomplete parts of the theme rather than bugs. That's why I am reporting all of these in this particular topic. I hope this is fine with you.
Title: Re: That theme is WHITE!
Post by: emanuele on April 04, 2013, 10:17:29 am
The "reply" is pissing off the "more" button... at least on my browser, have to check with others.

@tycms, I think it's better if we keep this topic about just the "minimalist" theme (i.e. http://www.elkarte.net/index.php?theme=3 ) and open a new topic if there are other issues with the current default theme. :)
Title: Re: That theme is WHITE!
Post by: tycms on April 04, 2013, 12:08:17 pm
OK Emanuele, I will report anything I notice about theme 3 here.
Title: Re: That theme is WHITE!
Post by: emanuele on April 08, 2013, 11:19:19 am
TBH, I'm becoming addicted to that theme! lol
I really have to clean it up and fix it. O:-)
Title: Re: That theme is WHITE!
Post by: emanuele on April 11, 2013, 06:09:27 am
I didn't realise you set it as default (again)... lol

/me haz to really fix it then... O:-)
Title: Re: That theme is WHITE!
Post by: Arantor on April 11, 2013, 10:39:22 am
/me switched to another theme some days ago, the white theme actively hurts to look at because there's not enough contrast with things.
Title: Re: That theme is WHITE!
Post by: emanuele on April 16, 2013, 06:15:54 pm
Today I pushed something:
1) avatar dimensions
2) cropped the name with css
3) changed some #666 to #222
Title: Re: That theme is WHITE!
Post by: emanuele on April 27, 2013, 05:46:49 pm
/me is thinking the message index could change a bit too...

Mock-up made using Opera, so nothing working yet.

In other words, the idea is to get rid of the boring tabular aspect giving more result to what is (or should be) actually relevant (the subject that is bigger (1.3em) and in bold) and then fill up the huge space left with some not-so-relevant informations (starter, usual icons, last message with link, replies and views).
And use of a <select> for sorting.

Of course placing, order of elements, and so is mostly random.
Title: Re: That theme is WHITE!
Post by: The Craw on April 28, 2013, 12:33:38 am
/me likes the default blue theme best.
Title: Re: That theme is WHITE!
Post by: emanuele on April 28, 2013, 04:41:37 am
/me doesn't care what people like :P

This theme was born as an experiment for me to play with removing stuff that is not strictly useful and make a theme that was focused even more than Curve/Penguin II on the content.
Then TestMonkey stolen it and made the default here, though in my mind it is still my theme and I'm going to remove (and add :P) all the crap I want experimenting different options. And on top of everything: it will maintain a white (or very close to white) base color, if you don't like it don't use it (or fork it). :P
Title: Re: That theme is WHITE!
Post by: TE on April 28, 2013, 09:47:02 am
To be honest, that theme is absolutely great and should definitely be part of the core 8) Yes, t is too "cold" to be used on a website but it is a perfect base for a custom theme.
Title: Re: That theme is WHITE!
Post by: emanuele on April 28, 2013, 12:00:15 pm
Pushed the last ideas to a new branch:
https://github.com/emanuele45/Dialogo/tree/drift
Title: Re: That theme is WHITE!
Post by: TestMonkey on April 28, 2013, 02:41:37 pm
Quote from: TE – To be honest, that theme is absolutely great and should definitely be part of the core 8) Yes, t is too "cold" to be used on a website but it is a perfect base for a custom theme.
You mean, the white theme? The perfect base for a custom theme should be the default Elk theme. Yes, there are trade-offs with eye-candy and even presence of functionality at-hand. But if it is easily customizable indeed, then creation and use of custom themes for sites will be less of a problem as they've been for SMF.
Just a few thoughts.
Title: Re: That theme is WHITE!
Post by: TE on April 28, 2013, 02:54:46 pm
Quote from: TestMonkey – You mean, the white theme? The perfect base for a custom theme should be the default Elk theme. Yes, there are trade-offs with eye-candy and even presence of functionality at-hand. But if it is easily customizable indeed, then creation and use of custom themes for sites will be less of a problem as they've been for SMF.
Just a few thoughts.
Yep, I meant the white theme :) It is extremly simple to colorize, you don't need to spend hours  just to remove the old colors from the theme and add some fancy new ones..
Title: Re: That theme is WHITE!
Post by: emanuele on April 28, 2013, 04:10:32 pm
Well, that's mostly Ant's job, not mine.
I removed some other, that's true.
Title: Re: That theme is WHITE!
Post by: emanuele on April 29, 2013, 07:43:41 am
Back on the theme, on the last version I upped the #top_section is position:fixed, now I'm considering if move the remaining menu elements there would be a terrible thing to do...
/me whistles innocently

Independently, I'm considering to re-do the header too: I don't like much to have logo on the right and name on the left (or the other way around), I think it would make more sense to have:
Code: [Select]
---------------------------------------------------------------------------------------
     Logo                                |                                  News fader [2]
name/description [1]                     |                                         |A| [3]
---------------------------------------------------------------------------------------
link tree
---------------------------------------------------------------------------------------
rest of the page

[1]: I'd add also an admin setting to change some basic aspect (i.e. a bigger or smaller font depending if it is a name or a description).
[2]: news fader right-aligned and since it would be there on all pages, I would removed it from the board index also considering that the code is rather small (~1 KB uncompressed removing the header, more or less a 2% of the script-js, not that much)
[3]: that would be the collapse button

ETA: also about the position:fixed, most likely I'll changed it back to what it was and then use some jquery to show it when in the middle of the page moving the mouse close to the top of the screen.
Title: Re: That theme is WHITE!
Post by: emanuele on May 25, 2013, 12:51:17 pm
The experiments go on:
(http://img203.imageshack.us/img203/2761/screen97.th.png) (http://img203.imageshack.us/i/screen97.png/)

At least that way the menu is actually useful! :D :P

The news block is the news fader (I should add an option to make the news random.)

Maybe the "hello" thing could go up next to the avatar...would probably make sense.