ElkArte Community

Elk Development => Bug Reports => Exterminated Bugs => Topic started by: Adrek on July 27, 2014, 11:15:44 am

Title: Doubled permission for Like posts
Post by: Adrek on July 27, 2014, 11:15:44 am
I noticed there are two permissions called Like other users' posts.
First is in General permissions:
(http://i.imgur.com/EtUsknJ.png)

After adding permission for group they can like posts.

Second is in Topics section:
(http://i.imgur.com/P6AuJvP.png)

This one doesn't seem to work, Like button is not in posts, or maybe it's for something else, but only name is incorrect?

ElkArte version: 1.0 RC2
Title: Re: Doubled permission for Like posts
Post by: emanuele on July 29, 2014, 11:02:43 am
/me blames @Spuds! :P

Or is it intended?...
Title: Re: Doubled permission for Like posts
Post by: Spuds on July 29, 2014, 11:26:03 am
Thats to allow you to enable like permissions at a board level, so turn off likes for groups of certain board profiles (am I wrong?).  Could shift it under the general title instead of topic title of permissions, or is there a better place?
Title: Re: Doubled permission for Like posts
Post by: emanuele on July 29, 2014, 02:51:41 pm
So you can enable at "forum level" and then filter at "board level"? (Sorry I didn't look into the likes code recently lol)
Title: Re: Doubled permission for Like posts
Post by: Spuds on July 29, 2014, 03:29:20 pm
Well one is a member level permission under permissions and the other is under board permissions so you can remove that permission with a custom (or even the default) board profile.   So you could prevent the liking of posts in say an archive board.  Maybe its not needed shrug
Title: Re: Doubled permission for Like posts
Post by: Adrek on July 29, 2014, 03:32:11 pm
How about adding in board settings checkbox: Disable Likes for this board and removing this second permission?
Title: Re: Doubled permission for Like posts
Post by: [SiNaN] on July 29, 2014, 03:56:13 pm
From what I understand you can allow/deny any member liking posts for any board you want using the board based permission alone. Why don't you just leave the board based permission and remove the general one?
Title: Re: Doubled permission for Like posts
Post by: emanuele on August 09, 2014, 12:16:10 pm
I removed the global one as suggested by [SiNaN] and added the permission by default to the boards (there was also an allowedTo that was supposed t be isAllowedTo breaking the permission checks...).

/me is innocent... probably not. lol