Re: ILA drafts and attachments
Reply #16 –
After three months and quite some work on it, I have to say I'm very lost. Furthermore the new BBC parser changed the situation even more.
I'm not sure I can fix ILA and the drafts any time soon. I've reached the point I start thinking that propose to drop ILA from 1.1 and have the release is better than try to fix it "somehow" with potentially lost of bugs. Then, once 1.1 is out, ILA and attachments can be re-worked and made it work properly.
Re: ILA drafts and attachments
Reply #19 –
I'm kind of so so on that idea TBH ... I can see not having the save draft attachments as part of B1, but to not have ILA as part of B1 seems more like an Alpha1 .. kind of a major feature to not be in the first beta.
Re: ILA drafts and attachments
Reply #20 –
The meaning of my post was more "not have ILA in 1.1", actually.
But I guess that's a bit too much?
Re: ILA drafts and attachments
Reply #23 –
Tough decision.
I don't think we should be allowed to remove hooks in minor versions but we can certainly add new ones and add passed parameters to the hooks. So, if you can continue working on it in a plugin that would be great and it would allow the development of 1.1 to continue. Then, when we start working on 1.2 or whatever is next, the first thing that goes in to it would be ILA (assuming that it's been created as a plugin).
I really think this is the best way to go with features in general. It allows features to constantly be created but not get in the way of refactoring or bug fixing. I proposed it once or twice at SMF but I realized it takes a lot more work and slows the development of features so I didn't really push it. It's why I ask people whenever I see them making code edits where we can add in a hook. They are easy to add and don't break anything if you add more.
Re: ILA drafts and attachments
Reply #25 –
I can see 2.1 having more hooks compared to ElkArte sometimes ago.
Re: ILA drafts and attachments
Reply #27 –
I've only been looking at it for a short while and I'm not seeing an "easy" addon solution ATM but have not looked in depth. Even the current 1.0 version does not have an interface, so its only 1/2 baked really.
I'm less concerned about the JS only solution, without JS you don't even have an editor, D&D, auto saving, etc
changing to the attach_id vs post attach_count should be easy enough, and as a bonus it simplifies things since the current code worked on the post attachment as a fifo rotation queue. All of that can be dropped (you could keep it but why?) and just make the user provide the specificity of this attachment here.
Re: ILA drafts and attachments
Reply #28 –
Yeah, screw people that don't keep Javascript enabled. If it means screwing everyone else because <1% of the users don't want to enabled JS, screw that minority.