Thinking it might be close to time to push out a 1.1.9. Below is the current list of fixes/changes/enhancements since 1.1.8. If there are other issues you know about, now is the time to let us know.
Also there may be some ability to pull in a couple of 2.0 updates such as the "show more" on quotes and possibly part of Quick Quote or others. TBH I've not looked in detail at any of that, just thinking about changes should backport with some ease.
So let me know, or not, :speak_no_evil: yer choice (and to head it off, not emoji to core, although I should update the 1.1 addon at some point)
- [bugfix] Proposed fix for #3518 expose clean_4byte_chars for use such that upload filenames may contain 4byte (emoji) symbols (ref (https://github.com/elkarte/Elkarte/commit/c4f2fd350)).
- [bugfix] Point to the correct wiki help endpoints (ref (https://github.com/elkarte/Elkarte/commit/7c7e88d24)).
- [bugfix] a 2 second cache is not useful (ref (https://github.com/elkarte/Elkarte/commit/4aff64702)).
- [bugfix] potential deflection for #3520 Can't reproduce the issue, could be a mod involved. (ref (https://github.com/elkarte/Elkarte/commit/4aff64702)).
- [bugfix] Viewing a ban group would result in a blank screen error (ref (https://github.com/elkarte/Elkarte/commit/bcda0a4ef)).
- [Enhancement] Mobile view layout adjustments (ref (https://github.com/elkarte/Elkarte/commit/12be490f9)).
- [bugfix] Use the sanitized value (ref (https://github.com/elkarte/Elkarte/commit/b713bd34b)).
- [Enhancement] Allow topic approval (QM action) from message index (ref (https://github.com/elkarte/Elkarte/commit/10426bda1)).
- [bugfix] _'s in url were escaped and need to be set back for email links (ref (https://github.com/elkarte/Elkarte/commit/860ba0eaf)).
- [bugfix] signature was used by PBE but never set (unapproved topic/post) (ref (https://github.com/elkarte/Elkarte/commit/8701a3321)).
- [bugfix] unapproved topic with oldTopicDays set would result in error (ref (https://github.com/elkarte/Elkarte/commit/e2f76548f)).
- [bugfix] prevent undefined error in custom fields (ref (https://github.com/elkarte/Elkarte/commit/8b9aec7c1)).
- [bugfix] consistent keyinfo layout helps with addons (ref (https://github.com/elkarte/Elkarte/commit/d8a06631e)).
- [Enhancement] Cursor was left inside the quote (quote button) when in wizzy mode (ref (https://github.com/elkarte/Elkarte/commit/999eb1c31)).
- [Enhancement] scroll into view works better then older location hash (ref (https://github.com/elkarte/Elkarte/commit/0bd43bb27)).
- [Enhancement] fix #3409 .icon_anchors should have transform for RTL (ref (https://github.com/elkarte/Elkarte/commit/79adb87dd)).
- [bugfix] ila "share" button was being getting blocked by browser filters (ref (https://github.com/elkarte/Elkarte/commit/6534a63b0)).
- [bugfix] point to the right site for addons, not the cname (ref (https://github.com/elkarte/Elkarte/commit/1d5f11975)).
- [bugfix] the return path should not be set for sendmail, smtp does its own. Also the syntax was not compliant. (ref (https://github.com/elkarte/Elkarte/commit/448b0f550)).
- [bugfix] Annoyance, after upload the "install package" was missing, if type was set as addon, from the upload completion page. (ref (https://github.com/elkarte/Elkarte/commit/779677add)).
- [bugfix] backport from 2.0, single line code was showing vertical scroll (ref (https://github.com/elkarte/Elkarte/commit/d3cc8f6a7)).
- [bugfix] fix #3407 clean up css for RTL buttons (ref (https://github.com/elkarte/Elkarte/commit/2ffb67fe8)).
- [bugfix] PM were not updating reply to status/icon (ref (https://github.com/elkarte/Elkarte/commit/6c3178977)).
- [bugfix] toggling core features on/off could overflow db log_mentions status (ref (https://github.com/elkarte/Elkarte/commit/d7e749727)).
- [bugfix] gravatar avatar in account menu button would break with rating enabled (ref (https://github.com/elkarte/Elkarte/commit/d67fc1088)).
- [bugfix] signature chars left was not working as expected (ref (https://github.com/elkarte/Elkarte/commit/6b70b6eaa)).
- [bugfix] fix #3536 html2md was breaking plain text Links pulled in many processing enhancements from 2.0 (ref (https://github.com/elkarte/Elkarte/commit/a424ad0ce)).
- [bugfix] Increment some version numbers missed in #3566 (ref (https://github.com/elkarte/Elkarte/commit/44744c79b)).
- [Security] Make sure only return is an accepted type (ref (https://github.com/elkarte/Elkarte/commit/a748bfe58)).
- [Enhancement] Changed like_button to react_button, likes_button to reacts_button, so that AdBlockPlus doesn't remove the likes button when Social Media Blocking is enabled (ref (https://github.com/elkarte/Elkarte/commit/b7ec1f625)).
- [bugfix] email search for non moderator, in case sensitive db, errors (ref (https://github.com/elkarte/Elkarte/commit/84133eb2d)).
- [bugfix] error filters were not honoring asc/desc. 2.0 backport (ref (https://github.com/elkarte/Elkarte/commit/2c9558ecf)).
- [bugfix] Current base dir for attachments was not updating due to wrong location the parameter 2.0 backport (ref (https://github.com/elkarte/Elkarte/commit/94c7dd786)).
- [bugfix] Converted missed functions in install files (ref (https://github.com/elkarte/Elkarte/commit/02fd54caa)).
- [Enhancement] Moved functions to Util as more sensible place for them (ref (https://github.com/elkarte/Elkarte/commit/d9f86c326)).
- [bugfix] PHP 8.1 Compat version of strftime (ref (https://github.com/elkarte/Elkarte/commit/6b02d125a)).
- [bugfix] Missed pg_version needing a connection to work (ref (https://github.com/elkarte/Elkarte/commit/34e6b965d)).
- [bugfix] Big change of all strftime and gm_strftime to elk_strftime and elk_gmstrftime (ref (https://github.com/elkarte/Elkarte/commit/6f4d0a49b)).
- [bugfix] Updated Db-PostgreSQL to be PHP 8.1 compatible (ref (https://github.com/elkarte/Elkarte/commit/5eec56d27)).
Since 2.0 beta is not yet released, to allow further test on the feature updates etc and get better feedback, I think they should be backported.
I've done some more work on my local and this is what I've added thus far. Some of this was straight forward, some a bit more difficult due to changes in 2.0 vs 1.1.
- Quick Quote: backport from 2.0, this is where you select text and you can quote that when using quick reply
- Quote More: this is a quote limiting function, so if someone quotes some longish post, its limited in the display view until you click the more button at the bottom of the quote. Again a 2.0 backport
- Quote Depth: another 2.0 backport, but instead of allowing, or not, nested quotes, this allows you to limit them to a depth.
- Webp Support ... This works in a couple of ways. If you enable the option in the ACP , it will preferentially save images as webp where it can. Figuring some may be concerned about browser support ( https://caniuse.com/?search=webp -- most have for the last several years). So if you do not enable the option in the ACP but your installation supports them, and you allow webp extensions, then a transparent webp will be saved as a png and a non transparent one as a jpg. This allows users to upload webp but the site will convert them to "universal" formats.
- Webp support to avatars
- Along with the above, the save avatars as PNG and thumbs as PNG options are gone. The system will simply detect if the image has transparency and save as appropriate (Webp or if not enable then PNG or JPG)
- Backported the video embed code refactoring from 2.0 and added tiktok support
- Backported ILA code refactoring from 2.0. There were a few edge cases that could cause problems, this should clean those up. For example un approved attachments that were ILA'ed, plain attach tags not rendering, attachurl not working as it should, etc.
- Backported open graph meta data and schema.org micro data to help with SEO
- Fix several 8.1 bumps in the road
- more :bug: stomped
Great. But don't need to push to much too, so may focus on releasing 2.0 beta.
TBH I didn't expect to see all this into 1.1, leave something for the 2.0 ;)
As we pass the 1 year anniversary of 1.1.8, I think 1.1.9 is about ready. I'll post an update package FOR TESTING after this note. I've broken down the changes into various top-level categories for easy viewing. For those interested, each item has a ref link that will take you to the specific code changes.
1.1.9 Changelog
- Below are the key changes in 1.1.9, the full change listing is (here (https://github.com/elkarte/Elkarte/compare/master...patch_1-1-9)).
New Features
- [New Feature] Quick Quote. This is where you select text and you can quote that when using quick reply (ref (https://github.com/elkarte/Elkarte/commit/7a644782c)).
- [New Feature] Quote Show More. Quote display limiting function. (ref (https://github.com/elkarte/Elkarte/commit/96d05f810)).
- [New Feature] Webp support to attachments and avatars. Includes the removal of save as PNG and dynamically set this based on alpha channel (ref (https://github.com/elkarte/Elkarte/commit/f109943df)).
- [New Feature] Open graph meta data and schema.org micro data to help with SEO (ref (https://github.com/elkarte/Elkarte/commit/64ccaf6cc)) & (ref (https://github.com/elkarte/Elkarte/commit/ebdd1d3a6)).
Feature Enhancements
- [Enhancement] Quote Depth Instead of allowing, or not, nested quotes, this allows you to limit them to a depth. (ref (https://github.com/elkarte/Elkarte/commit/1e32d32ff)).
- [Enhancement] Save avatars as PNG and thumbs as PNG options have been removed. The system will simply detect if the image has transparency and save as appropriate (Webp or if not enable then PNG or JPG)
- [Enhancement] Refactoring video embed code (from 2.0), also added tiktok support (ref (https://github.com/elkarte/Elkarte/commit/26e78bad6)).
General Improvements
- [improve] Fix admin registration form layout (ref (https://github.com/elkarte/Elkarte/commit/d9daae41b)).
- [improve] 4byte efficiency improvement (ref (https://github.com/elkarte/Elkarte/commit/ca80290af)).
- [improve] Several improvements to HTML -> MD conversion function. (ref (https://github.com/elkarte/Elkarte/commit/c4614ea2c)).
- [improve] Several improvements to HTML -> BBC conversion function, used by email posting (ref (https://github.com/elkarte/Elkarte/commit/404a0c608)).
- [improve] Improvement to how unsubscribe token is created and shown (ref (https://github.com/elkarte/Elkarte/commit/73a571ca1)).
- [improve] Minor CSS fixes (ref (https://github.com/elkarte/Elkarte/commit/6b58b1207)).
- [improve] Use the alt value if its available for cid (inline image attachment) (ref (https://github.com/elkarte/Elkarte/commit/e69e9ae7f)).
- [improve] Be a little less restrictive on email table structure swapping to plain text (ref (https://github.com/elkarte/Elkarte/commit/e4a4d5224)).
- [improve] Some multipart/mixed plain sections should be joined (ref (https://github.com/elkarte/Elkarte/commit/b7a1206a3)).
- [improve] Error box in login form was a mess (ref (https://github.com/elkarte/Elkarte/commit/8cf2604ca)).
- [improve] Search result enhancements, show the first matching message in a topic, preventing a very short message from gaining to much relevance (ref (https://github.com/elkarte/Elkarte/commit/6576fcbc8)).
- [improve] Improve the search highlight logic (ref (https://github.com/elkarte/Elkarte/commit/c32bdd9ba)).
- [improve] New default Gravatar options (ref (https://github.com/elkarte/Elkarte/commit/1dc027c3d)).
- [improve] Improve the ILA button and CSS(ref (https://github.com/elkarte/Elkarte/commit/e7189276c)).
- [improve] Update markdown (ref (https://github.com/elkarte/Elkarte/commit/9a4ffa678)).
- [improve] Indicate the avatar preview with text and not just a red border (ref (https://github.com/elkarte/Elkarte/commit/3ce111ad4)).
- [improve] Allow upload avatar preview (2.0 backport) (ref (https://github.com/elkarte/Elkarte/commit/f2dcf8113)).
- [improve] Tweak smiley position in sentence to better work with font (ref (https://github.com/elkarte/Elkarte/commit/3d0d9a4e2)).
- [improve] Add 'att_reset' to BBC parser (used by ila) (ref (https://github.com/elkarte/Elkarte/commit/23f771593)).
- [improve] Allow a way for only devs to see depreciation notices (ref (https://github.com/elkarte/Elkarte/commit/88485d5b0)).
- [improve] Add topic approval to quick moderation action from message index (ref (https://github.com/elkarte/Elkarte/commit/10426bda1)).
- [improve] Cursor was left in quote when in wizzy mode (ref (https://github.com/elkarte/Elkarte/commit/999eb1c31)).
- [improve] Scroll into view works better then older location hash (ref (https://github.com/elkarte/Elkarte/commit/0bd43bb27)).
Bugs Fixed
- [bugfix] Collapsing legend in ACP was not (always) working (ref (https://github.com/elkarte/Elkarte/commit/237e9df66)).
- [bugfix] Mention pulldown (in wizzy) would collapse after positioning. Simplify / expand regex and fix time-gate (ref (https://github.com/elkarte/Elkarte/commit/e0fe51479)).
- [bugfix] Some items were not being logged (ref (https://github.com/elkarte/Elkarte/commit/116963329)).
- [bugfix] Various post by email updates to better support multipart/related and multipart/mixed formats. (ref (https://github.com/elkarte/Elkarte/commit/32d60bc52)).
- [bugfix] Profile Edits selection was still shown when core feature was off (ref (https://github.com/elkarte/Elkarte/commit/ee938671c)).
- [bugfix] PBE replies were not run through htmlspecialchars on save (ref (https://github.com/elkarte/Elkarte/commit/9a246219c)).
- [bugfix] Quick Quote needs to be wrapped in CDATA for safety, thanks Steeley for the report (ref (https://github.com/elkarte/Elkarte/commit/3ad77313c)).
- [bugfix] Account for empty center tags as happens in email due to html stripping. (ref (https://github.com/elkarte/Elkarte/commit/30d46b134)).
- [bugfix] cleanXml escape missed a few characters (ref (https://github.com/elkarte/Elkarte/commit/31e5f8114)).
- [bugfix] Strip tags can return nothing, need to catch that occurrence (ref (https://github.com/elkarte/Elkarte/commit/d65c41cff)).
- [bugfix] Email parsers could clip the closing body tag (ref (https://github.com/elkarte/Elkarte/commit/55a930ed9)).
- [bugfix] Adjust regex for --- to hr when processing email (ref (https://github.com/elkarte/Elkarte/commit/909de1088)).
- [bugfix] Reset this hidden item when ACP is updated (ref (https://github.com/elkarte/Elkarte/commit/81fe34c7c)).
- [bugfix] Check for * disposition for attachment processing (PBE) and sanitize file names (ref (https://github.com/elkarte/Elkarte/commit/947b391ad)).
- [bugfix] Leave attachments alone in multipart/mixed (ref (https://github.com/elkarte/Elkarte/commit/21bd31fb9)).
- [bugfix] More multipart/mixed processing of any sections (ref (https://github.com/elkarte/Elkarte/commit/04ee6b698)).
- [bugfix] iconv_mime_decode may fail or even partially decode, check for that (ref (https://github.com/elkarte/Elkarte/commit/c918a1c9e)).
- [bugfix] Handle multiple content-type or content-transfer-encoding they are not vaiid but do occur (ref (https://github.com/elkarte/Elkarte/commit/30f0f8cf4)).
- [bugfix] fix #1878 package server controller missing tab data (ref (https://github.com/elkarte/Elkarte/commit/551d32dc3)).
- [bugfix] Account for version level tags with v at the start like v1.1.7 (ref (https://github.com/elkarte/Elkarte/commit/8c446aa59)).
- [bugfix] Fix a host of minor issues with drag and drop attachments (ref (https://github.com/elkarte/Elkarte/commit/9789d188f)).
- [bugfix] memoryReturnBytes function could be passed improper data and fail (ref (https://github.com/elkarte/Elkarte/commit/132a6cdf4)).
- [bugfix] Fix tests to run as actions, add 8.1 support, pack up old travis tests (ref (https://github.com/elkarte/Elkarte/commit/4099a444a)).
- [bugfix] get 1.1 tests working again as action vs Travis (ref (https://github.com/elkarte/Elkarte/commit/84334050b)).
- [bugfix] I guess one could use webp as smileys (ref (https://github.com/elkarte/Elkarte/commit/a6484cc01)).
- [bugfix] Update attachment download/view gobbledygook code (ref (https://github.com/elkarte/Elkarte/commit/dfb0e6a17)).
- [bugfix] Post separator markup was messy and did not render properly in all browsers (ref (https://github.com/elkarte/Elkarte/commit/5190e3919)).
- [bugfix] Without an isset in the controller, those may not work as expected (ref (https://github.com/elkarte/Elkarte/commit/4cf4f6cbb)).
- [bugfix] The CSS quick mod checkbox style was somehow dropped in 1.1 (ref (https://github.com/elkarte/Elkarte/commit/1e6003336)).
- [bugfix] Action_no_attach exits, no need to return (ref (https://github.com/elkarte/Elkarte/commit/1ec019062)).
- [bugfix] backport a bunch of ILA edge case fixes from 2.0 (ref (https://github.com/elkarte/Elkarte/commit/2657608f8)).
- [bugfix] Return approved status to ILA so it can act accordingly (ref (https://github.com/elkarte/Elkarte/commit/ea13d398e)).
- [bugfix] attachurl was not replacing the temp with the public id (ref (https://github.com/elkarte/Elkarte/commit/c44eafcc6)).
- [bugfix] Provide a way to show pending approval for ILA images (ref (https://github.com/elkarte/Elkarte/commit/952ea5711)).
- [bugfix] Function is not used, no need to load it (ref (https://github.com/elkarte/Elkarte/commit/5f64fc438)).
- [bugfix] Specify load lazy value for avatar images (ref (https://github.com/elkarte/Elkarte/commit/a19b09f6d)).
- [bugfix] That function can return false, so best to exit from unzip (ref (https://github.com/elkarte/Elkarte/commit/c6dcdc8a1)).
- [bugfix] fix #3561 label it as posts or topics to avoid confusion (ref (https://github.com/elkarte/Elkarte/commit/50d44b7fb)).
- [bugfix] fix #3521 (ref (https://github.com/elkarte/Elkarte/commit/35bd60f65)).
- [bugfix] don't set the level before the type (ref (https://github.com/elkarte/Elkarte/commit/774bbfe35)).
- [bugfix] Proposed fix for #3518 4-byte chars in filename. Expose clean_4byte_chars for use in other places (ref (https://github.com/elkarte/Elkarte/commit/c4f2fd350)).
- [bugfix] Point to the correct wiki endpoints (ref (https://github.com/elkarte/Elkarte/commit/7c7e88d24)).
- [bugfix] a 2 second cache is not useful (ref (https://github.com/elkarte/Elkarte/commit/4aff64702)).
- [bugfix] Viewing a ban group would result in a blank screen error (ref (https://github.com/elkarte/Elkarte/commit/bcda0a4ef)).
- [bugfix] A few mobile adjustments (ref (https://github.com/elkarte/Elkarte/commit/12be490f9)).
- [bugfix] Use the sanitized value (ref (https://github.com/elkarte/Elkarte/commit/b713bd34b)).
- [bugfix] _ in url were escaped and need to be set back (ref (https://github.com/elkarte/Elkarte/commit/860ba0eaf)).
- [bugfix] Used by PBE but never set (unapproved topic/post) (ref (https://github.com/elkarte/Elkarte/commit/8701a3321)).
- [bugfix] Unapproved topic with oldTopicDays set would result in error (ref (https://github.com/elkarte/Elkarte/commit/e2f76548f)).
- [bugfix] Prevent undefined error in custom fields (ref (https://github.com/elkarte/Elkarte/commit/8b9aec7c1)).
- [bugfix] Consistent keyinfo layout helps with QQ addon (ref (https://github.com/elkarte/Elkarte/commit/d8a06631e)).
- [bugfix] fix #3409 .icon_anchors should have transform (ref (https://github.com/elkarte/Elkarte/commit/79adb87dd)).
- [bugfix] ILA "share" button was getting blocked by filters (ref (https://github.com/elkarte/Elkarte/commit/6534a63b0)).
- [bugfix] Point to the right site for addons, not the cname (ref (https://github.com/elkarte/Elkarte/commit/1d5f11975)).
- [bugfix] The return path should not be set for sendmail, smtp does its own. Also the syntax was not compliant. (ref (https://github.com/elkarte/Elkarte/commit/448b0f550)).
- [bugfix] Annoyance, after upload the install package was missing, for addons, from the upload completion page. (ref (https://github.com/elkarte/Elkarte/commit/779677add)).
- [bugfix] Single line code BBC was showing vertical scroll (ref (https://github.com/elkarte/Elkarte/commit/d3cc8f6a7)).
- [bugfix] fix #3407 clean up CSS for RTL buttons (ref (https://github.com/elkarte/Elkarte/commit/2ffb67fe8)).
- [bugfix] PM's were not updating reply status (ref (https://github.com/elkarte/Elkarte/commit/6c3178977)).
- [bugfix] Toggling core features on/off could overflow log_mentions status (ref (https://github.com/elkarte/Elkarte/commit/d7e749727)).
- [bugfix] Gravatar avatar in account button would break with rating enabled (ref (https://github.com/elkarte/Elkarte/commit/d67fc1088)).
- [bugfix] Signature chars remaining was not working as expected (ref (https://github.com/elkarte/Elkarte/commit/6b70b6eaa)).
- [bugfix] fix #3536 html2md was breaking plain text Links plus more (ref (https://github.com/elkarte/Elkarte/commit/a424ad0ce)).
- [bugfix] Make sure only return is an accepted type (ref (https://github.com/elkarte/Elkarte/commit/a748bfe58)).
- [bugfix] Changed like_button to react_button, likes_button to reacts_button, so that AdBlockPlus doesn't remove the likes button when Social Media Blocking is enabled (ref (https://github.com/elkarte/Elkarte/commit/b7ec1f625)).
- [bugfix] Email search for non moderator, in case sensitive DB, errors (ref (https://github.com/elkarte/Elkarte/commit/84133eb2d)).
- [bugfix] Error filters were not honoring asc/desc flag. (ref (https://github.com/elkarte/Elkarte/commit/2c9558ecf)).
- [bugfix] That is a post value, not get (ref (https://github.com/elkarte/Elkarte/commit/94c7dd786)).
- [bugfix] Converted missed functions in install files (ref (https://github.com/elkarte/Elkarte/commit/02fd54caa)).
- [bugfix] Moved functions to Util as more sensible place for them, imo (ref (https://github.com/elkarte/Elkarte/commit/d9f86c326)).
- [bugfix] Missed pg_version needing a connection to work (ref (https://github.com/elkarte/Elkarte/commit/34e6b965d)).
- [bugfix] Big change of all strftime and gm_strftime to elk_strftime and elk_gmstrftime (ref (https://github.com/elkarte/Elkarte/commit/6f4d0a49b)).
PHP 8.1 updates
- [8.1] Captcha was not working with PHP 8.1 Updated the ttf fonts to add ones with minor grunge built (ref (https://github.com/elkarte/Elkarte/commit/12e4d720e)).
- [8.1] Prevent calling of functions that may be disabled by the host (ref (https://github.com/elkarte/Elkarte/commit/1156da85d)).
- [8.1] Can't use null in PHP 8.1 (ref (https://github.com/elkarte/Elkarte/commit/eb305251e)).
- [8.1] That may be null, and 8.1 will abend (ref (https://github.com/elkarte/Elkarte/commit/eb4ff8396)).
- [8.1] Do not send a float value to chr() (ref (https://github.com/elkarte/Elkarte/commit/bfa8a3b65)).
- [8.1] 8.1 error due to curl option never existing (ref (https://github.com/elkarte/Elkarte/commit/7fa73272f)).
- [8.1] seems recent GD (8.1) does no like the float where an int is needed. (ref (https://github.com/elkarte/Elkarte/commit/b01c8e0a5)).
- [8.1] Depreciation notice in 8.1 (ref (https://github.com/elkarte/Elkarte/commit/235401c4d)).
- [8.1] More 8.1 tweaks (ref (https://github.com/elkarte/Elkarte/commit/c22756db0)).
- [8.1] PHP 8.1 will not like adding strings (ref (https://github.com/elkarte/Elkarte/commit/cd9879ff9)).
- [8.1] un used paramerter, will throw depreciation in 8.1 (ref (https://github.com/elkarte/Elkarte/commit/30783d166)).
- [8.1] fix some 8.1 install errors (ref (https://github.com/elkarte/Elkarte/commit/4265cdb22)).
- [8.1] 8.1 does not like nulls in these functions (ref (https://github.com/elkarte/Elkarte/commit/91dc3fac9)).
- [8.1] some 8.1 fixes for type hint on interfaces (ref (https://github.com/elkarte/Elkarte/commit/a7f5dadfb)).
- [8.1] PHP 8.1 Compat version of strftime (ref (https://github.com/elkarte/Elkarte/commit/6b02d125a)).
- [8.1] Updated Db-PostgreSQL to be PHP 8.1 compatible (ref (https://github.com/elkarte/Elkarte/commit/5eec56d27)).
Here is the PRELIMINAY patch package for upgrading 1.1.8 to 1.1.9.
As always if you do this, please do so on a backup or have a backup!!!
Note, this should run fine on 8.1, however 1.1.8 does not. So you can upgrade then change to 8.1, but if you un-install then set your PHP version back to 8.0 or 7.4 or whatever you were running prior to 1.1.9 If you do not do this a great frown may appear on your face.
I'd appreciate the testing of this, not only the patch itself but of the new features/enchantments in 1.1.9, now is the time to find any bugs and report them so they can be fixed prior to release. (see the previous post for the list)
ETA; Removed prelim 1.1.9 patch attachment
No time to test, still in the middle of moving, sorry. Good luck though! :)
Installed without issue on a 1.1.8 forum. Everything seems to still work as it should.
Thank You.
I did notice one thing on an old test site. If you are using SimplePortal < 1.0.1 (and since I did not formally release that, you probably are) then you MUST edit your
Portal.subs.php file and change the following.
'query' => empty($allowed) ? '0=1' : 'FIND_IN_SET(%s, \'' . implode(',', $allowed) . '\')',
'query' => empty($allowed) ? '0=1' : 'FIND_IN_SET(%s, "' . implode(',', $allowed) . '")',
If you don't then you will get a hacking attempt error from the db controller, and probably a 500 error on your site.
That’s most likely caused by this change https://github.com/elkarte/Elkarte/commit/a748bfe58
Which brings it inline with Elkarte 2 behaviour.
Awesome!! The beta patch is installed on two sites.
Here's a bugz report (maybe). Attached image preview does not display on either site. Both use Attached Image Resize addon. This occurs using php 7.4 and 8.1. The attached images display properly once posted.
1.1.9 installed and runs under php 8.1. :thumbsup:
@Spuds Is it possible to use the variant "Darktanion" (dev) under 1.1.9?
.
That is the one ! (and its correct to do) .... really the SP code was incorrect
OK I'll take a look at that and try and determine why that is happening. (Starting In 2.0, the attachment image resize is part of the core, no more addon)
It will need adjustments for 1.1.9, but It should, probably, mostly, work. You will see wrong borders or element padding issues in a few places, maybe a few other issues as well.
To try you would need to edit the default theme
index.template.php file and change the theme_variants line to read
'theme_variants' => array('light', 'besocial', 'dark'), You would then need to add the
_dark css directory from 2.0 and under the 1.1.9 themes/default/css directory (where _light and _besocial are) Then choose it in your profile.
Hacking attempt? I will check later and update.
If you have simple portal installed .... See https://www.elkarte.net/community/index.php?topic=6141.msg44129#msg44129
I have a SP 1.0.1 just about ready to release to fix that and some other issues reported over the months since 1.0.0
Back to this .... While looking at this I found a couple of items that needed to be addressed.
First the addon needed to be updated to fully support 1.1.9, specifically support for webp (if you enable that) and better integration with the attachment drop area on the post screen.
While looking at all of that, I noticed
- That the transparency detection code could be improved a bit,
- There was an issue in the post attachment area, specifically when you have the resize addon, and it did the resize, the space left line was not updated to reflect the smaller file ... so if you uploaded a 2M file that was reduced to 250k, you were still docked the 2M
- When using imagick, you may get an empty thumbnail when uploading an animated gif, and you may loose the animation of said gif
All that said, I'm not sure this addresses the problem you reported, but its steps in the right direction.
Here are the files, only use if on 1.1.9 ... replace the two core files and install the new version of the resize addon
Many thanks for your work spuds!! Unfortunately the preview still does not show?
Time for some more info gathering so I can fix this !
Just to be sure, you are referring to the little thumbnail that appears (or should) in the status bar attachment zone.
Are you using GD or Imagick (just so I use the right one)
Are you using a custom theme? If so I need to check if there are any edits missing from the package.
Any errors in the browser console?
Correct, the thumbnail by the status bar. The preview also fails in the editor if inlined in WYSIWYG mode.
Both are available. Imagick is prioritized isn't it?
The themes on both sites are default with custom css.
Seems there could be a jquery issue at hand? There
are errors in the console log:
Yup ... it will choose Imagick over GD as the results are better.
That should not be a problem at all then.
That one is odd .. At first I thought it could be due to a bad json response from the server (in response to sa=tmpattach ... but its from jquery-UI which I don't think is normally loaded for the post page? Could you provide me you list of addons so I can do some more digging?
Also, setting aside that it appears its jquery-UI throwing the error, could you look at your network tab and see what response you are getting for tmpattach request? just wondering if there is something in that response, like a server cors error or php error in the response itself? Or maybe you enabled webp, in which case the thumbnail would be a webp image and that is causing an issue. Feel free to pm me a site and temp userid so I can see the dev console myself.
Here's an addon list:
Attachment Image Resize 1.0.7
Bookmarks 2.5
ElkArte 1.1.2 patch 1.0
ElkArte 1.1.3 patch 1.1.3
ElkArte 1.1.4 patch 1.1.4
ElkArte 1.1.6 patch 1.0
ElkArte 1.1.7 patch 1.0
ElkArte 1.1.7 patch 1.0
ElkArte 1.1.8 patch 1.0
ElkArte 1.1.9 patch 1.0
Google Member Map 1.0.6
Image Watermark 1.0
Lazy loading of images 0.0.2
SimpleAds 1.0.3
webp is enabled, though if memory serves it occurs when webp is disabled as well. A verfication test and update are in order.....
The network console does indicate a 502 error:
allow: GET, HEAD, POST
content-length: 552
content-type: text/html
date: Wed, 19 Oct 2022 00:22:50 GMT
server: nginx
:authority: bbs.zuwharrie.com
:method: GET
:path: /content?action=dlattach;sa=tmpattach;attach=post_tmp_777_b023f1c22944525f7e9f3b8e58e92446;topic=139287
:scheme: https
accept: image/avif,image/webp,image/apng,image/svg+xml,image/*,*/*;q=0.8
accept-encoding: gzip, deflate, br
accept-language: en-US,en;q=0.9
cache-control: no-cache
cookie: Zuwharrie738=%5B777%2C%2205c27336b121b64491c00d800b07b24582c4f8143ec34ec29826ce6f14bb4964%22%2C1850919101%2C2%5D; PHPSESSID=9mat7d7qdmgvb6ffkc6156pr6v23g6j5qjmgbgl5clemnmhq3l6crk9vdjhmcitm
pragma: no-cache
referer: https://xxx.xxxxxxxx.com/content?action=post;topic=139287.0;last_msg=1369644
sec-ch-ua: "Google Chrome";v="107", "Chromium";v="107", "Not=A?Brand";v="24"
sec-ch-ua-mobile: ?0
sec-ch-ua-platform: "Windows"
sec-fetch-dest: image
sec-fetch-mode: no-cors
sec-fetch-site: same-origin
user-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/107.0.0.0 Safari/537.36
OK, the previous statement is verified. The preview fails when webp support is disabled. Interestingly, the headers still indicated webp acceptance? webp is not in the allowed attachment extension field, either.
allow: GET, HEAD, POST
content-length: 552
content-type: text/html
date: Wed, 19 Oct 2022 00:31:57 GMT
server: nginx
:authority: bbs.zuwharrie.com
:method: GET
:path: /content?action=dlattach;sa=tmpattach;attach=post_tmp_777_017c4b85254e043a529f433d0de7f44c;topic=139287
:scheme: https
accept: image/avif,image/webp,image/apng,image/svg+xml,image/*,*/*;q=0.8
accept-encoding: gzip, deflate, br
accept-language: en-US,en;q=0.9
cache-control: no-cache
cookie: Zuwharrie738=%5B777%2C%2205c27336b121b64491c00d800b07b24582c4f8143ec34ec29826ce6f14bb4964%22%2C1850919101%2C2%5D; PHPSESSID=9mat7d7qdmgvb6ffkc6156pr6v23g6j5qjmgbgl5clemnmhq3l6crk9vdjhmcitm
pragma: no-cache
referer: https://xxx.xxxxxxx.com/content?action=post;topic=139287.0;last_msg=1369644
sec-ch-ua: "Google Chrome";v="107", "Chromium";v="107", "Not=A?Brand";v="24"
sec-ch-ua-mobile: ?0
sec-ch-ua-platform: "Windows"
sec-fetch-dest: image
sec-fetch-mode: no-cors
sec-fetch-site: same-origin
user-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/107.0.0.0 Safari/537.36
the webp in the headers is just the browser announcing what it supports. Its similar to the accept-encoding header which lets the server know what compression methods it can handle gzip etc. One could use the webp header to check if sending back a webp image was OK and if not quick transform the image to png or jpg. I went the lazy route and let the admin choose support, figuring most browsers in the last 4 years support webp, and caniuse claims 97% support at this point.
OK back on task (I did the quick edit on your posts to remove the website just in case) ... I think the issue is with the watermark addon, it at least has some problems with 1.1.9, so hoping an update there will clear this up. I'll post an updated package for that later today.
OK, uninstall your old watermark addon, and then install this beauty!
Not sure if this will fix the issue you are having, but at least this version does run on 1.1.9 where as the previous did not .... so its progress!
And just for completeness, and since I had to look, and since
@emanuele45 is lazy ... here is an update to LazyLoading
The updates are pretty minor, but in 1.1.9 avatars and attachments have the
loading="lazy" attribute on them, so the browser takes care of the lazy loading (enabled browsers that is ~ 90% are) so the change prevents the addon from changing those. The browser is much "smarter" about what it loads, its not just waiting for it to enter the viewport (as this addon does) which provides a better user experience.
Also this does not require the emulation to install and updated the script to the latest (although the changelog shows no real change but anyway ..)
Many thanks! That said, the issue remains. The site is running on php7.4 rather than 8.1, if that matters here.
Sent you a PM on my lack of progress :laughing:
As an experiment, please try the attached Attachment.controller.php (just replace the one in your sources/controller directory) and lets see if that does anything good for us. Past that we really need to hope there is something in your Nginx error logs regarding the 502 that we are generating.
Rockin, still a no go. Sure hope this doesn't send you on a wild goose chase then turn out a configuration issue on this end. :(
Here's an excerpt from the nginx error log after an upload:
2022/10/21 00:23:10 [error] 2571542#2571542: *26 upstream sent invalid "Content-Length" header: "Content-Length: " while reading response header from upstream, client: IP addy, server: bbs.site.com, request: "GET /content?action=dlattach;topic=139214.0;attach=254415;image HTTP/2.0", upstream: "fastcgi://unix:/run/php-fpm/site.sock:", host: "bbs.site.com", referrer: "https://bbs.site.com/content?topic=139214.msg1369697"
2022/10/21 00:23:10 [error] 2571542#2571542: *26 upstream sent invalid "Content-Length" header: "Content-Length: " while reading response header from upstream, client: IP addy, server: bbs.site.com, request: "GET /content?action=dlattach;topic=139214.0;attach=254417;image HTTP/2.0", upstream: "fastcgi://unix:/run/php-fpm/site.sock:", host: "bbs.site.com", referrer: "https://bbs.site.com/content?topic=139214.msg1369697"
2022/10/21 00:23:10 [error] 2571542#2571542: *26 upstream sent invalid "Content-Length" header: "Content-Length: " while reading response header from upstream, client: IP addy, server: bbs.site.com, request: "GET /content?action=dlattach;topic=139214.0;attach=254419;image HTTP/2.0", upstream: "fastcgi://unix:/run/php-fpm/site.sock:", host: "bbs.site.com", referrer: "https://bbs.site.com/content?topic=139214.msg1369697"
2022/10/21 00:23:10 [error] 2571542#2571542: *26 upstream sent invalid "Content-Length" header: "Content-Length: " while reading response header from upstream, client: IP addy, server: bbs.site.com, request: "GET /content?action=dlattach;topic=139214.0;attach=254421;image HTTP/2.0", upstream: "fastcgi://unix:/run/php-fpm/site.sock:", host: "bbs.site.com", referrer: "https://bbs.site.com/content?topic=139214.msg1369697"
2022/10/21 00:23:10 [error] 2571542#2571542: *26 upstream sent invalid "Content-Length" header: "Content-Length: " while reading response header from upstream, client: IP addy, server: bbs.site.com, request: "GET /content?action=dlattach;topic=139214.0;attach=254423;image HTTP/2.0", upstream: "fastcgi://unix:/run/php-fpm/site.sock:", host: "bbs.site.com", referrer: "https://bbs.site.com/content?topic=139214.msg1369697"
2022/10/21 00:23:10 [error] 2571542#2571542: *26 upstream sent invalid "Content-Length" header: "Content-Length: " while reading response header from upstream, client: IP addy, server: bbs.site.com, request: "GET /content?action=dlattach;topic=139214.0;attach=254425;image HTTP/2.0", upstream: "fastcgi://unix:/run/php-fpm/site.sock:", host: "bbs.site.com", referrer: "https://bbs.site.com/content?topic=139214.msg1369697"
2022/10/21 00:23:10 [error] 2571542#2571542: *26 upstream sent invalid "Content-Length" header: "Content-Length: " while reading response header from upstream, client: IP addy, server: bbs.site.com, request: "GET /content?action=dlattach;topic=139214.0;attach=254427;image HTTP/2.0", upstream: "fastcgi://unix:/run/php-fpm/site.sock:", host: "bbs.site.com", referrer: "https://bbs.site.com/content?topic=139214.msg1369697"
2022/10/21 00:23:10 [error] 2571542#2571542: *26 upstream sent invalid "Content-Length" header: "Content-Length: " while reading response header from upstream, client: IP addy, server: bbs.site.com, request: "GET /content?action=dlattach;topic=139214.0;attach=254429;image HTTP/2.0", upstream: "fastcgi://unix:/run/php-fpm/site.sock:", host: "bbs.site.com", referrer: "https://bbs.site.com/content?topic=139214.msg1369697"
2022/10/21 00:23:10 [error] 2571542#2571542: *26 upstream sent invalid "Content-Length" header: "Content-Length: " while reading response header from upstream, client: IP addy, server: bbs.site.com, request: "GET /content?action=dlattach;topic=139214.0;attach=254431;image HTTP/2.0", upstream: "fastcgi://unix:/run/php-fpm/site.sock:", host: "bbs.site.com", referrer: "https://bbs.site.com/content?topic=139214.msg1369697"
2022/10/21 00:23:10 [error] 2571542#2571542: *26 upstream sent invalid "Content-Length" header: "Content-Length: " while reading response header from upstream, client: IP addy, server: bbs.site.com, request: "GET /content?action=dlattach;topic=139214.0;attach=254433;image HTTP/2.0", upstream: "fastcgi://unix:/run/php-fpm/site.sock:", host: "bbs.site.com", referrer: "https://bbs.site.com/content?topic=139214.msg1369697"
2022/10/21 00:23:10 [error] 2571542#2571542: *26 upstream sent invalid "Content-Length" header: "Content-Length: " while reading response header from upstream, client: IP addy, server: bbs.site.com, request: "GET /content?action=dlattach;topic=139214.0;attach=254435;image HTTP/2.0", upstream: "fastcgi://unix:/run/php-fpm/site.sock:", host: "bbs.site.com", referrer: "https://bbs.site.com/content?topic=139214.msg1369697"
2022/10/21 00:23:25 [error] 2571542#2571542: *26 upstream sent invalid "Content-Length" header: "Content-Length: " while reading response header from upstream, client: IP addy, server: bbs.site.com, request: "GET /content?action=dlattach;sa=tmpattach;attach=post_tmp_777_6e976dbbe41ba5426878a1e07a75209b;topic=139214 HTTP/2.0", upstream: "fastcgi://unix:/run/php-fpm/site.sock:", host: "bbs.site.com", referrer: "https://bbs.site.com/content?action=post;topic=139214.0;last_msg=1369694"
And access log from the same timeframe:
IP addy - - [21/Oct/2022:00:23:10 +0000] "GET /content?action=dlattach;topic=139214.0;attach=254415;image HTTP/2.0" 502 552 "https://bbs.site.com/content?topic=139214.msg1369697" "Mozilla/5.0 (Linux; Android 12; SM-G998U) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/106.0.0.0 Mobile Safari/537.36"
IP addy - - [21/Oct/2022:00:23:10 +0000] "GET /content?action=dlattach;topic=139214.0;attach=254417;image HTTP/2.0" 502 552 "https://bbs.site.com/content?topic=139214.msg1369697" "Mozilla/5.0 (Linux; Android 12; SM-G998U) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/106.0.0.0 Mobile Safari/537.36"
IP addy - - [21/Oct/2022:00:23:10 +0000] "GET /content?action=dlattach;topic=139214.0;attach=254419;image HTTP/2.0" 502 552 "https://bbs.site.com/content?topic=139214.msg1369697" "Mozilla/5.0 (Linux; Android 12; SM-G998U) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/106.0.0.0 Mobile Safari/537.36"
IP addy - - [21/Oct/2022:00:23:10 +0000] "GET /content?action=dlattach;topic=139214.0;attach=254421;image HTTP/2.0" 502 552 "https://bbs.site.com/content?topic=139214.msg1369697" "Mozilla/5.0 (Linux; Android 12; SM-G998U) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/106.0.0.0 Mobile Safari/537.36"
IP addy - - [21/Oct/2022:00:23:10 +0000] "GET /content?action=dlattach;topic=139214.0;attach=254423;image HTTP/2.0" 502 552 "https://bbs.site.com/content?topic=139214.msg1369697" "Mozilla/5.0 (Linux; Android 12; SM-G998U) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/106.0.0.0 Mobile Safari/537.36"
IP addy - - [21/Oct/2022:00:23:10 +0000] "GET /content?action=dlattach;topic=139214.0;attach=254425;image HTTP/2.0" 502 552 "https://bbs.site.com/content?topic=139214.msg1369697" "Mozilla/5.0 (Linux; Android 12; SM-G998U) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/106.0.0.0 Mobile Safari/537.36"
IP addy - - [21/Oct/2022:00:23:10 +0000] "GET /content?action=dlattach;topic=139214.0;attach=254427;image HTTP/2.0" 502 552 "https://bbs.site.com/content?topic=139214.msg1369697" "Mozilla/5.0 (Linux; Android 12; SM-G998U) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/106.0.0.0 Mobile Safari/537.36"
IP addy - - [21/Oct/2022:00:23:10 +0000] "GET /content?action=dlattach;topic=139214.0;attach=254429;image HTTP/2.0" 502 552 "https://bbs.site.com/content?topic=139214.msg1369697" "Mozilla/5.0 (Linux; Android 12; SM-G998U) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/106.0.0.0 Mobile Safari/537.36"
IP addy - - [21/Oct/2022:00:23:10 +0000] "GET /content?action=dlattach;topic=139214.0;attach=254431;image HTTP/2.0" 502 552 "https://bbs.site.com/content?topic=139214.msg1369697" "Mozilla/5.0 (Linux; Android 12; SM-G998U) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/106.0.0.0 Mobile Safari/537.36"
IP addy - - [21/Oct/2022:00:23:10 +0000] "GET /content?action=dlattach;topic=139214.0;attach=254433;image HTTP/2.0" 502 552 "https://bbs.site.com/content?topic=139214.msg1369697" "Mozilla/5.0 (Linux; Android 12; SM-G998U) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/106.0.0.0 Mobile Safari/537.36"
IP addy - - [21/Oct/2022:00:23:10 +0000] "GET /content?action=dlattach;topic=139214.0;attach=254435;image HTTP/2.0" 502 552 "https://bbs.site.com/content?topic=139214.msg1369697" "Mozilla/5.0 (Linux; Android 12; SM-G998U) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/106.0.0.0 Mobile Safari/537.36"
Well that is something to go on, and its in the area I tried to adjust in the previous attempt... Please give this one a try, it simply turns off the content length header as a test, just to see if that is indeed what is causing the error.
You're on the right track! Attachments upload, and the preview shows!!
:cool: thanks for doing all the testing. I'll do some more looking at this tomorrow now that I know where/what the problem is!
Well this should be the winner winner, :chicken: chicken dinner !
The culprit (I believe) was a misplaced comma (of all things) which caused the sending of a bad content length header. I don't really have an explanation for why it manifested as a 502 on some sites, and others seemed to ignore the bad header. Don't know if that was a specific PHP level, or Web Server config, or ??
Attached is the updated Attachments.controller.php file for 1.1.9 only. Give this a try and lets see what we get :pray:
Also, I noticed that the lazy loading addon was preventing the showing of the admin menu icons, so I've attached an update for that as well. I'll post that package in the correct thread a bit later on.
Odd what chaos a few misplaced characters can cause. Years ago several random characters on a document made life miserable for me. Turns out the random characters just happened to spell my name, and the document was a marriage certificate. Who knew!?
Seriously, I'll give it the test sometime this evening!
Edit: the latest version appears to be operating properly!
Gotta say, this made me laugh all day :rofl:
Glad the fix worked, now I can repack 1.1.9
Another potential bugz are spotted. Quoted messages containing apostrophes and quote marks yields decimal code or html code, respectively. There could be others, these are the ones noted so far.
Thanks, I'll take a look at that. Keep those reports coming !
I was pretty sure I knew what was causing this, and now having looked at it, confirmed.
Long story, but we made a change in the quick quote function to account for unescaped special characters like
& that made it into the DB due to an error in the post by email function. The fix for that was to allow unescaped characters in the XML response, but that also means escaped characters are not unescaped by magic.
So lets try to fix the issue another way .... in post.controller.php find
$context['quote']['xml'] = strtr($context['quote']['xml'], array(' ' => ' ', '<' => '<', '>' => '>'));
$context['quote']['xml'] = strtr(Util::htmlspecialchars($context['quote']['xml']), array(' ' => ' '));
Then in Xml.template.php lets revert the proposed change
<quote><![CDA' . 'TA[', cleanXml($context['quote']['xml']), ']' . ']></quote>
<quote>', cleanXml($context['quote']['xml']), '</quote>
That
should fix the original issue but not cause this new issue.
@Spuds - at first I thought that was reverting the fix we made in 1.1.6, for a similar problem in Xml.template.php function template_quotefast()
https://www.elkarte.net/community/index.php?topic=6157.0
..but after a closer look, no... but it does raise the question of whether it should?
That actually is the same one. The bug that you reported has been around for "a bit", so we have to deal with the fact that some posts will have this issue.
The original fix was the CDATA idea which allows us to send unescaped character data, but then we should un-escape anything escaped. Note that the line in question may look like what you posted <quote><![CDATA[ or if done by the patch system, it will be <quote><![CDA' . 'TA[ the later due to the fact the patch system is XML so you can't have a CDATA string in it as it would not be a valid file, so it gets broken and concatenated.
So you should try to undo the edit you made and then add the new edit to the post.controller, which escapes the problematic characters if they are not already escaped (e.g. it will not cause & => &amp;)
Alrighty then, I'll make the change and then update the 1.1.6 fix topic after testing (oddly, none of my users pointed it out if they had encountered the problem - and I haven't noticed it - but they're a lazy bunch and somewhat adverse to using symbols and punctuation other than periods, commas and the occasional exclamation point - if they even use those - anyway..)
That is how bugs often go, and why some remain for so long! ... Have to get the right conditions, maybe notice there is a problem, maybe report it, maybe someone will make a fix, maybe it will be the right fix LOL
Well, I made the change, and yea, that works too.. 😝
....so I posted an update in the 1.1.6
thread (https://www.elkarte.net/community/index.php?topic=6157.msg44212#msg44212) 🦝
Attached is the "final" version of 1.1.9, assuming there are no other issues reported.
Changes from the previous candidate (that I recall)
- fixes the attachment/ preview error reported by
@badmonkey - fixes the fix for the quote function reported by
@Steeley - adds some additional password conversion functions for recent releases form other forums (found during the open importer updates)
- fix an issue where if there was not privacy policy file, and you used the checkbox registration, and empty accept for would show.
- fix an issue where ILA was outputting control characters (read tab and newline) that caused problems with addons (read print to pdf)
- prevent potential 502 gateway failed error when downloading a file (regression error)
+ improve imagick process for thumbnails when transparency is detected
+The reduced upload file size was not reflected back in the UI, for addon use (2.0 backport)
+The resize flag was not set correctly for UI use (part of previous issue)
ETA: Package Removed
And my legacy lives on.. :partying_face
As always, great work
@Spuds !
Thanks for all you do!
Thanks
@Spuds !
The official release of 1.1.9 is coming closer. :thumbsup:
I tried this on my forum, it installs without errors, but after that I get an error:
Zend OPcache API is restricted by "restrict_api" configuration directiveI click on "Back" button and I get this error:
Undefined class constant 'ATTR_RESET'After this my forum is not visible, I only see a white page with this error:
Fatal error: Uncaught Error: Undefined class constant 'ATTR_RESET' in /public/sources/subs/Ila.integrate.php:104 Stack trace: #0 /public/sources/Hooks.class.php(110): Ila_Integrate::integrate_additional_bbc(Array) #1 /public/sources/Subs.php(1411): Hooks->hook('integrate_addit...', Array) #2 /public/sources/subs/BBC/ParserWrapper.php(388): call_integration_hook('integrate_addit...', Array) #3 /public/sources/subs/BBC/ParserWrapper.php(419): BBC\ParserWrapper->getCodes() #4 [internal function]: BBC\ParserWrapper->getAutolinkParser('message') #5 /public/sources/subs/BBC/ParserWrapper.php(130): call_user_func(Array, 'message') #6 /public/sources/subs/BBC/ParserWrapper.php(183): BBC\ParserWrapper->getParsersByArea('message') #7 /srv/users/serve in /public/sources/subs/Ila.integrate.php on line 104
I guess I need to disable ILA add-on and maybe the other add-ons that were updated recently, then retry to update Elkarte and the add-ons.
I use PHP 7.4, but after this update I will switch to 8.1.
That is a little strange.
The ATTR_RESET is due to the updates in ILA ... it installs a new ila.integration.php file which requires a refresh of the hooks (which the install / uninstall package does take care of). I've only seen that error during uninstall and it only lingered for a single page load (I did fix that as well).
Since you are getting that error, it means it did install that new file but something to do with the opcache caused some other failure after that. You can probably fix the issue by using the 1.1.8 version of ila.integration.php (the old file is included in the1.1.9 package under the 1.1.8 directory). Then we need to understand why the opcache blocked.
In the FWIW, in the updates that I've done, I've first updated all of the addons, then applied the 1.1.9 update (all on 7.4)
When you stop pulling your hair out, what do you have in your php.ini file for the opcache.restrict_api setting? There are checks in the code to prevent this error (since, 1.1.4) so I'm curious as to why its showing up (again). The error was caused by the system attempting to flush the opcache after the patch since at that point its no longer valid (but it checks if its allowed).
ETA: I added additional protection to the opcache_reset() call in the patch file (updated the attachment above), not sure if that was the cause but may help.
Updating first the Resize Images add-on and then update to 1.1.9 seems to work, I used the patched file you posted.
There are other problems with Simple Portal, but I guess I should have update the SP add-on before updating Elkarte. SP Error
Fatal error: Uncaught Elk_Exception: Hacking attempt... in /public/sources/database/Db-abstract.class.php:404 Stack trace: #0 /public/sources/database/Db-mysql.class.php(163): Database_Abstract->error_backtrace('Hacking attempt...', 'Illegal charact...', true, '/srv/users/serv...', 534) #1 /public/sources/subs/Portal.subs.php(534): Database_MySQL->query('', '\n\t\tSELECT\n\t\t\tsp...', Array) #2 /public/sources/subs/Portal.subs.php(357): getBlockInfo(NULL, NULL, true, true, true) #3 /public/sources/subs/Portal.subs.php(192): sportal_load_blocks() #4 /public/sources/admin/ManageSPortalModule.controller.php(724): sportal_init() #5 /public/sources/Hooks.class.php(110): ManageSPortalModule_Controller::sp_integrate_init_theme(0, Array) #6 /srv/u in /public/sources/database/Db-abstract.class.php on line 404
opcache.restrict_api=/restricted
I went back to 1.1.8 (large update) then installed the update to 1.1.9. It worked without problems.
p.s. Where can I find the setting to enable the quick quote option? I searched for "quick" or "quote" in ACP settings without results.
Cool ... The original file had the same refresh code as used in 1.1.4, but I added another check and supression.
https://www.elkarte.net/community/index.php?topic=6141.msg44129#msg44129
https://www.elkarte.net/community/index.php?topic=6141.msg44129#msg44129 I did put together a 1.0.1 package and posted it on the github site to help. I've used this on a few sites and all seems to be OK with it, but if you see errors, let me know.
Humm .... typically that is empty or set to BOARDDIR like
/var/www/mysite Anyway with that setting it would run the opcache_reset() function as the function felt it was safe to do so (e.g. BOARDDIR is not restricted) .. Anyway good to know that the tweak helped.
It should just be ON ... I did not add a setting for that, its just tied to quick reply function. I bet its showing up off screen (scroll down and see if you see it) ... I don't recall any template changes being required, but it may have needed a CSS update. If you are running a custom theme that may not have happened. I'll look into that and post what is needed.
Updated SP, no errors or problems so far. Only error I see in Elk log:
Type of error: Critical
Guest
Illegal character (') used in query...
Function: bb2_db_query
/index.php?action=login2;quicklogin
File: /sources/ext/bad-behavior/badbehavior-plugin.php
Line 108
$result = $db->query('', $query, array());
As for the quick quote I am using the default theme, BeSocial variant. I tried with Light version but same result. Could be due to the fact that I had the Quick Quote add-on which I uninstalled?
It probably means I forgot to update the beSocial.css LOL ... I'll take a look in the AM
I checked this on my two test sites, basic 1.1.9 with beSocial and the quote selected showed up as expected. Is this a test site I can see? If so shoot me the address so I can :eye_in_speech_bubble:
I'll send you a PM
after installing the patch, the attachments section began to look like this
(Link-10156) and it was like this
(Link-10158) is it really necessary to roll back
It installs an updated dropAttachments.js file in themes/default/scripts ... check if the new file is there (its header will have 1.1.9)
IF you created a custom theme and copied that file to your custom theme dir, you will need to replace it with the update file (or simply remove it as the system will simply grab it from the default directory)
Be sure to flush your browser cache, even though it has a ?119 to force a refresh
version 1.1.9, resetting the cache didn't help
From a quick look, you have this in your template quickQuote.txt = 'Quick Quote'; on the posting page. That is not valid so the rest of the javascirpt on that page does not run (including the drag/drop attachment area)
The above is not part of 1.1.9, so it should be removed.
Yes, it helped, but it's a pity to part with that useful mod
Another note, the site on version 1.1.9 has become longer to load
Its still part of 1.1.9, but that looked to be a remnant from an early test version of 1.1.9 and its just that line was no longer needed.
That could be the "combine css/js" hives being re-build due to the changes. When those are first created it can slow the page load, should only be a temporary issue. You can disable that function while you are working on your site, and when you are done setting everything up, then enable it.
The other possible slow down is often hostname lookups which are slow on some servers. You can disable that in you elkarte admin panel under servers.
Should 1.1.9 be released by now or there are something more needed to be fixed and/or added?
I've got it installed on my "robot friendly" site for abuse testing and several other sites. I did notice a small issue with bad behavior (results in error log spam) that I'll fix in the final patch.
I am also going to add a step to patch SP during the install since if you don't update SP before the patch you could end up with a defunct site. Its not normal to patch an addon, but in this case I think its prudent.
Going to final this weekend is my goal. I also want this to be done so I can get back to 2.0 !!
I do not have SP installed and reverting back to 1.1.8 seems to work. When I re-patched with 1.1.9 it happened again. I will test again later.
I restored 1.1.8 version from the zip file again making sure all files are the original 1.1.8 and no hooks. Install the 1.1.9 patch. And the hacking attempt comes again. Error log reported this:
(Link-10181)
Ah thanks for those details.
I had seen bad behavior log errors on a test site, but not during the patch phase.
I've attached the fixed plugin which should resolve that error. Just replace the one in ...sources\ext\bad-behavior
Thanks, this did the trick.
Once again, I think 1.1.9 is about ready
tm I'll post the latest patch package FOR TESTING after this note.
This update should address all of the items brought up in this thread, plus some reported on github, some pm reported, and some just found. The only open issue that is not addressed (that I am aware) is one
@radu81 reported where the WEBP ILA in preview mode appears to be full resolution, seems like RL has consumed him for now so work on that will have to wait :wink:
Note its important to get 1.1.9 finalized as the 1.1.8 install package does not work on PHP 8.1 and PHP 7.4 is essentially EOL at this point (in terms of support and security patches). I may update the 1.1.8 install package.
I've updated and again broken down the changes into various top-level categories for easy viewing. For those interested, each item has a ref link that will take you to the specific code changes.
1.1.9 Changelog
- Below are the key changes in 1.1.9, the full change listing is (here (https://github.com/elkarte/Elkarte/compare/master...patch_1-1-9)).
New Features
- [New Feature] Quick Quote. This is where you select text and you can quote that when using quick reply (ref (https://github.com/elkarte/Elkarte/commit/7a644782c)).
- [New Feature] Quote Show More. Quote display limiting function. (ref (https://github.com/elkarte/Elkarte/commit/96d05f810)).
- [New Feature] Webp support to attachments and avatars. Includes the removal of save as PNG and dynamically set this based on alpha channel (ref (https://github.com/elkarte/Elkarte/commit/f109943df)).
- [New Feature] Open graph meta data and schema.org micro data to help with SEO (ref (https://github.com/elkarte/Elkarte/commit/64ccaf6cc)) & (ref (https://github.com/elkarte/Elkarte/commit/ebdd1d3a6)).
Feature Enhancements
- [Enhancement] Quote Depth Instead of allowing, or not, nested quotes, this allows you to limit them to a depth. (ref (https://github.com/elkarte/Elkarte/commit/1e32d32ff)).
- [Enhancement] Save avatars as PNG and thumbs as PNG options have been removed. The system will simply detect if the image has transparency and save as appropriate (Webp or if not enable then PNG or JPG)
- [Enhancement] Refactoring video embed code (from 2.0), also added tiktok support (ref (https://github.com/elkarte/Elkarte/commit/26e78bad6)).
- [Enhancement] preview ILA was using a low quality image in some instaces (ref (https://github.com/elkarte/Elkarte/commit/ffcd78849)).
- [Enhancement] Increase db size for password_hash (and needed for conversions) (ref (https://github.com/elkarte/Elkarte/commit/f7155b8c5)).
- [Enhancement] Allow for pass conversion from current forums (ref (https://github.com/elkarte/Elkarte/commit/d08adab73)).
- [Enhancement] Use low overhead thumb process for thumbnails (imagick) (ref (https://github.com/elkarte/Elkarte/commit/b30924222)).
- [Enhancement] Resize large images before doing pixel inspection to save memory (ref (https://github.com/elkarte/Elkarte/commit/b30924222)).
- [Enhancement] Don't do any rotation processing if not a jpg (imagick) (ref (https://github.com/elkarte/Elkarte/commit/b30924222)).
General Improvements
- [improve] Fix admin registration form layout (ref (https://github.com/elkarte/Elkarte/commit/d9daae41b)).
- [improve] 4byte efficiency improvement (ref (https://github.com/elkarte/Elkarte/commit/ca80290af)).
- [improve] Several improvements to HTML -> MD conversion function. (ref (https://github.com/elkarte/Elkarte/commit/c4614ea2c)).
- [improve] Several improvements to HTML -> BBC conversion function, used by email posting (ref (https://github.com/elkarte/Elkarte/commit/404a0c608)).
- [improve] Improvement to how unsubscribe token is created and shown (ref (https://github.com/elkarte/Elkarte/commit/73a571ca1)).
- [improve] Minor CSS fixes (ref (https://github.com/elkarte/Elkarte/commit/6b58b1207)).
- [improve] Use the alt value if its available for cid (inline image attachment) (ref (https://github.com/elkarte/Elkarte/commit/e69e9ae7f)).
- [improve] Be a little less restrictive on email table structure swapping to plain text (ref (https://github.com/elkarte/Elkarte/commit/e4a4d5224)).
- [improve] Some multipart/mixed plain sections should be joined (ref (https://github.com/elkarte/Elkarte/commit/b7a1206a3)).
- [improve] Error box in login form was a mess (ref (https://github.com/elkarte/Elkarte/commit/8cf2604ca)).
- [improve] Search result enhancements, show the first matching message in a topic, preventing a very short message from gaining to much relevance (ref (https://github.com/elkarte/Elkarte/commit/6576fcbc8)).
- [improve] Improve the search highlight logic (ref (https://github.com/elkarte/Elkarte/commit/c32bdd9ba)).
- [improve] New default Gravatar options (ref (https://github.com/elkarte/Elkarte/commit/1dc027c3d)).
- [improve] Improve the ILA button and CSS(ref (https://github.com/elkarte/Elkarte/commit/e7189276c)).
- [improve] Update markdown (ref (https://github.com/elkarte/Elkarte/commit/9a4ffa678)).
- [improve] Indicate the avatar preview with text and not just a red border (ref (https://github.com/elkarte/Elkarte/commit/3ce111ad4)).
- [improve] Allow upload avatar preview (2.0 backport) (ref (https://github.com/elkarte/Elkarte/commit/f2dcf8113)).
- [improve] Tweak smiley position in sentence to better work with font (ref (https://github.com/elkarte/Elkarte/commit/3d0d9a4e2)).
- [improve] Add 'att_reset' to BBC parser (used by ila) (ref (https://github.com/elkarte/Elkarte/commit/23f771593)).
- [improve] Allow a way for only devs to see depreciation notices (ref (https://github.com/elkarte/Elkarte/commit/88485d5b0)).
- [improve] Add topic approval to quick moderation action from message index (ref (https://github.com/elkarte/Elkarte/commit/10426bda1)).
- [improve] Cursor was left in quote when in wizzy mode (ref (https://github.com/elkarte/Elkarte/commit/999eb1c31)).
- [improve] Scroll into view works better then older location hash (ref (https://github.com/elkarte/Elkarte/commit/0bd43bb27)).
- [improve] From OI, potential pw conversion (ref (https://github.com/elkarte/Elkarte/commit/82004fa46)).
Bugs Fixed
- [bugfix] Emptying the cookie name could leave the admin locked out (ref (https://github.com/elkarte/Elkarte/commit/609496c08)).
- [bugfix] Collapsing legend in ACP was not (always) working (ref (https://github.com/elkarte/Elkarte/commit/237e9df66)).
- [bugfix] Mention pulldown (in wizzy) would collapse after positioning. Simplify / expand regex and fix time-gate (ref (https://github.com/elkarte/Elkarte/commit/e0fe51479)).
- [bugfix] Some items were not being logged (ref (https://github.com/elkarte/Elkarte/commit/116963329)).
- [bugfix] Various post by email updates to better support multipart/related and multipart/mixed formats. (ref (https://github.com/elkarte/Elkarte/commit/32d60bc52)).
- [bugfix] Profile Edits selection was still shown when core feature was off (ref (https://github.com/elkarte/Elkarte/commit/ee938671c)).
- [bugfix] PBE replies were not run through htmlspecialchars on save (ref (https://github.com/elkarte/Elkarte/commit/9a246219c)).
- [bugfix] Quick Quote needs to be wrapped in CDATA for safety, thanks Steeley for the report (ref (https://github.com/elkarte/Elkarte/commit/3ad77313c)).
- [bugfix] Revert https://github.com/elkarte/Elkarte/pull/3664/commits/3ad77313c04d8af309ebf8c15156f389778e9454 and fix another way (ref (https://github.com/elkarte/Elkarte/commit/366568b54)).
- [bugfix] Account for empty center tags as happens in email due to html stripping. (ref (https://github.com/elkarte/Elkarte/commit/30d46b134)).
- [bugfix] cleanXml escape missed a few characters (ref (https://github.com/elkarte/Elkarte/commit/31e5f8114)).
- [bugfix] Strip tags can return nothing, need to catch that occurrence (ref (https://github.com/elkarte/Elkarte/commit/d65c41cff)).
- [bugfix] Email parsers could clip the closing body tag (ref (https://github.com/elkarte/Elkarte/commit/55a930ed9)).
- [bugfix] Adjust regex for --- to hr when processing email (ref (https://github.com/elkarte/Elkarte/commit/909de1088)).
- [bugfix] Reset this hidden item when ACP is updated (ref (https://github.com/elkarte/Elkarte/commit/81fe34c7c)).
- [bugfix] Check for * disposition for attachment processing (PBE) and sanitize file names (ref (https://github.com/elkarte/Elkarte/commit/947b391ad)).
- [bugfix] Leave attachments alone in multipart/mixed (ref (https://github.com/elkarte/Elkarte/commit/21bd31fb9)).
- [bugfix] More multipart/mixed processing of any sections (ref (https://github.com/elkarte/Elkarte/commit/04ee6b698)).
- [bugfix] iconv_mime_decode may fail or even partially decode, check for that (ref (https://github.com/elkarte/Elkarte/commit/c918a1c9e)).
- [bugfix] Handle multiple content-type or content-transfer-encoding they are not vaiid but do occur (ref (https://github.com/elkarte/Elkarte/commit/30f0f8cf4)).
- [bugfix] fix #1878 package server controller missing tab data (ref (https://github.com/elkarte/Elkarte/commit/551d32dc3)).
- [bugfix] Account for version level tags with v at the start like v1.1.7 (ref (https://github.com/elkarte/Elkarte/commit/8c446aa59)).
- [bugfix] Fix a host of minor issues with drag and drop attachments (ref (https://github.com/elkarte/Elkarte/commit/9789d188f)).
- [bugfix] memoryReturnBytes function could be passed improper data and fail (ref (https://github.com/elkarte/Elkarte/commit/132a6cdf4)).
- [bugfix] Fix tests to run as actions, add 8.1 support, pack up old travis tests (ref (https://github.com/elkarte/Elkarte/commit/4099a444a)).
- [bugfix] I guess one could use webp as smileys (ref (https://github.com/elkarte/Elkarte/commit/a6484cc01)).
- [bugfix] Update attachment download/view gobbledygook code (ref (https://github.com/elkarte/Elkarte/commit/dfb0e6a17)).
- [bugfix] Post separator markup was messy and did not render properly in all browsers (ref (https://github.com/elkarte/Elkarte/commit/5190e3919)).
- [bugfix] Without an isset in the controller, those may not work as expected (ref (https://github.com/elkarte/Elkarte/commit/4cf4f6cbb)).
- [bugfix] The CSS quick mod checkbox style was somehow dropped in 1.1 (ref (https://github.com/elkarte/Elkarte/commit/1e6003336)).
- [bugfix] Action_no_attach exits, no need to return (ref (https://github.com/elkarte/Elkarte/commit/1ec019062)).
- [bugfix] backport a bunch of ILA edge case fixes from 2.0 (ref (https://github.com/elkarte/Elkarte/commit/2657608f8)).
- [bugfix] Return approved status to ILA so it can act accordingly (ref (https://github.com/elkarte/Elkarte/commit/ea13d398e)).
- [bugfix] attachurl was not replacing the temp with the public id (ref (https://github.com/elkarte/Elkarte/commit/c44eafcc6)).
- [bugfix] Provide a way to show pending approval for ILA images (ref (https://github.com/elkarte/Elkarte/commit/952ea5711)).
- [bugfix] Function is not used, no need to load it (ref (https://github.com/elkarte/Elkarte/commit/5f64fc438)).
- [bugfix] Specify load lazy value for avatar images (ref (https://github.com/elkarte/Elkarte/commit/a19b09f6d)).
- [bugfix] That function can return false, so best to exit from unzip (ref (https://github.com/elkarte/Elkarte/commit/c6dcdc8a1)).
- [bugfix] fix #3561 label it as posts or topics to avoid confusion (ref (https://github.com/elkarte/Elkarte/commit/50d44b7fb)).
- [bugfix] fix #3521 (ref (https://github.com/elkarte/Elkarte/commit/35bd60f65)).
- [bugfix] don't set the level before the type (ref (https://github.com/elkarte/Elkarte/commit/774bbfe35)).
- [bugfix] Proposed fix for #3518 4-byte chars in filename. Expose clean_4byte_chars for use in other places (ref (https://github.com/elkarte/Elkarte/commit/c4f2fd350)).
- [bugfix] Point to the correct wiki endpoints (ref (https://github.com/elkarte/Elkarte/commit/7c7e88d24)).
- [bugfix] a 2 second cache is not useful (ref (https://github.com/elkarte/Elkarte/commit/4aff64702)).
- [bugfix] Viewing a ban group would result in a blank screen error (ref (https://github.com/elkarte/Elkarte/commit/bcda0a4ef)).
- [bugfix] A few mobile adjustments (ref (https://github.com/elkarte/Elkarte/commit/12be490f9)).
- [bugfix] Use the sanitized value (ref (https://github.com/elkarte/Elkarte/commit/b713bd34b)).
- [bugfix] _ in url were escaped and need to be set back (ref (https://github.com/elkarte/Elkarte/commit/860ba0eaf)).
- [bugfix] Used by PBE but never set (unapproved topic/post) (ref (https://github.com/elkarte/Elkarte/commit/8701a3321)).
- [bugfix] Unapproved topic with oldTopicDays set would result in error (ref (https://github.com/elkarte/Elkarte/commit/e2f76548f)).
- [bugfix] Prevent undefined error in custom fields (ref (https://github.com/elkarte/Elkarte/commit/8b9aec7c1)).
- [bugfix] Consistent keyinfo layout helps with QQ addon (ref (https://github.com/elkarte/Elkarte/commit/d8a06631e)).
- [bugfix] fix #3409 .icon_anchors should have transform (ref (https://github.com/elkarte/Elkarte/commit/79adb87dd)).
- [bugfix] ILA "share" button was getting blocked by filters (ref (https://github.com/elkarte/Elkarte/commit/6534a63b0)).
- [bugfix] Point to the right site for addons, not the cname (ref (https://github.com/elkarte/Elkarte/commit/1d5f11975)).
- [bugfix] The return path should not be set for sendmail, smtp does its own. Also the syntax was not compliant. (ref (https://github.com/elkarte/Elkarte/commit/448b0f550)).
- [bugfix] Annoyance, after upload the install package was missing, for addons, from the upload completion page. (ref (https://github.com/elkarte/Elkarte/commit/779677add)).
- [bugfix] Single line code BBC was showing vertical scroll (ref (https://github.com/elkarte/Elkarte/commit/d3cc8f6a7)).
- [bugfix] fix #3407 clean up CSS for RTL buttons (ref (https://github.com/elkarte/Elkarte/commit/2ffb67fe8)).
- [bugfix] PM's were not updating reply status (ref (https://github.com/elkarte/Elkarte/commit/6c3178977)).
- [bugfix] Toggling core features on/off could overflow log_mentions status (ref (https://github.com/elkarte/Elkarte/commit/d7e749727)).
- [bugfix] Gravatar avatar in account button would break with rating enabled (ref (https://github.com/elkarte/Elkarte/commit/d67fc1088)).
- [bugfix] Signature chars remaining was not working as expected (ref (https://github.com/elkarte/Elkarte/commit/6b70b6eaa)).
- [bugfix] fix #3536 html2md was breaking plain text Links plus more (ref (https://github.com/elkarte/Elkarte/commit/a424ad0ce)).
- [bugfix] Make sure only return is an accepted type (ref (https://github.com/elkarte/Elkarte/commit/a748bfe58)).
- [bugfix] Changed like_button to react_button, likes_button to reacts_button, so that AdBlockPlus doesn't remove the likes button when Social Media Blocking is enabled (ref (https://github.com/elkarte/Elkarte/commit/b7ec1f625)).
- [bugfix] Email search for non moderator, in case sensitive DB, errors (ref (https://github.com/elkarte/Elkarte/commit/84133eb2d)).
- [bugfix] Error filters were not honoring asc/desc flag. (ref (https://github.com/elkarte/Elkarte/commit/2c9558ecf)).
- [bugfix] That is a post value, not get (ref (https://github.com/elkarte/Elkarte/commit/94c7dd786)).
- [bugfix] Converted missed functions in install files (ref (https://github.com/elkarte/Elkarte/commit/02fd54caa)).
- [bugfix] Moved functions to Util as more sensible place for them, imo (ref (https://github.com/elkarte/Elkarte/commit/d9f86c326)).
- [bugfix] Missed pg_version needing a connection to work (ref (https://github.com/elkarte/Elkarte/commit/34e6b965d)).
- [bugfix] Big change of all strftime and gm_strftime to elk_strftime and elk_gmstrftime (ref (https://github.com/elkarte/Elkarte/commit/6f4d0a49b)).
- [bugfix] The undo plugin caused an unexpeced page jump when preloaded (ref (https://github.com/elkarte/Elkarte/commit/b524ee7be)).
- [bugfix] Draft last saved spinner was output twice in QR (ref (https://github.com/elkarte/Elkarte/commit/075bfaf81)).
- [bugfix] Remove extra spaces from text so its bbc valid (ref (https://github.com/elkarte/Elkarte/commit/6a97d2b93)).
- [bugfix] Generating an error while logging an error is bad form\(ref (https://github.com/elkarte/Elkarte/commit/f29fc9124)).
- [bugfix] Board descriptions that used html were not being converted to bbc (ref (https://github.com/elkarte/Elkarte/commit/e7fbf53d4)).
- [bugfix] bb log entry was still causing a ' error even with db_escaping (ref (https://github.com/elkarte/Elkarte/commit/5b7b04338)).
- [bugfix] SMTP fsock need to use suppress or it will not continue (ref (https://github.com/elkarte/Elkarte/commit/7cdd95486)).
- [bugfix] Empty privacy policy box was still shown on checkbox registation (ref (https://github.com/elkarte/Elkarte/commit/bde42aafe)).
- [bugfix] Indentation was being added to output as \n\t\t\t (ref (https://github.com/elkarte/Elkarte/commit/9bf13d4c4)).
- [bugfix] Prevent potential 502 gateway failed error, purge buffer as a precaution (ref (https://github.com/elkarte/Elkarte/commit/fe1d18b83)).
- [bugfix] Write all frames if its a gif to avoid dropping animation (gif/imagick) (ref (https://github.com/elkarte/Elkarte/commit/b30924222)).
- [bugfix] Set to first image in layers to avoid 1px thumb (gif/imagic) (ref (https://github.com/elkarte/Elkarte/commit/b30924222)).
- [bugfix] The reduced upload size was not reflected back in the UI (ref (https://github.com/elkarte/Elkarte/commit/68c574062)).
- [bugfix] The buffer should still be cleared before sending the image (ref (https://github.com/elkarte/Elkarte/commit/27e5a379b)).
- [bugfix] Collasping permission legend in acp was not always working (ref (https://github.com/elkarte/Elkarte/commit/237e9df66)).
PHP 8.1 updates
- [8.1] Captcha was not working with PHP 8.1 Updated the ttf fonts to add ones with minor grunge built (ref (https://github.com/elkarte/Elkarte/commit/12e4d720e)).
- [8.1] Prevent calling of functions that may be disabled by the host (ref (https://github.com/elkarte/Elkarte/commit/1156da85d)).
- [8.1] Can't use null in PHP 8.1 (ref (https://github.com/elkarte/Elkarte/commit/eb305251e)).
- [8.1] That may be null, and 8.1 will abend (ref (https://github.com/elkarte/Elkarte/commit/eb4ff8396)).
- [8.1] Do not send a float value to chr() (ref (https://github.com/elkarte/Elkarte/commit/bfa8a3b65)).
- [8.1] 8.1 error due to curl option never existing (ref (https://github.com/elkarte/Elkarte/commit/7fa73272f)).
- [8.1] seems recent GD (8.1) does no like the float where an int is needed. (ref (https://github.com/elkarte/Elkarte/commit/b01c8e0a5)).
- [8.1] Depreciation notice in 8.1 (ref (https://github.com/elkarte/Elkarte/commit/235401c4d)).
- [8.1] More 8.1 tweaks (ref (https://github.com/elkarte/Elkarte/commit/c22756db0)).
- [8.1] PHP 8.1 will not like adding strings (ref (https://github.com/elkarte/Elkarte/commit/cd9879ff9)).
- [8.1] un used paramerter, will throw depreciation in 8.1 (ref (https://github.com/elkarte/Elkarte/commit/30783d166)).
- [8.1] fix some 8.1 install errors (ref (https://github.com/elkarte/Elkarte/commit/4265cdb22)).
- [8.1] 8.1 does not like nulls in these functions (ref (https://github.com/elkarte/Elkarte/commit/91dc3fac9)).
- [8.1] some 8.1 fixes for type hint on interfaces (ref (https://github.com/elkarte/Elkarte/commit/a7f5dadfb)).
- [8.1] PHP 8.1 Compat version of strftime (ref (https://github.com/elkarte/Elkarte/commit/6b02d125a)).
- [8.1] Updated Db-PostgreSQL to be PHP 8.1 compatible (ref (https://github.com/elkarte/Elkarte/commit/5eec56d27)).
- [8.1] php8.0 can throw undefined error when using unset on an array key (ref (https://github.com/elkarte/Elkarte/commit/609496c08)).
- [8.1] Another 8.1 undefined index (ref (https://github.com/elkarte/Elkarte/commit/085ea9b07)).
- [8.1] Another issue with 8.1 and BB plugin (ref (https://github.com/elkarte/Elkarte/commit/f067dd2f0)).
Misc updates
- [misc] Get 1.1 tests working again as action vs Travis (ref (https://github.com/elkarte/Elkarte/commit/84334050b)).
- [misc] Address recent memory issue in phpunit (ref (https://github.com/elkarte/Elkarte/commit/ecc54353d)).
- [misc] Use pcov vs xdebug for test coverage (ref (https://github.com/elkarte/Elkarte/commit/1b6e11611)).
- [misc] Prevent some already defined error notices in testbed (ref (https://github.com/elkarte/Elkarte/commit/f13c98ad6)).
1.1.9 is a big update, mainly since its been over a year since 1.1.8. We were not planning on a 1.1.9 but since 2.0 is taking some extra time, it seemed like we should do a stop gap release and get PHP 8.1 addressed, a bunch of fixes (many edge cases) and toss in some new features (backported from 2.0) All of that is detailed in the above post.
IF <-- that is in bold to gather attention! ... you installed a previous 1.1.9 patch and are still using it and you enabled site metadata in the ACP (features -> general) then turn that off before you uninstall the old patch. When I went to uninstall the previous 1.1.9 patch on a couple of sites I got the ever fun 500 error :boom: However in good diagnostic form I just kept hitting page refresh and it came back so I believe the cause was that integration was still being attempted. I've put a fix for that condition in the new package. All I can say is if you get that error, a page refresh or two will get past that so you can delete the old and install the new.
"Testing" is underway! Thanks again
@Spuds
Apologies if this appears to be a stupid (or redundant) suggestion, but if it's not listed up front in a "system requirements" section of the package description for download, it might be handy to note what PHP versions are supported by each EA version. While 7.4 is on the cusp of EOL, it is the latest version available to me unless I want to go outside of my host-provided packages. (I'm not sure if that lack of newer options is due to platform compatibility issues or a missing round-tuit, but it is what it is.)
And, since EA isn't the only code package running on my server, every time I upgrade my PHP version I have to run compatibility checks on everything else too, and stepping up to 7.x for another application forced me to replace several other legacy applications I was running with ones that weren't limited at 5.6, and then port over the data (square-peg/round hole exercise). Consequently I'm not sure what else is going to break if I were to step up to v. 8.x
Not that I'm looking to upgrade (I suspect what I have running now will live longer than I and most of my users will), but if it's not there already somewhere, others may find that version compatibility information "up front" nice to know, ya know.. :undecided:
-=In the readme.md file in 1.16 (for example) - says it's good with PHP 5.3 "and newer" but... "how much newer?". Like 8.3? If 1.1.8 doesn't play well with 8.x, I suspect 1.1.6 won't either.
Was going to try it on one of my not-so-active forums, but seem to have way too many errors due to my theme.
Separation by
@Spuds is the theme.
Here's list of the errors: (Only the failed edits listed)
Separation
Execute Modification ./themes/elk_theme_separation_11/Display.template.php Test failed
1. Replace ./themes/elk_theme_separation_11/Display.template.php Test failed
2. Replace ./themes/elk_theme_separation_11/Display.template.php Test failed
3. Replace ./themes/elk_theme_separation_11/Display.template.php Test failed
4. Replace ./themes/elk_theme_separation_11/Display.template.php Test failed
5. Replace ./themes/elk_theme_separation_11/Display.template.php Test failed
6. Replace ./themes/elk_theme_separation_11/Display.template.php Test failed
Execute Modification ./themes/elk_theme_separation_11/MessageIndex.template.php Test failed
1. Replace ./themes/elk_theme_separation_11/MessageIndex.template.php Test failed
2. Replace ./themes/elk_theme_separation_11/MessageIndex.template.php Test failed
Execute Modification ./themes/elk_theme_separation_11/css/index.css Test failed
1. Replace ./themes/elk_theme_separation_11/css/index.css Test failed
3. Replace ./themes/elk_theme_separation_11/css/index.css Test failed
4. Replace ./themes/elk_theme_separation_11/css/index.css Test failed
5. Replace ./themes/elk_theme_separation_11/css/index.css Test failed
6. Replace ./themes/elk_theme_separation_11/css/index.css Test failed
8. Replace ./themes/elk_theme_separation_11/css/index.css Test failed
10. Replace ./themes/elk_theme_separation_11/css/index.css Test failed
11. Replace ./themes/elk_theme_separation_11/css/index.css Test failed
12. Replace ./themes/elk_theme_separation_11/css/index.css Test failed
13. Replace ./themes/elk_theme_separation_11/css/index.css Test failed
14. Replace ./themes/elk_theme_separation_11/css/index.css Test failed
17. Replace ./themes/elk_theme_separation_11/css/index.css Test failed
20. Replace ./themes/elk_theme_separation_11/css/index.css Test failed
22. Replace ./themes/elk_theme_separation_11/css/index.css Test failed
23. Replace ./themes/elk_theme_separation_11/css/index.css Test failed
26. Replace ./themes/elk_theme_separation_11/css/index.css Test failed
Execute Modification ./themes/elk_theme_separation_11/css/rtl.css Test failed
2. Replace ./themes/elk_theme_separation_11/css/rtl.css Test failed
Execute Modification ./themes/elk_theme_separation_11/index.template.php Test failed
1. Replace ./themes/elk_theme_separation_11/index.template.php Test failed
2. Replace ./themes/elk_theme_separation_11/index.template.php Test failed
I think that is normal for custom themes, right?
Well... Ummm... Duh.... LOL :tongue:
Except for the message "/sources/subs/Portal.subs.php File not found", it slips through easily.
Vanilla installation without portal. Therefore the logical error message. ;)
As always good work @Spuds ! :thumbsup:
That is to cover the portal, if one has it installed, I think.
That is correct. If you fail to upgrade the portal then you would either get a hacking attempt or a 500 error. I added the portal edit in the 1.1.9 package simply to avoid someone breaking there forum during an upgrade. I would not normally do that, but in this case it seemed prudent.
Oh yeah! ... The patch file will give it a "go" but if the theme made modification to the same area (even an extra space), it will simply not be able to do anything. The (generally) good thing is that the custom theme should still work as is, it will just lack the new features.
In adding the quick quote, quote more, and structed data capability, it meant edits to
index.template and
display.template both of which are some of the most commonly edited files when making a custom theme. I've done my best to outline how/what to edit in a serries of "how to add the 1.1.9 xyz to your theme" posts under the theme board.
Thanks for the update. I decided to give it a try on our site. I did make a change to facilitate my git based release management and the need to update the database:
Please consider supporting
git merge for release updates like this, which can be accomplished via
upgrade.php (https://github.com/elkarte/Elkarte/blob/development/install/upgrade.php).
@nwsw that is an awesome idea !!
@radu81 please try this file and see if it fixes the issue on your server.
The issue appears to be that your server has webp support in GD but not in IM. The system will choose IM over GD but it was not smart enough to "fall back" to GD for webp processing if that was the only option. So what happened is the webp file simply passed through as it was an allowed extension type.
Save the current one, you will need to restore it in order to uninstall the test 1.1.9 patch and install the fine when I publish it.
Just for reference, this is how the system should behave in doing WebP Processing
- No webp support in GD or IM, allowed as an extension type => Should just pass through as a webp, no thumbnail
- webp support in either GD/IM, ACP off, allowed as an extension type => Should convert to PNG or JPG (based on existing transparency) and create a thumbnail. One could argue this should not do a format conversion, but I imagined this as a compatibility mode since there is not (yet) 100% webp support in all browsers/platforms.
- webp support in either GD/IM, ACP on, allowed as an extension type => Should leave as webp and create a webp thumbnail
- webp support in either GD/IM, ACP on, not allowed as an extension type & checking extensions => Should reject
- The system prefers IM processing over GD if both have webp support, however it will now fallback to GD webp support if not available in IM
I tried but I get the same results on my forum, webp image is not resized, in preview mode and also in the post message, instead I get this error in Elk log:
Thumbnail error (unable to open image `/tmp/magick-19957ybT8mdDES6BS': No such file or directory @ error/blob.c/OpenBlob/2712)
I found another area where the fallback was not working, so it was still trying to use IM on the webp image, which on your server is not cool. That blob error was the output of the error line we added, so at least I knew where to look. Should be fixed, lets hope there are no more problems.
Seems to work fine now! Thanks Spuds!