Re: Threaded View
Reply #4 –
Me use MyBB since many years. Threaded View never come to be deployed. Will not be missed.
It is not worth the trouble.
Re: Threaded View
Reply #5 –
yep, agree.. "Threaded view" would require lots of changes..
1) modify the database structure in order to reflect replies to Messages
2) rewrite (and duplicate) the template.
3) modify the topic / message actions (merge, split and such stuff) -> move reply x to reply y inside a single topic and such things.
I think the MyBB folks do have a good reason why it was removed.
Re: Threaded View
Reply #7 –
Not to sound like a dick, but if it is that easy, do it.
Some big questions which arise immediately: if you have 10 posts per page, what if a post has 1000 sub-posts? If you do ?msg=X where X is a threaded message, you have to get all of its parents and children. Do threads have multiple levels? How do you find all of those levels?
Re: Threaded View
Reply #9 –
A recursive query? So a thread with 100 levels would result in at least 100 queries. Of course that is extreme and you would probably want to have some setting to limit the number of levels. Still, say you set that to 10. You are then adding 10 queries to that page. It would be per level since you would get the first level, then do SELECT ... FROM messages WHERE id_parent IN($parents);
Even if with collapse/expand, you are getting all of those queries. Unless it uses AJAX to get the rest of them? I am pretty sure that Elk follows the SMF model of all functionality working with JS turned off, so that wouldn't work.
Re: Threaded View
Reply #11 –
Then if you have a post with 1000 sub posts you need to get those 1000 sub posts. Unless the posts per page is applied to the sub posts. Then your pagination needs to be rewritten.
Re: Threaded View
Reply #13 –
Huh? You only need one query to get the posts on the page. Without looking it is something like "SELECT ... FROM messages WHERE id_topic = $topic AND id_msg > $id_msg_start AND approved = 1 LIMIT $posts_per_page"
Re: Threaded View
Reply #14 –
Precisely. Now what is your point?