ElkArte Community

Title: Show Drafts - No Select Highlight/strong text when selected
Post by: Lou on February 06, 2016, 07:01:27 pm
Click on My Messages, ( Personal Messages>Inbox ) then selecting Show Drafts does present the Show Drafts section however, the shadow select/highlight jumps up to the Inbox button.

On the other hand, doing the same via the User Profile and the highlight/strong text works as it should.

ETA: Theme is the Light variant and I am using sidebar menus.
Title: Re: Show Drafts - No Select Highlight/strong text when selected
Post by: Flavio93Zena on February 07, 2016, 12:27:16 am
I see, #menu_current_area is not re-assigned properly. Can't even figure out where it is coded at all... #_#
Title: Re: Show Drafts - No Select Highlight/strong text when selected
Post by: Burke Knight on February 07, 2016, 01:40:15 am
Which theme are you using, Be Social or Light?
I'm on Be Social, and not seeing anything like this.

After testing using Light skin, I see it. However, I think this is how it should be.
When looking at drafts from the profile, you are looking at the regular forum drafts, which would highlight your profile, as it does.

However, when go in via My Messages, you are only seeing private message drafts, which highlights the My Messages tab.

This, is how it should be, and not a bug, IMHO.
Title: Re: Show Drafts - No Select Highlight/strong text when selected
Post by: Lou on February 07, 2016, 02:09:06 am
It is the Light variant. I see it as inconsistent behaviour as:

When entering My Messages the Inbox is highlighted and the user remains in the InBox field.

Click on the New Message and New Message stays highlighted and the user remains in the New Message field.

Click on Show Items and Show Items stays highlighted and the user remains in the Show Items field.

Click on Show Drafts and the highlight jumps to the Inbox yet the user remains in the Show Drafts field. The drafts are not a part of the Inbox; the drafts have yet to be sent anywhere and are not a 'received' PM.  The Inbox is a place for received PM's. To me it seems illogical for the InBox to be highlighted when the user is really in the Show Drafts.
Title: Re: Show Drafts - No Select Highlight/strong text when selected
Post by: Burke Knight on February 07, 2016, 07:46:33 am
I'm not seeing that.
Heck, I don't even see "Inbox" to be highlighted.

My Messages Drafts Page:
(http://bkd.pw/issues/MDrafts.png)

Profile Drafts Page:
(http://bkd.pw/issues/PDrafts.png)
Title: Re: Show Drafts - No Select Highlight/strong text when selected
Post by: Lou on February 07, 2016, 08:52:53 am
I should mention that I am using sidebar menu; sorry about that. Here is an image of what I see.




Title: Re: Show Drafts - No Select Highlight/strong text when selected
Post by: Burke Knight on February 07, 2016, 09:03:20 am
Well now... That would totally explain why I did not see "Inbox"! LOL
I stopped using sidebar menu a long time ago.
Early days of SMF 2.0 line, in fact...

This, is exactly why screenshots of issues are a must. :)
Title: Re: Show Drafts - No Select Highlight/strong text when selected
Post by: Flavio93Zena on February 07, 2016, 11:29:19 am
Of course, pfft, sidemenus are life, sidemenus are forever! :)
#SidemenuLover
Title: Re: Show Drafts - No Select Highlight/strong text when selected
Post by: Burke Knight on February 07, 2016, 01:14:48 pm
Quote from: Burke Knight – /me slaps @Flavio93Zena (#OpIsis) around a bit with a large trout. (http://www.burkeknight.com/smileys/default/trout.gif)
Title: Re: Show Drafts - No Select Highlight/strong text when selected
Post by: Lou on February 07, 2016, 02:18:43 pm
Quote from: Burke Knight – Well now... That would totally explain why I did not see "Inbox"! LOL
I stopped using sidebar menu a long time ago.
Early days of SMF 2.0 line, in fact...

This, is exactly why screenshots of issues are a must. :)

Yeah .... I am a bit hung up on that sidebar menu.  :)   Probably comes from being an old man. LOL  Every now and then, I go to the dark side and use the drop down menus. After a day or so it just annoys me for some reason and I go back to the sidebar.

Title: Re: Show Drafts - No Select Highlight/strong text when selected
Post by: Flavio93Zena on February 08, 2016, 02:32:43 am
I just never liked having 2 dropdowns of the same kind one below each other (main menu and the other one profile or whatever), so I always go with sidemenu :)
Title: Re: Show Drafts - No Select Highlight/strong text when selected
Post by: emanuele on March 23, 2016, 06:37:47 pm
I remember that one, I just don't remember if I fixed it in the 1.0.7 patch or in the 1.1 branch... :'(
Title: Re: Show Drafts - No Select Highlight/strong text when selected
Post by: Flavio93Zena on April 19, 2016, 07:05:22 pm
This one is still here, not fixed in 1.0.7, not fixed on here either.
Title: Re: Show Drafts - No Select Highlight/strong text when selected
Post by: emanuele on April 23, 2016, 12:17:35 pm
hmm... now go to figure out which branch it was in...
Well, the problem was that the default didn't have the sub action set and so it was not highlighting properly the entry.
Title: Re: Show Drafts - No Select Highlight/strong text when selected
Post by: Flavio93Zena on April 23, 2016, 01:41:36 pm
That's coz GitHub is a mess #_#
Title: Re: Show Drafts - No Select Highlight/strong text when selected
Post by: emanuele on April 23, 2016, 07:15:54 pm
GitHub != Git
And anyway, it's a mess to you, to me it's a wonderful piece of software.
Of course, if you know of a software (any kind of software) that cannot be misused feel free to give us this example.