ElkArte Community

Elk Development => Feature Discussion => Exterminated Features => Topic started by: Jorin on October 23, 2014, 11:45:48 pm

Title: [1.0.1] Text links
Post by: Jorin on October 23, 2014, 11:45:48 pm
It seems that there is a problem with text links. See the screenshot please. There is enough space on the right so "Apps von Google" should be shown there, not in a new row beginning on the left.
Title: Re: [1.0.1] Text links
Post by: IchBin on October 24, 2014, 12:17:57 am
Personally, I don't consider that a problem. lol I'd rather the link stay all together.

Comment out these two lines in index.css to change it to what you like.
Code: [Select]
/* Shorten url's inside posts. */
a.bbc_link {
/* display: inline-block; */
/* white-space: nowrap; */
overflow: hidden;
text-overflow: ellipsis;
max-width: 100%;
vertical-align: bottom;
}
Title: Re: [1.0.1] Text links
Post by: Jorin on October 24, 2014, 12:24:44 am
So it's not a bug, it's a feature!  :o :-[

Yep, I understand that it can make sense not to split a link. Hm, I'll think about changing or not. Thanks.
Title: Re: [1.0.1] Text links
Post by: emanuele on October 24, 2014, 04:45:40 am
It's half-a-feature let's say.
For example:
this is a very, very, very, very, very, very, very, very, very, very, very, very, very, very, very, very, very, very long text inside a link that would be loner than a single line in most of the cases, and if it doesn't resize a bit the browser window. :P (http://www.elkarte.net/community/index.php?topic=2150.msg4115#new)
This of course is an example, but from time to time it happens that someone posts some link from google with tons of gibberish that spans several lines. This "trick" is to shorten that link to an acceptable size.
Title: Re: [1.0.1] Text links
Post by: Jorin on October 24, 2014, 07:31:51 am
Is your link shortened? I don't get it... Shortened would be:

"
this is a very, very, very, very, very, very, very, very, very, very, very, very, very, very, very, very, very, very long text inside a link that (http://www.elkarte.net/community/index.php?topic=2150.msg4115#new)..."
Title: Re: [1.0.1] Text links
Post by: emanuele on October 24, 2014, 07:43:43 am
Yes, it is "shortened". The maximum allowed it's the page width, anything longer is cut.
This is obtained through CSS alone, and CSS can do only that much.
At the beginning it was a fixed maximum width, then it was changed to fill the page width (otherwise it was cutting too much texts).
It could be improved adding some javascript magic to find an "optimal" width I guess. Or not to cut it if it contains spaces, or a combination of all that.

ETA: in the scree what I see.
Title: Re: [1.0.1] Text links
Post by: Jorin on October 24, 2014, 08:07:17 am
Ah, okay, the IE6 at my office shows the unshortened link in your post.
Title: Re: [1.0.1] Text links
Post by: radu81 on October 24, 2014, 08:37:23 am
IE6 ?  :o your company should update to 8 or switch to another browser
Title: Re: [1.0.1] Text links
Post by: emanuele on October 24, 2014, 10:04:52 am
O_O

Okay, IE6 is not really supposed to be supported. :P
Elk should be IE8+ and I'm not entirely sure if everything works on IE8 either. It should, but something may not be perfect (I seem to remember IE8 doesn't support rounded corners for example, and maybe other stuff).
Title: Re: [1.0.1] Text links
Post by: Jorin on October 28, 2014, 03:16:44 am
Sorry, it's an IE9. :-[
Title: Re: [1.0.1] Text links
Post by: emanuele on October 28, 2014, 05:57:50 am
No problem. ;D

/me wonders if
@Spuds has an IE9 around to try it out.
Title: Re: [1.0.1] Text links
Post by: Spuds on October 28, 2014, 10:44:16 am
I do :D  .. and it did not truncate in my ie9 vbox ... adding
Code: [Select]
word-wrap: normal;
to the a.bbc_link declaration seemed to do the trick.
Title: Re: [1.0.1] Text links
Post by: emanuele on November 16, 2014, 04:30:52 pm
Memo: I see it applied to the patch_1-0-2 branch so it should be fixed.