Re: IRC Reply #255 – June 04, 2013, 11:27:58 am (04:35:29 AM) elk_core: [Elkarte] Spuds opened pull request #483: Update drafts JS to operate as a editor plugin (master...draftsJS) http://git.io/EebHeQ(08:19:16 PM) elk_core: [Elkarte] emanuele45 pushed 8 new commits to master: http://git.io/ruoJ7A(08:19:16 PM) elk_core: Elkarte/master d9341af emanuele: Revisited the template layers class adding more flexibility and few new methods...(08:19:16 PM) elk_core: Elkarte/master 92b17f3 emanuele: Small tweaks to the class to improve proprity handling (I hope) and some change on how the class is initialized in some of the files...(08:19:16 PM) elk_core: Elkarte/master 7eda4da emanuele: Ooops...(11:03:37 PM) elk_core: [Elkarte] eurich opened pull request #484: blame Ema (master...ssi_fixes) http://git.io/7W0TRA(11:09:27 PM) elk_core: [Elkarte] norv pushed 2 new commits to master: http://git.io/uG1ipA(11:09:27 PM) elk_core: Elkarte/master a6c3a98 notebook: blame Ema (11:09:27 PM) elk_core: Elkarte/master f5e1404 Norv: Merge pull request #484 from eurich/ssi_fixes...(11:58:34 PM) elk_core: [Elkarte] norv pushed 6 new commits to master: http://git.io/vHlbHw(11:58:34 PM) elk_core: Elkarte/master eb1c06e Thorsten Eurich: prevent undefined offset error(11:58:34 PM) elk_core: Elkarte/master c17e77b Thorsten Eurich: fixed pagelink styling in admin area(11:58:34 PM) elk_core: Elkarte/master ecc10e7 Thorsten Eurich: use the new callback function
Re: IRC Reply #256 – June 04, 2013, 11:29:30 am (11:59:48 PM) Norv: Ema, just curious, have you tried Geany?(11:59:55 PM) ***Norv #isatroll(12:00:06 AM) emanuele: yep, don't like it...(12:01:53 AM) Norv: Addicted.(12:02:40 AM) emanuele: it has weird shortcuts (at least that not I'm used to the ones I use) and it has the "gnome" look&feel that I really dislike... (12:05:00 AM) Norv: lol! Touche. After a long time of using it (occasionally), I just changed some of its shortcuts(12:05:57 AM) Norv: I can't figure out how could I live without some nod(12:06:05 AM) emanuele: lol
Re: IRC Reply #257 – June 04, 2013, 11:29:57 am (12:17:55 AM) elk_core: [Elkarte] eurich opened pull request #485: blue variant (master...blue_variant) http://git.io/Kvo_6A(12:52:35 AM) elk_core: [Elkarte] norv pushed 2 new commits to master: http://git.io/JtdZow(12:52:35 AM) elk_core: Elkarte/master 9c3d982 Thorsten Eurich: introducing the blue variant / get rid of SMF's light blue ......(12:52:35 AM) elk_core: Elkarte/master 1686ef2 Norv: Merge pull request #485 from eurich/blue_variant...(07:22:03 PM) elk_core: [Elkarte] eurich opened pull request #486: Cleaning controllers (master...various_fixes) http://git.io/pdKDYA(09:30:38 PM) elk_core: [Elkarte] eurich opened pull request #487: Templates & Javascript (master...templates) http://git.io/DCZUJQ(10:14:57 PM) elk_core: [Elkarte] norv pushed 4 new commits to master: http://git.io/gtvJEA(10:14:57 PM) elk_core: Elkarte/master d26759a Thorsten Eurich: unused globals.....(10:14:57 PM) elk_core: Elkarte/master 75aad77 Thorsten Eurich: mostly unused globals and a typo in var name...(10:14:57 PM) elk_core: Elkarte/master 4e9ebad Thorsten Eurich: cleaning the javascript files....(11:49:59 PM) elk_core: [Elkarte] eurich opened pull request #488: security related fixes (master...fixes) http://git.io/fSaErQ(04:48:01 AM) Norv: (for the log)(04:48:07 AM) Norv: http://www.simplemachines.org/community/index.php?topic=347688
Re: IRC Reply #258 – June 04, 2013, 11:30:21 am (08:20:17 PM) groundup: Hmm... a mongodb backed forum. That would be cool.(08:20:23 PM) ***groundup is using mongo now(08:25:55 PM) groundup: Maintenance should have its own controller and views. The idea was always that maintenance should be the most basic stuff to tell a user that the forum is in maintenance. However, loading two or three more files isn't a big deal and would allow a lot more functionality to it. Maybe even have another Settings.php file for maintenance
Re: IRC Reply #259 – June 04, 2013, 01:02:31 pm (10:51:52 PM) emanuele: If I read MySQL documentation correctly, we should replace TYPE=HEAP with ENGINE=MEMORY am I right?(10:56:31 PM) Norv: yes(10:56:57 PM) Norv: Where do we have TYPE?(11:24:49 PM) emanuele: Arg...message index doesn't have the pages at the end...(11:25:13 PM) ***emanuele feels layers are broken somewhere...(11:25:18 PM) ***emanuele whistles innocently(11:25:21 PM) Norv: (11:28:29 PM) Norv: http://imgs.xkcd.com/comics/ballmer_peak.png (11:02:44 PM) Norv: lol... http://www.simplemachines.org/community/index.php?topic=342638.msg2340978#msg2340978(11:07:31 PM) Norv: There's an interesting detail there, my gut tells me we want to fix the duplicate names. It has come up right at the first 'splits' TE made(11:08:38 PM) emanuele: One of the things I would like to do is kill all the template_main(11:08:58 PM) Norv: yes... We could do that easily, no?(11:09:15 PM) Norv: I mean, it's just a matter of making sure to specify the subtemplate you want(11:09:21 PM) emanuele: Yep, I think so.(11:09:48 PM) ***emanuele was just too lazy and was working on other things... (11:14:56 PM) ***Norv sagenods at the lazyness.(10:50:17 PM) Norv: I'm to get home only tomorrow, and I spent time today re-reading older sm.org topics(12:34:52 AM) ***emanuele has just finished an endless post (almost like Norv ) and now goes bed happy
Re: IRC Reply #260 – June 04, 2013, 01:08:31 pm (08:45:59 PM) groundup: Getting rid of all of the template_main() and replacing them with template_$template() would make the files reusable!(08:48:23 PM) Norv: groundup: at the very least, it will allow these guys, Ema and TE, to split things some more, and perhaps include files for the most used subtemplates. (though I'm not sure how far can that go, including too many templates won't be cool either)(09:02:02 PM) groundup: The theme should be able to include other template files. Kind of a huge limitation that it doesn't have that ability (since it would conflict)(09:03:03 PM) groundup: For instance, sharing the post template would be awesome(10:18:47 PM) emanuele: Make Post.template.php reusable it something I thought about(10:19:19 PM) emanuele: I think it is already mostly re-usable, you just need to set some predefined indexes in $context(10:19:33 PM) emanuele: (if that is what you mean )
Re: IRC Reply #261 – June 04, 2013, 01:12:06 pm (11:27:24 PM) emanuele: Post.controller.php is still pretty broken... :-S(11:57:16 PM) Norv: fix, file issues, please?(12:03:31 AM) ***emanuele is trying, but the code is still a bit...not very linear I think...(12:15:27 AM) Norv: that's the biggest problem :|(12:24:25 AM) Norv: Could we split the paths in the code some more, i.e. either in the direction of some action_drafts_save(), action_postreply(), either in the direction of some more prepareCalendarEvent() or so(12:24:46 AM) Norv: Any would help, because it disentangles the spaghetti. IMHO.(12:26:00 AM) emanuele: I think the biggest issue are not the "other things", but the several paths the normal action_post and action_post2 have to follow(12:26:24 AM) emanuele: normal post, quoted reply, preview from quick reply, post error, etc.(12:26:32 AM) emanuele: including all the mixes(12:26:36 AM) Norv: That sounds like the first direction... (12:27:27 AM) Norv: If we start off, even with some duplicate code at the beginning, but all organized for that case, action_preview_quickreply() for example, we will still see more benefit...(12:29:00 AM) Norv: I admit, last I checked and made changes, I was still doing the second (or even less, the move of queries kind-of-stuff)(12:29:20 AM) Norv: but maybe it's time to take the bull by them horns thingies.(12:30:30 AM) Norv: (or moose )
Re: IRC Reply #262 – June 08, 2013, 12:31:15 pm (12:46:15 AM) ***emanuele tries "like": "sorry this feature is disabled"(12:51:03 AM) Norv: Ah. Tis a core feature. But, I think that's a bug: shouldn't present 'like' if disabled, obviously.(12:51:38 AM) emanuele: (or maybe my install is simply broken... )(01:59:18 AM) elk_core: [Elkarte] emanuele45 opened pull request #491: Few fixes (master...few_fixes) http://git.io/CAs-fg(06:57:00 AM) groundup: https://github.com/gnif/SMF2.1/commit/22dd5430dd7b2e8062bfb79c9faa5b7c122da697(06:57:25 AM) groundup: Elk should do the same, but add methods for error and error number
Re: IRC Reply #263 – June 08, 2013, 12:31:32 pm (01:58:59 PM) elk_core: [Elkarte] norv pushed 11 new commits to master: http://git.io/ts0gdw(01:58:59 PM) elk_core: Elkarte/master 28d252e Spuds: ! Update/create draft autosaver as sceditor plugin...(01:58:59 PM) elk_core: Elkarte/master b1a7877 Spuds: ! update / simplify existing draft.js to only support the non editor quick reply...(01:58:59 PM) elk_core: Elkarte/master 7a13088 Spuds: ! update the functions to use the new plugin...(01:59:24 PM) elk_core: [Elkarte] norv pushed 5 new commits to master: http://git.io/lEHTwQ(01:59:24 PM) elk_core: Elkarte/master 5696bc1 emanuele: Undefined variable $first_subject...(01:59:24 PM) elk_core: Elkarte/master 0ee0eab emanuele: This seems useless......(01:59:24 PM) elk_core: Elkarte/master 97945aa emanuele: On-the-fly change of css to hide/show (jQuery), should work, not tested...
Re: IRC Reply #264 – June 08, 2013, 12:31:57 pm (06:22:10 PM) groundup: http://www.lornajane.net/posts/2013/php-version-adoption(06:22:54 PM) groundup: http://w3techs.com/technologies/details/pl-php/5/all(06:33:49 PM) elk_core: [Elkarte] eurich opened pull request #492: Green variant (master...green_variant) http://git.io/I0uIfw(08:32:48 PM) elk_core: [Elkarte] norv pushed 8 new commits to master: http://git.io/Q_UPWg(08:32:48 PM) elk_core: Elkarte/master cacf8f2 Thorsten Eurich: pagelinks style adjustments....(08:32:49 PM) elk_core: Elkarte/master c6b2f54 Thorsten Eurich: initial commit green variant....(08:32:49 PM) elk_core: Elkarte/master e4afd44 Thorsten Eurich: more adjustments, give themers some more ideas (webfont for title, moving unread links to a fixed top bar ...)...(12:02:33 AM) elk_core: [Elkarte] engelnyst opened pull request #494: Code clean-up and refactor (master...fixes) http://git.io/-ft-tw(09:01:12 PM) elk_core: [Elkarte] norv pushed 6 new commits to master: http://git.io/GD4sDg(09:01:12 PM) elk_core: Elkarte/master d837292 enyst: Code doc, spelling....(09:01:13 PM) elk_core: Elkarte/master 34f37d2 enyst: Emailpost controller as a class...(09:01:13 PM) elk_core: Elkarte/master 6fa7648 enyst: Fix constructor call...
Re: IRC Reply #265 – June 08, 2013, 12:32:43 pm (03:03:08 AM) elk_core: [Elkarte] norv opened pull request #497: Cherrypicks (master...cherrypicks) http://git.io/0PAhrw(05:20:09 PM) elk_core: [Elkarte] norv pushed 3 new commits to master: http://git.io/2nTg5g(05:20:09 PM) elk_core: Elkarte/master f1db8ac ziycon: Fix for quick reply off by default...(05:20:09 PM) elk_core: Elkarte/master 7e1c9d8 ziycon: Fix for theme files not copied over...(05:20:09 PM) elk_core: Elkarte/master b0a6549 Norv: Merge pull request #497 from norv/cherrypicks...(03:06:02 AM) TehCraw: Oh man, I thought somebody said something.(03:16:23 AM) Norv: lol. Code speaks (03:17:59 AM) TehCraw: Only to people who understand.(03:18:12 AM) TehCraw: You have to be one with the computer.
Re: IRC Reply #266 – June 08, 2013, 12:33:20 pm (08:39:17 AM) elk_core: [Elkarte] eurich opened pull request #495: theme fixes (master...tfixes) http://git.io/vlSOiA(02:32:55 PM) elk_core: Elkarte/master f8de243 Thorsten Eurich: prevent jumping menu items...(02:32:55 PM) elk_core: Elkarte/master 4806c43 Thorsten Eurich: missing semicolon (syntax error)...(02:32:55 PM) elk_core: Elkarte/master 9fe344d Norv: Merge pull request #495 from eurich/tfixes...(02:31:23 PM) elk_core: [Elkarte] emanuele45 opened pull request #498: What about hook the action? (master...hooks_again) http://git.io/L6cYng(08:21:21 PM) elk_core: [Elkarte] norv pushed 2 new commits to master: http://git.io/iv2aHg(08:21:22 PM) elk_core: Elkarte/master 485a96b emanuele: What about hook the action?...(10:26:04 PM) elk_core: [Elkarte] eurich opened pull request #499: HTML5 additions (master...theme) http://git.io/MjkbFA(12:16:16 PM) TimeVortex: Speaking of databases...(12:16:31 PM) TimeVortex: I noticed you guys are still using the mysql_* functions, as are SMF and Wedge(12:16:42 PM) TimeVortex: Those functions will be deprecated from PHP 5.5+(07:19:45 PM) emanuele: Performances question: how bad would be not to have the id_board column in {db_prefix}topics and have to LEFT JOIN another table instead?(07:22:24 PM) emanuele: (not that I intend to do it for boards, but I'm using something similar for tags and I would understand how bad that approach could be)(10:34:03 PM) emanuele: Norv, what's your opinion on things like this: http://pastebin.com/Jw1V2ttd(10:34:12 PM) emanuele: (i.e. static)
Re: IRC Reply #267 – June 08, 2013, 12:34:04 pm (10:07:37 PM) elk_core: [Elkarte] emanuele45 opened pull request #501: Broken query if using hooks (master...quick_fix) http://git.io/qILIhg(10:43:19 PM) emanuele: Norv: that's for you becaose I lost a bit track of where things have gone... lol(10:43:29 PM) emanuele: Fatal error: Call to undefined function action_groupmembers() in /sources/subs/Action.class.php on line 96(10:44:35 PM) emanuele: Never mind, I think I found it(06/08/2013 12:30:02 AM) emanuele: It's unbelievable the amount of duplicated code in SMF... xD(01:23:58 AM) elk_core: [Elkarte] emanuele45 pushed 6 new commits to master: http://git.io/qplh2g(01:23:58 AM) elk_core: Elkarte/master f0d1f0f emanuele: Broken query if using hooks...(01:23:58 AM) elk_core: Elkarte/master 2484dbe emanuele: Missing controller from subActions array in membergroups management...(01:23:58 AM) elk_core: Elkarte/master c0e881a emanuele: Missing require_once...
Re: IRC Reply #268 – June 08, 2013, 12:34:21 pm (12:41:41 AM) elk_core: [Elkarte] Spuds opened pull request #503: Replace shorten_subject (master...shorten) http://git.io/9rf0jA(01:18:28 AM) elk_core: [Elkarte] emanuele45 opened pull request #504: A function to render uniformly the "pagesection" (master...template_pagesection) http://git.io/IHPKbA(03:12:53 PM) Norv: emanuele: perhaps we can make a single patch with the merge conflicts in TE's various_fixes?(03:13:16 PM) emanuele: What you mean a single patch?(03:13:43 PM) Norv: a single commit, a patch/diff with the differences(03:14:55 PM) emanuele: ahhh....I suppose it's possible, TBH I didn't dig it, I just saw it was not merging and though it was because of my PR, so I went and checked... lol
Re: IRC Reply #269 – June 08, 2013, 02:14:50 pm Quote from: TestMonkey – June 08, 2013, 12:31:15 pmhttps://github.com/gnif/SMF2.1/commit/22dd5430dd7b2e8062bfb79c9faa5b7c122da697Apart from the horrible formatting, you mean?EDIT: And a bug. (mysqli_num_fields doesn't exist)Quote from: TestMonkey – June 08, 2013, 12:33:20 pm(12:16:16 PM) TimeVortex: Speaking of databases...(12:16:31 PM) TimeVortex: I noticed you guys are still using the mysql_* functions, as are SMF and Wedge(12:16:42 PM) TimeVortex: Those functions will be deprecated from PHP 5.5+Wedge is - but only because I haven't gotten around to changing it. Though now I hear it is being officially deprecated I will fix it.The big thing I hate about switching to MySQLi is that either things needs to be rewritten for OOP, or they need to be modified because the parameter order for half the procedural functions is a bit different.EDIT: And now it doesn't, it uses MySQLi.
Modern, Free, Powerful