ElkArte Community

Elk Development => Feature Discussion => Topic started by: emanuele on July 04, 2015, 05:01:19 pm

Title: enablePreviousNext
Post by: emanuele on July 04, 2015, 05:01:19 pm
Any objection removing the option and make it on by default?

QuoteEnable previous/next topic links
This will show a link to the next and previous topic.
Title: Re: enablePreviousNext
Post by: Burke Knight on July 04, 2015, 05:08:32 pm
(http://bkd.pw/bk_like.png)
Title: Re: enablePreviousNext
Post by: scripple on July 04, 2015, 06:18:50 pm
Yes.  I have it turned off.  What you want to see as next is too context sensitive.  Next in section?  Next in unread list?  I recall in SMF they didn't even honor the sorting of topics used before you started reading one.  I have start date based views of certain sections and the next / previous wouldn't honor those so it just made it odd.
Title: Re: enablePreviousNext
Post by: emanuele on July 05, 2015, 03:52:06 am
hmm... and any objections to remove it entirely and create an addon to replace it? O:-)
Title: Re: enablePreviousNext
Post by: Jorin on July 05, 2015, 06:12:22 am
I have it off too.  ;)
Title: Re: enablePreviousNext
Post by: Flavio93Zena on July 05, 2015, 11:58:49 am
Seeing reply #2 I'd say leave it ON by default and leave it that way, so an admin can disable it easily. I think most people will like to have it on, so it better stay that way. Don't really think you should add useless addons this time ;) (and, for people not knowing, I am one with a 140+ mods smf forum ;D)
Title: Re: enablePreviousNext
Post by: scripple on July 05, 2015, 12:00:07 pm
Quote from: emanuele – hmm... and any objections to remove it entirely and create an addon to replace it? O:-)
Why?  It works now.  Is this gnome where we want to keep removing choices and making people jump though hoops to get them back?
Title: Re: enablePreviousNext
Post by: emanuele on July 05, 2015, 02:06:07 pm
You said it doesn't work as expected. :P

I'm always asking about little stuff that looks not really worth an option, and if you (in general) tell me that it's not used (even more because it's unreliable), my reaction is "what you think about removing it?", just that. ;)
Title: Re: enablePreviousNext
Post by: scripple on July 05, 2015, 02:50:43 pm
Ugh.  Totally reversed what you were saying in my brain.  I mapped it to the addon allowing prev/next it to be disabled.  Sorry.  (No idea why I thought that as it sounds so silly.)

Yes I'm fine with the feature itself being an addon.
Title: Re: enablePreviousNext
Post by: Flavio93Zena on July 05, 2015, 03:00:28 pm
Quote from: scripple – Ugh.  Totally reversed what you were saying in my brain.  I mapped it to the addon allowing prev/next it to be disabled.  Sorry.  (No idea why I thought that as it sounds so silly.)
There's 2 of us then... #_#

Quote from: scripple – Yes I'm fine with the feature itself being an addon.
I'm not. Why removing a feature that can be easily switched on/off with no issues? Or why adding an addon for something you already have? Too much an hassle, and a step backwards IMHO.
Title: Re: enablePreviousNext
Post by: Burke Knight on July 05, 2015, 03:27:26 pm
It's called, reducing the Core product, for better simplicity, as well as size, loading, etc.
Title: Re: enablePreviousNext
Post by: Flavio93Zena on July 05, 2015, 03:30:05 pm
Reducing and cutting useful functions? A single function like this won't reduce nothing but a few bytes, not even kilobytes. Same applies for loading.
Sorry, won't change my mind after seeing what scripple said :)
Title: Re: enablePreviousNext
Post by: ahrasis on July 05, 2015, 06:54:15 pm
Quote from: emanuele – hmm... and any objections to remove it entirely and create an addon to replace it? O:-)
Agreed on this. I never see that as a very useful core feature.
Title: Re: enablePreviousNext
Post by: Joshua Dickerson on December 27, 2015, 04:07:34 am
So... verdict is yes, remove the option and make it default; leaving the themes to decide if they want a link? I think that makes sense and it is very easy to do in like 10 minutes. @emanuele ?
Title: Re: enablePreviousNext
Post by: Joshua Dickerson on December 28, 2015, 11:48:55 pm
Done: https://github.com/elkarte/Elkarte/pull/2333
Title: Re: enablePreviousNext
Post by: CrimeS on December 29, 2015, 11:33:34 am
That sounds like something that I needed.
Title: Re: enablePreviousNext
Post by: scripple on December 29, 2015, 11:57:17 am
I thought the conclusion was to remove the prev/next feature in general not the option to enable/disable it.  This has now effectively turned it on by default in the default themes.  What does previous/next mean?  It depends on the sorting order and context the person was viewing before they entered the topic.  Were they coming from unread posts?  The topic index of a board?  The forum index?  That was why I said it seems broken in general and thought Ema agreed.
Title: Re: enablePreviousNext
Post by: Eliana Tamerin on December 29, 2015, 02:40:55 pm
You don't even have it turned on by default here.

For my part, I don't really care about it too much. I never use them.
Title: Re: enablePreviousNext
Post by: Joshua Dickerson on December 29, 2015, 04:21:36 pm
@scripple, we could do that but this is in response to the first post.

If we did what you're suggesting, I think people would want a mod and I don't feel like making a mod. It's pretty simple to do, but that just means another repo and more stuff I'd have to track.
Title: Re: enablePreviousNext
Post by: scripple on December 29, 2015, 04:32:19 pm
Then just leave it how it is so it can be disabled.  As Eliana points out it's not even used here.
Title: Re: enablePreviousNext
Post by: Joshua Dickerson on December 29, 2015, 05:33:00 pm
I see the links. If you want to disable it, just remove it from the theme and nobody will use it.

I can remove it completely but I want to get an okay from @emanuele and @Spuds (and @TE if he's around)
Title: Re: enablePreviousNext
Post by: scripple on December 29, 2015, 06:21:36 pm
Now that you mention it scouring the page I see them up at the top of the page of posts on the light theme.  Figured they would be at the bottom as that's more likely when I would want to go to another post.  Either way I still vote for disabling it entirely or failing that leaving the option to disable them.
Title: Re: enablePreviousNext
Post by: Spuds on December 29, 2015, 08:07:37 pm
I guess it comes down to if we want to have it be "enabled" by an addon.

If so then the easiest would be to make it theme settings thing at the top of index.template.   I don't think there would be an easy way via addon to enable it in the default theme without that (it would however be easy to add in a custom theme).

Title: Re: enablePreviousNext
Post by: SpeedFreak on January 18, 2016, 10:13:04 am
This is a feature I use fairly often in many forums.

The only thing that worries me is if the addon is only maintained by a 3rd party. If its something produced and maintained by the elkarte team then go for it, rip it outta the core lol. Less is more :)