ElkArte Community

Elk Development => Bug Reports => Exterminated Bugs => Topic started by: HerrUU on February 04, 2017, 05:53:19 am

Title: BBcodes settings gone
Post by: HerrUU on February 04, 2017, 05:53:19 am
I keep getting the same problem, as soon as I install an addon that adds BBcode (like "inline attachments", "BBC font awesome",...) the settings in my admin panel dissapear :
(Link-4455)


and the buttons for these addons are not visible anywhere in the post editor :
(Link-4457)

How can I solve this?
Title: Re: BBcodes settings gone
Post by: Spuds on February 04, 2017, 09:24:54 am
Do the "new" BBC codes show up in the list when you un-check the "select all tags" in the ACP? 
Title: Re: BBcodes settings gone
Post by: emanuele on February 04, 2017, 12:30:31 pm
And do you have any other addon installed?
Title: Re: BBcodes settings gone
Post by: HerrUU on February 04, 2017, 01:52:26 pm
Just Emoji. The new bbcodes do not appear when I unselect. 
Title: Re: BBcodes settings gone
Post by: HerrUU on February 04, 2017, 02:29:40 pm
Ok, just did a re-install of the forum software and only installed Emoji. The settings in the admin panel dissapeared.

So I'm re-installing the software again but this time I'll leave the emoji addon away and just install inline attachments
Title: Re: BBcodes settings gone
Post by: Spuds on February 04, 2017, 03:17:46 pm
@emanuele found a bug with the font awesome addon (incorrect file case on the naming) .. I've made the update and published 1.0.2 on the addon site.   I'll take a look ath the Emoji addon as well and see if I made the same mistake.
Title: Re: BBcodes settings gone
Post by: emanuele on February 04, 2017, 03:44:00 pm
Could you try using one of the developer tools of the browser and see if the markup is completely missing or if it is just a display:none in CSS?
Never mind, it's not.

This is the elkarte's sub-optimal solution to store the bbc codes in parse_bbc and call the function with $message = false if only the codes are needed.
Then, Emoji::emojiNameToImage (https://github.com/Spuds/ElkArte-Emoji/blob/master/Emoji.integration.php#L33) doesn't return false, but an empty string and parse_bbc doesn't return the array of bbcode... :-\
Title: Re: BBcodes settings gone
Post by: HerrUU on February 04, 2017, 03:58:19 pm
Ok, dit some re-installing and testing (and re-installing :D ) and I think I identified the source of the issue. It's the Emoji addon that causes the problem.

First I did an install with only the emoji addon as an extra : poef, the settings for the bbcodes were gone. Next I re-installed the entire forum and first intalled another package (similar settings), that dit not break anything so I installed the Font Awesome addon. And that didn't break anything eather. So the issue is somewhere in the emoji addon.
Title: Re: BBcodes settings gone
Post by: Spuds on February 04, 2017, 04:18:12 pm
You know someone should keep an eye on that spuds guy ... adding && $message !== false to that line should fix that issue then.

Oh and looky, the BBC code list is mussed up, the class should be on the UL not the LI's
Title: Re: BBcodes settings gone
Post by: Spuds on February 04, 2017, 04:36:41 pm
Updated the Emoji addon and pushed the update to the addon site ... thanks @emanuele for that debug :D
Title: Re: BBcodes settings gone
Post by: HerrUU on February 05, 2017, 05:47:44 am
Works like a charm now.

Thanks for the swift follow-up! You guy's are great :)