ElkArte Community

Elk Development => Bug Reports => Exterminated Bugs => Topic started by: ahrasis on February 04, 2017, 08:04:50 am

Title: The Same Old Package Manager Bug
Post by: ahrasis on February 04, 2017, 08:04:50 am
The same old package manager bug is found in the latest (newly introduced) PackagesFilterIterator.class.php 1.1 RC 1:
Code: [Select]
if (!($current->isDir()) && file_exists($current->getPathname() . '/package-info.xml'))

The error is the same as mentioned before (http://www.elkarte.net/community/index.php?topic=4083.msg29267#msg29267)  i.e. file_exists(): open_basedir bla bla bla... and it is definitely not a server fault, again. :P The fix is as mentioned before (http://www.elkarte.net/community/index.php?topic=4083.msg29267#msg29267) too i.e. the bracket:
if (!($current->isDir() && file_exists($current->getPathname() . '/package-info.xml')))

Title: Re: The Same Old Package Manager Bug
Post by: Spuds on February 04, 2017, 09:11:52 am
Ha, now I get to blame @emanuele  :D
Title: Re: The Same Old Package Manager Bug
Post by: emanuele on February 04, 2017, 12:34:18 pm
/me blames... heck I guess I can' t find anyone else to blame! LOL
Title: Re: The Same Old Package Manager Bug
Post by: ahrasis on February 05, 2017, 01:15:14 am
I made a PR for this to ease you guys work over there.

There is another PR for repair_settings.php too, for consideration, though the same still do not work in 1.1, but a reference for future modification is posted in the said PR.