Text only | Text with Images

ElkArte Community

Elk Development => Bug Reports => Exterminated Bugs => Topic started by: emanuele on December 17, 2012, 11:32:52 am

Title: [bug] - moved marked as "new" even after click on them
Post by: emanuele on December 17, 2012, 11:32:52 am
Sort of regressions: I thought I fixed this quite a long time ago...
Title: Re: [bug] - moved marked as "new" even after click on them
Post by: Antechinus on December 17, 2012, 02:07:01 pm
You probably did. :D
Title: Re: [bug] - moved marked as "new" even after click on them
Post by: Spuds on December 17, 2012, 02:36:30 pm
Should be easy to fix again then  8)
Title: Re: [bug] - moved marked as "new" even after click on them
Post by: emanuele on December 17, 2012, 02:40:33 pm
Quote from: Antechinus – You probably did. :D
But not hard enough... :P

/me feels it's Spuds fault.
Title: Re: [bug] - moved marked as "new" even after click on them
Post by: Spuds on December 17, 2012, 02:41:26 pm
I'll take the blame as long as you fix it :P
Title: Re: [bug] - moved marked as "new" even after click on them
Post by: emanuele on December 17, 2012, 03:02:21 pm
I have already 17 branches... (and this will be the 18th)
/me hates git.
Title: Re: [bug] - moved marked as "new" even after click on them
Post by: emanuele on December 17, 2012, 03:13:35 pm
I think this should work:
Code: [Select]
	// Is this a moved topic that we are redirecting to?
	if (!empty($topicinfo['id_redirect_topic']))
	{
		markTopicsRead(array($user_info['id'], $topic, $topicinfo['id_last_msg']), $topicinfo['new_from'] !== 0);
		redirectexit('topic=' . $topicinfo['id_redirect_topic'] . '.0');
	}
in Display.php about line 133
Title: Re: [bug] - moved marked as "new" even after click on them
Post by: Antechinus on December 17, 2012, 03:28:06 pm
Quote from: emanuele – I have already 17 branches... (and this will be the 18th)
/me hates git.
Join the club. Git is a total PITA.
Title: Re: [bug] - moved marked as "new" even after click on them
Post by: TestMonkey on December 17, 2012, 04:01:52 pm
Quote from: emanuele – I have already 17 branches... (and this will be the 18th)
/me hates git.

23... with more than 1/2 with a single theme...  ::)
Title: Re: [bug] - moved marked as "new" even after click on them
Post by: TestMonkey on December 17, 2012, 04:10:22 pm
Quote from: emanuele – I have already 17 branches... (and this will be the 18th)
/me hates git.

Hey! It's Smart (tm): look, it didn't even blink, when I committed your fix (couple minutes ago (https://github.com/Spuds/Dialogo/commit/391d9ec84c57c2aa379900ed71dee0ee596f2a97)) and then merged your PR with it again. :D
Smart git is smart. :P
Title: Re: [bug] - moved marked as "new" even after click on them
Post by: emanuele on December 17, 2012, 04:29:50 pm
60 in SMF repo... (most of them I don't even know why I create the branch)
I should really delete some of them... LOL
Text only | Text with Images