ElkArte Community

Elk Development => Feature Discussion => Exterminated Features => Topic started by: Burke Knight on June 11, 2015, 12:47:33 pm

Title: Mentions in Quick Edit
Post by: Burke Knight on June 11, 2015, 12:47:33 pm
Would appear that mentions done in the quick edit, do not work.
Will not do pop up of member name while typing it, now will make it a mention when save.
Title: Re: Mentions in Quick Edit
Post by: emanuele on June 11, 2015, 01:29:42 pm
Yes, know issue.
Actually is sort of intended to work like that, in the sense that the quick edit was considered a "quick way" of fixing minor things, though I agree that one in particular is a bit annoying.
I think it should be possible to attach the relevant code "somehow".
Title: Re: Mentions in Quick Edit
Post by: emanuele on June 11, 2015, 05:17:08 pm
Tracked: https://github.com/elkarte/Elkarte/issues/2098
Title: Re: Mentions in Quick Edit
Post by: Spuds on June 12, 2015, 09:25:08 am
Agreed, that one in particular is a bit annoying.  Most of the other annoyances with QE clear on a page refresh, but mentions just don't work, so adding that would be  8)
Title: Re: Mentions in Quick Edit
Post by: emanuele on July 25, 2015, 05:29:48 pm
Fixed here: https://github.com/emanuele45/Dialogo/commit/916d67118a824463607330aabb18090507089750
Title: Re: Mentions in Quick Edit
Post by: Flavio93Zena on July 25, 2015, 06:43:42 pm
That needed quite a bit of code from what I can see, nice work!
Title: Re: Mentions in Quick Edit
Post by: emanuele on July 26, 2015, 03:53:06 am
TBH less than I thought, even though I took the path of duplication.
Title: Re: Mentions in Quick Edit
Post by: Flavio93Zena on July 26, 2015, 09:06:43 am
It would have been stupid not to do it if it's possible xD
Title: Re: Mentions in Quick Edit
Post by: emanuele on July 26, 2015, 09:12:22 am
Well, the best path is reuse, not duplication. ;)
Title: Re: Mentions in Quick Edit
Post by: Flavio93Zena on July 26, 2015, 11:15:43 am
"Don't fix it if it's not broken", too :P
Title: Re: Mentions in Quick Edit
Post by: emanuele on July 26, 2015, 11:37:58 am
hmmm... no, that's BS for two reasons:
1) any thing is broken one way or another,
2) if you don't break you cannot build something better. ;D
Title: Re: Mentions in Quick Edit
Post by: Flavio93Zena on July 26, 2015, 12:00:18 pm
LOL you'll never change ;D