Print Page - index.english.php => line jumper

Title: index.english.php => line jumper
Post by: wintstar on December 19, 2015, 07:55:26 am

index.english.php => line jumper #issue 2317 (https://github.com/elkarte/Elkarte/issues/2317)
(https://github.com/elkarte/Elkarte/issues/2317)

Code: (php) [Select]

$txt['splittopic_default'] = 'One or more of the messages of this topic have been moved to [BOARD]

[TOPIC LINK]';

Ought to be in a row

Code: (php) [Select]

$txt['splittopic_default'] = 'One or more of the messages of this topic have been moved to [BOARD] - [TOPIC LINK]';

Title: Re: index.english.php => line jumper
Post by: emanuele on December 19, 2015, 08:24:06 am

Is there a specific reason for this request?
I think a dot is missing after "[BOARD]", though I don't dislike having the topic link on the new line, it is the same structure of the "move notice" after all.

Title: Re: index.english.php => line jumper
Post by: Burke Knight on December 19, 2015, 11:41:44 am

To me, it looks better, topic on new row. Keep it that way, please. :)

Title: Re: index.english.php => line jumper
Post by: wintstar on December 19, 2015, 12:08:13 pm

Code: (php) [Select]

[TOPIC LINK]';

[/pre]
This is only after a blank line and that's what I mean. In my opinion I think that this is, either in a row with

Code: (php) [Select]

$txt['splittopic_default'] = 'One or more of the messages of this topic have been moved to [BOARD]

or without blank line comes directly under it.

Title: Re: index.english.php => line jumper
Post by: Flavio93Zena on December 19, 2015, 01:49:23 pm

Useless empty line, indeed. I like it more on a single line as well, but apparently it's just you and me ;D

Title: Re: index.english.php => line jumper
Post by: Burke Knight on December 19, 2015, 02:19:32 pm

Are you meaning, replace this:

Code: [Select]

$txt['splittopic_default'] = 'One or more of the messages of this topic have been moved to [BOARD]

[TOPIC LINK]';

With this, removing the blank line?

Code: [Select]

$txt['splittopic_default'] = 'One or more of the messages of this topic have been moved to [BOARD]
[TOPIC LINK]';

That, yes, I can agree with, although, it really makes no difference.

EDIT:

Wait a minute... I just thought of something, that none of use did before. That would not cause a line break, as there's no code for one, meaning, no
.

Means, what @emanuele and I commented on before,

Quote from: emanuele – December 19, 2015, 08:24:06 amhaving the topic link on the new line, it is the same structure of the "move notice" after all.

Is not actually caused by the space, and combining it in one line, should not have the previously thought effect.

Title: Re: index.english.php => line jumper
Post by: emanuele on December 19, 2015, 04:49:44 pm

Sorry, but you lost me.
I'm pretty sure it's because I'm sleeping right now, so I'll read again everything tomorrow morning. O:-)

To explain better what I mean with the sentence Burke Knight quoted:

Code: [Select]

$txt['movetopic_default'] = 'This topic has been moved to [BOARD]

[TOPIC LINK]';

Code: [Select]

$txt['splittopic_default'] = 'One or more of the messages of this topic have been moved to [BOARD]

[TOPIC LINK]';

The two notices have the same structure (in fact, to create splittopic, I just copied movetopic and changed the text.

Either way, I don't really care that much what the structure is, as long as it is consistent, so if one is changed I'd like to see the other changed as well.

Title: Re: index.english.php => line jumper
Post by: Flavio93Zena on December 20, 2015, 09:15:38 am

Yeah sure consistency doesn't matter I think we all agree on that (it needs to be the same), what we are talking about is which consistency to apply :P

Title: Re: index.english.php => line jumper
Post by: wintstar on December 20, 2015, 09:27:43 am

I noticed the blank line. That was it, for this post and Issue.

ElkArte Community

Elk Development => Feature Discussion => Topic started by: wintstar on December 19, 2015, 07:55:26 am