Print Page - ssi_boardNews(); doesn't show news title

Title: ssi_boardNews(); doesn't show news title
Post by: Adrek on September 09, 2014, 05:09:45 am

You can see it even here: http://www.elkarte.net/community/ssi_examples.php
Find ssi_boardNews and click on it - news title is missing, for this one I did not found solution yet.

I guess I will find more SSI bugs, because I'm makin homepage with it ::)

/edit:

Not sure if it's correct way to 'fix' this, but title is visible after this one edit in SSI.php:

Code: (Find) [Select]

$row['body'] = $row[$preview . '_body'];

Code: (Add after) [Select]

		$row['subject'] = $row[$preview . '_subject'];

Title: Re: ssi_boardNews(); doesn't show news title
Post by: emanuele on September 09, 2014, 07:45:22 am

Yep, correct fix... thanks! ;D

/me should pay more attention on refactoring and code replacement.

Title: Re: ssi_boardNews(); doesn't show news title
Post by: Spuds on September 09, 2014, 10:15:48 am

Tracked https://github.com/elkarte/Elkarte/issues/1804

Title: Re: ssi_boardNews(); doesn't show news title
Post by: Adrek on December 02, 2014, 05:18:15 pm

It's not worth to open new topic, so here's another line that needs change in this function:

Now ssi_boardNews is using member name as author name. It should be display name, so:

Code: (Find) [Select]

$row['poster_name'] = $row[$preview . '_member_name'];

Code: (Replace with) [Select]

$row['poster_name'] = $row[$preview . '_display_name'];

Title: Re: ssi_boardNews(); doesn't show news title
Post by: emanuele on December 02, 2014, 05:25:49 pm

Thanks!
Pushed: https://github.com/emanuele45/Dialogo/commit/c829fe8a07e71aa2b8508b54ea02bf74956a5d7f

Title: Re: ssi_boardNews(); doesn't show news title
Post by: Adrek on January 10, 2016, 04:42:10 pm

somehow 1.0.6 still has first bug (with wrong subject row), but now this:

Code: [Select]

$row['subject'] = $row[$preview . '_body'];

should be changed to:

Code: [Select]

$row['subject'] = $row[$preview . '_subject'];

I think that something went wrong here https://github.com/emanuele45/Dialogo/commit/437ed6a6fa08b7358706cf3615140f44bcea8799 ::)

Title: Re: ssi_boardNews(); doesn't show news title
Post by: emanuele on January 10, 2016, 05:47:07 pm

I reopened the bug.
Actually it was never fixed...

Title: Re: ssi_boardNews(); doesn't show news title
Post by: Flavio93Zena on January 11, 2016, 09:17:43 pm

@emanuele #MoveRequest until fully fixed?

Title: Re: ssi_boardNews(); doesn't show news title
Post by: emanuele on January 15, 2016, 05:25:07 am

No need, it's already tracked at github.

ElkArte Community

Elk Development => Bug Reports => Exterminated Bugs => Topic started by: Adrek on September 09, 2014, 05:09:45 am