Text only | Text with Images

ElkArte Community

Project Support => Support => Topic started by: Ruth on March 09, 2018, 04:03:32 pm

Title: Patch to 1.1.2
Post by: Ruth on March 09, 2018, 04:03:32 pm
I have tried to install the patch in my testforum today and did not continue.

It was looking like this:

(Link-5637)

Wy are there the same files, for example the load.php, 3 times to see?
And the last "replace" of this file will fail again?
Title: Re: Patch to 1.1.2
Post by: emanuele on March 09, 2018, 05:27:02 pm
Quote from: Ruth – Wy are there the same files, for example the load.php, 3 times to see?
Each line is a different change that is applied to the file (it has always been like that since... as long as I can remember ;) )

Quote from: Ruth – And the last "replace" of this file will fail again?
Could it be you already applied some of these changes in some support topic in order to fix some bug?
Title: Re: Patch to 1.1.2
Post by: ahrasis on March 09, 2018, 07:52:15 pm
If any of your addons did not change any other affected files, i.e. you modified manually earlier, simply copy the same files from 1.1.2 install zip and overwrite your current one after running that patch.

I normally will overwrite all rather than one by one as it is faster but I will remove the install folder from the install zip first and some images like favicon and mobile.png. It's faster (and I think it's safer too) this way.
Title: Re: Patch to 1.1.2
Post by: Ruth on March 10, 2018, 01:17:12 am
Quote from: emanuele – Each line is a different change that is applied to the file (it has always been like that since... as long as I can remember ;) )

I did not know that, Emanuele. O:-) 
The patches from SMF and ElkArte I did by myself until now, were all without any "failed" tests and files to replace.
If there were any problems in the past during an update, somebody was helping me with it, I never did it by myself.

Quote from: emanuele – Could it be you already applied some of these changes in some support topic in order to fix some bug?
Yes, I made all the changes in the files you wrote to me here (https://www.elkarte.net/community/index.php?topic=4888.msg35714#msg35714) and that one (https://www.elkarte.net/community/index.php?topic=1399.msg35511#msg35511) for the login in portal.

On my screenshot it concerns only these three files: Load.php, ManageThemes.controller.php and Attachments.subs.php
Any other files are showing "Test successful" in paket manager.

I am not sure, that I understood you well, Ahrasis:

I shall do the update now with the paket manager and afterwards I shall use those three files from the 1.1.2 install zip to overwrite those files again?

Or shall I don't use the paket manger and only overwrite those three files? ( I think, I should do this one?)

I am really afraid to do something wrong. O:-)
Title: Re: Patch to 1.1.2
Post by: emanuele on March 10, 2018, 02:33:59 am
Hmm... I wonder about attachments.
Do you have addons installed?
If so, which ones?
Title: Re: Patch to 1.1.2
Post by: Ruth on March 10, 2018, 02:56:00 am
 SimplePortal 1.0.0 RC1 ...nothing else

I did this change in Attachments.subs.php you wrote to me (bzw. on git hub) ...maybe I did something wrong there? O:-)
Title: Re: Patch to 1.1.2
Post by: emanuele on March 11, 2018, 09:28:59 am
Oh, okay, then you probably already have these changes in your install and that's the reason it gives you an error.
I would suggest to just install the patch even with the errors.
Title: Re: Patch to 1.1.2
Post by: Ruth on March 11, 2018, 03:35:44 pm
Okay....I did it now...  ;)  and everything seems to be okay.

Thank you both, Ahrasis and Emanuele!
Title: Re: Patch to 1.1.2
Post by: emanuele on March 11, 2018, 04:14:40 pm
/me waits for the forum to explode. ;D
Text only | Text with Images