I did a quick refresh to the site this PM, should be current with the github repo.
Let me know if I missed something (did this as an incremental which means I sometimes miss some things O:-) ).
Something is broken in mentions... :(
Well thats why we update the site, to see what we broke :)
Something going on with the page layout as well, the topic "header" is very large
Looks like a firefox-only bug, due to the white-space: nowrap I suggested to fix the admin area: https://github.com/elkarte/Elkarte/issues/1202
That seems to work:
https://github.com/emanuele45/Dialogo/commit/297ae3209ed85cb6ac42167e54c8aa8ebb5023a0
Looking at that area of css, it seems that:
.windowbg.nopadding {
margin: 4px 0 0 0;
padding: 0;
}
is not used any more (I can't find any nopadding class).
And also:
h3.category_header form {
font-size: 80%;
}
seems not necessary, but I'm not 100% sure.
Yup and Yup ... I'd say remove those two sections, I can't find them used anywhere now.
Did another bump this PM to fix some some bugs we found with the last update ... May have to refresh your cache to get all the changes. The new variant should also be available now :)
I don't know if it is a site theme thing or what but those giant avatars on the boardindex are really distracting.
On another note, I think you should advertise the Git repo more. Like a Github icon in the footer. Link to the repo in "This is a list of the awesome people who have contributed to ElkArte on Github."
Typo on home page: "BSD-3clause" "BSD 3-clause" and you should link to the license there.
Be sure and clear your browser cache, we made some theme css adjustments, including a new variant, seems like there is some cache confusion. Also seems the variant swapping does not quite work without a browser cache clear.
Thanks, I'll see what we can do, we have it in a few places (redirect board, and a news item), but never hurts to add a few more.
yeah, I see those avatars on index. but following Spuds instruction to reload (CTRL+F5) without cache it's gone. :)
beta 2 is close then :D
edit:
I'm using be social but the result is strange... still WIP?
huh, that's probably a Caching issue or ... that's a mixture between the classic theme and the new "be Social!".. I can reproduce it as well, my local Version is completely different.
Edit: seems "clear file cache" from the maintenance tasks fixed it partially. Board index is good now, but the Display template is still a mixture.
Edit: seems like a bug in the caching engine, I now see a mixture with mostly "be social" and some small parts of the old light variant.
@Spuds: I've temporary disabled caching on this site, seem to have fixed those mixture.
Note: Just in order to get some Feedback / bug reports I have set the new "Be Social!" Variant to default.
like buttons have a z index that makes them show on top of the fixed menu.
Fixed menu in mobile is four lines. Takes up half the screen and there's no compensatory margin at the top.
Profile link (eg variant selector) is unavailable on mobile (also with previous variant). Making it impossible to change back.
Mobile: clicking a user name next to a post does nothing. No menu, no linking.
Relative time is off by 9 hours for me. I tried changing it last week to no avail.
I was going to report the z-index thingy but I've been beaten! :P
ETA: the z-index is not only the like, but also the quote and the new topic.
I'd say that the text of the buttons is a bit smallish...
And (but that is an Elk bug) when there is a new reply the subject of the topic in the linktree is empty! (Darn how many times do we have to fix that one?!?! :o :P)
Another general remark: I'm tempted to say let's cut down "next page" and"previous page" to "next" and "previous". Maybe add a "first" and "latest"? (Or maybe not :P).
The 9 hours is odd... I'm off too, but I'm not exactly sure why, since it should be using the time from the server for the comparison... it seems I have to do some more tests. :-\
AHA!
Got it: the hours is just a cache issue with the cached js files that are still old "somewhere". (We (<= to be read as Spuds :P j/l) should do something about that :P)
Feedback on the theme: the expand doesn't really fit there (TBH it doesn't really fit into the code menu in any way apart from the logical reason it was put there), it looks like it's an expand for the profile menu when instead is doing something completely different.
Honestly...I'd be tempted to say let's remove it and keep a setting somewhere in the look&layout.
In the past there was a reason to have it handy (it was hiding some quite useful things like quick search and the unreads, but now it's hiding just the header of the forum and the news block.
oh my, so many bugz ;D We might need to call the pest controller :P
I'll take a look.. that z-index bug is a funny one, didn't notice it before.
If it helps you feel better, on chrome mobile I tend to get z-index issues on items without it set (!), behind position fixed elements. And that's down to the fact that they're set to half opacity. No kidding. If I reset opacity, then they won't overlap.
Plus chrome used to give me a huge opacity animation bug when children items were using 3d transforms. So much fun. I think they fixed it a couple days ago.
Was thinking:
.linktree::after {
[...]
box-shadow: -1px 0px 2px 0px #EEEEEE;
[...]
}
a tiny shadow to the back of the linktree arrow... dunno. O:-)
re Buttons: all of them or just some?
re next page: what about simply using << and >> for that?
The "normal_buttons" and moderation buttons and alike.
Dunno about the << >>, mixed feeling, I like the text, but seems too verbose at the moment.
Also the highlight is a bit... extreme. :P
Another small report: the icons in the title boards are a bit too tall (at least on linux, but I had problems with them being too short with the other variant, so... )
I'm guessing that is one of the same issues I just reported with IE8, its a font issue. The font stack we use may not be the best, or the fact that we drive some heights with em, or a combination of the two.
I'm almost thinking we should ditch the font stack for the nix stuff and use something like
@font-face {
font-family: "Open Sans";
font-style: normal;
font-weight: 400;
src: local('Open Sans'), local('OpenSans'), url(http://themes.googleusercontent.com/static/fonts/opensans/v7/cJZKeOuBrn4kERxqtaUH3T8E0i7KZn-EPnyo3HZu7kw.woff) format('woff');
}
Then we update the body stuff as
body {
margin: 0;
padding: 0 0 0 0;
font: 87.5%/150% "Segoe UI", "Helvetica Neue", "Open Sans", "Liberation Sans", "Nimbus Sans L", "Trebuchet MS", Arial, sans-serif;
}
or do everyone and just leave an ie8 fallback
body {
margin: 0;
padding: 0 0 0 0;
font: 87.5%/150% "Open Sans", "Trebuchet MS", Arial, sans-serif;
}
Have not played around with @ font-face much, so may need to add bold/italic in that as well. Anyway point is at least we would know what we are dealing with. One of the problems with nix is the fonts available on the different distros really vary, we could add in some other common nix ones as well, that may help. Out of curiosity what font face is your browser using for this?
I don't like how the menu is pushed all the way to the left and the profile pushed all the way to the right. I usually keep my browser full width lately, and that is a long ways away. lol Can we push the menu to be on the borders of the main body to see how that looks?
I think previous and next looks better too as ema pointed out.
yep, I've already fixed it on my local repo.. PR is in progress.
Thanks for removing the caching, TE. Hard refreshed anyway.
Everything looks much better. I like this new style.
Maybe the page numbers could use some white space between them so that when you hover over them they don't touch?
yep, definitely. Thanks for the report. fixed my local repo.
Nope, they didn't. Not fun...
If anyone has an idea on why this happens.
How to reproduce: http://wedge.org/do/media/?sa=item;in=194;sort=0 (random image in my gallery.)
Make sure the '?' icon in the info bar is visible to you without scrolling down. (If it isn't, try to collapse the page header.)
Click it. Background issue shows up. Dismiss. Scroll now a few. Click it. Background issue fixed. Funny, eh..?
PS: on desktop, this new theme looks both a bit immature (like it's in need of weeks of work to be cleaner), and way better than the previous it's-so-easy-being-green theme. I'm very close to being jealous, but I'm not unhappy with my current work either, so... :P
I can only confirm that this doesn't occur on desktop (right offset), but reproduced it on mobile just now ('posted 9 hours ago', sure... Where did the last 9 hours go?!)
And yeah, I'll double-post and even triple-post if I want. You can always install
Wedge here if you want to soft-merge or even hard-merge my messages... :-X O:-)
Not sure what you mean with "huge", but in Chrome looks fine here (31 linux).
Where did you park the Tardis? :P
TBH I'm not much a fan of merging, I'm more a fan of splitting... (not joking, it's a while I'm trying to think a way to split a message "nicely" in order to then split topics "cleanly") O:-)
Nice new theme. I like the old one, but this looks more suitable for software support.
Bug I found, though, is that there's no link back to the main portal/home page from the community site.
Bumped the site rev again, now with moar fixes !
Great, still found some bugz but we're getting closer now:
https://github.com/elkarte/Elkarte/issues/1232 :o ;D
Edit: oh my god, that list is long :D
I still can't get back to the homepage without manipulating the URL in the address bar. I can haz link?
Why do you want to come back to the home page when you are in this wonderful community? :D
Download link is on the main page. If I'm not a developer, it doesn't make sense to me to try the Github link to find the download.
Damn you and your logic :P Suggestions where to put the link? We could change the link on the ElkArte name up in the header?
Also I bumped the site to the latest repo again, trying to keep it in sync !
I know, I'm just that damnable. Why not a link to the left of Community in the top menu? I don't suppose it really matters much where you put it (as long as it's not like vBulletin's tiny link in the bottom-right hand menu), just so long as a link exists.
Not sure where are tracked
@TE so I'll post it here... :P (that is also a test for a thing I didn't consider)
There is a 1px or so area (see the pointer position) that highlights the area around the avatar. ;)
ETA: also if there are "many" smiley in the popup window it is cut "after a while" (see the attachment, the upper part of the smiley have a white background, while the lower half is transparent). TBH I have no idea why since the container is the same (a big <div>). Also there is another issue: it should have a max-height otherwise it can go outside the window.
ETA2: also thinking about it the window should be resizeable...if at all possible, dunno, have to check.
Something I've noticed that has started to bug me, when clicking a link that takes you to a specific post, the top part of the message is cut off. Leaving the subject, reply number, and username out of view. Can we move the anchor?
Another small thing... can you "add back" the fixed height for the news section?
It's annoying when the page jumps up and down...
yep, will check this (and the other reported issues) soon.
@emanuele is that smiley popup bug in both variant or just in the new one? I'm no able to reproduce, tested with smileys in six rows..
The others have been fixed.
MOAR!!
You need moar smiley!!
Put all of them (15 rows) one under the other and you will see the but on the last smiley. ;)
LOL, 15 rows :D I'll check it again ..
15 rows of small smiley, but if you use big ones O:-)
On my site I have something like 100 in total, so they creates new lines because of the width. ;)
that's a "bug" in jquery.sceditor.css
the class .sceditor-smileyPopup {} is currently set to max-height: 50%; , that needs to be increased to 80% (or more), depending on the rows...
Great catch TE!
It may be useful also an overflow somewhere, so that if the smiley are many the window will not grow bigger than the screen?
That's probably true for both variants: the locked icon (and probably others as well) overlaps the number in the search results page.
...but... BTW, why do we have those numbers?
Dunno if it is already in some other fix, I noticed today the droppy of the members search is transparent. :)
ETA: Scratch the above, I have to fix other things on that droppy, so I'll just add the background unless is already somewhere else. O:-)
@Eliana Tamerin or anyone that wants to put the mod together! :D
Attached the two files, the hook is:
integrate_menu_buttons
the function:
add_home_menu
the package-info code for the hook should look like:
<hook hook="integrate_menu_buttons" file="SOURCEDIR/subs/HomeBtn.subs.php" function="add_home_menu" />
the file for the language is a bit overkill, but... :P
Not tested, but I think this should work. :)