Skip to main content
Topic: getRecentPosts VS getLastPosts (Read 6092 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

getRecentPosts VS getLastPosts

I was looking around and I found these two functions.

They are pretty much the same (sort of), but one is used cached for BoardIndex, the other is used in action=recent.
One grab a bunch of previously filtered id_msg, the other relies on its list of JOINs.

I was thinking it may be worth merging the two, move the "pre query" (still) done in the controller to the function and use it if $_REQUEST['start'] > 0.

What do you think?
Bugs creator.
Features destroyer.
Template killer.

Re: getRecentPosts VS getLastPosts

Reply #1

I'm generally in favor of consolidating things like that ... poor "recent" is like the step child, can't remember how many times I've had to go back and add in the same things we did for display etc (or fix the same bugs) O:-)

Re: getRecentPosts VS getLastPosts

Reply #2

lol

Okay, can be done even after beta 2 I think (it's not such a big issue and should not create big problems).
Bugs creator.
Features destroyer.
Template killer.