Themes.php question
I'm refactoring Themes.php right now and need some input:
1) There are methods named action_edit_style, action_edit_, action_edit_template... These are mainly forwarders for action_edit();
I'd make them private, but would need some feedback regarding method names..
simply _action_edit_style, or _edit_style?
2) prepareThemeEditContext() is currently a function and is doing prechecks for action_edit()..
Question: move it to subs or make it a private method of the Themes_Controller?
Re: Themes.php question
Reply #3 –
activate button? Sorry, I need to see the code, I'm afraid I'm not following well enough otherwise: I think it makes sense to be the same, but why is it a problem?