ElkArte Community

Elk Development => Bug Reports => Exterminated Bugs => Topic started by: d3vcho(); on August 03, 2017, 06:18:33 am

Title: GitHub icon a bit ahead of the rest
Post by: d3vcho(); on August 03, 2017, 06:18:33 am
(https://i.gyazo.com/94e16ea0f1e11878471569865f9df4a2.png)

That's it. The GitHub icon on profile is a little bit ahead of the rest.

Edit: It also happens in the nick hover
Title: Re: GitHub icon a bit ahead of the rest
Post by: Frenzie on August 03, 2017, 08:48:14 am
Looks like the others are SVG and that one a traditional PNG image. One potential solution is a vertical-align: text-top on the relevant style.
Title: Re: GitHub icon a bit ahead of the rest
Post by: d3vcho(); on August 03, 2017, 09:35:27 am
Yup, that makes it
Title: Re: GitHub icon a bit ahead of the rest
Post by: Spuds on August 03, 2017, 09:37:51 am
I'll track it so we fix in int rc2 .... Seems like we can add a generic adjustment to cf-icons to fix or minimize the issue.  Thanks for the report.
Title: Re: GitHub icon a bit ahead of the rest
Post by: emanuele on August 12, 2017, 07:56:35 am
I was looking at this, but I can't figure out how to do it in a general way, I guess I?ll wait for Spuds. O:-)
Title: Re: GitHub icon a bit ahead of the rest
Post by: Spuds on August 12, 2017, 10:27:34 am
Gave it a shot here: https://github.com/Spuds/Elkarte/commit/cd082079798b0ccefcb41f5f4ab42097da34b644

We have/had some pretty deep selectors in play, so removed some of that and added a lower class to target.