I'm done with my translation. Yay! :D
But: In some template files some punctuation marks are hardcoded and can not be find in the language files. This leads to an unconsistent appearance in the user profile. Here's an example of
ProfileOptions.template.php:
<strong>', $txt['primary_membergroup'], ': </strong><br />
The ":" after the text string should be part of the string ElkArte takes out of the language file! Because some fields in the profile have now a ":" and some not, but this can't be repaired in the language files. See the attachment please.
So please, rewrite these template files!
Yes, that should be done for 1.1, for sure.
Do it at this moment can lead to inconsistencies in other places because strings may be reused. ;)
Really? If this is not planned for 1.0 I will give it a try and fix this for myself anyway. No hard feelings but many of my members look into their profile a lot and I want to offer them the best experience possible.
If you need any hint/help feel free to ask. ;D
And of course, if when you have finished, you want to share your changes, you are welcome! 8)
No help needed, did it already. But thanks! :)
All changes must be made in only ProfileOptions.template.php. I can tell all the exact positions and what to replace if anyone wants to do this as well. If not, I spare me this work. ;)
Okay, here are the changes to get rid of all the colons in the template file:
In
ProfileOptions.template.php search for:
<strong>', $field['name'], ': </strong><br />
Replace with:
<strong>', $field['name'], '</strong><br />
Search for:
<strong', isset($context['modify_error']['bad_password']) || isset($context['modify_error']['no_password']) ? ' class="error"' : '', '><label for="oldpasswrd">', $txt['current_password'], ': </label></strong><br />
Replace with:
<strong', isset($context['modify_error']['bad_password']) || isset($context['modify_error']['no_password']) ? ' class="error"' : '', '><label for="oldpasswrd">', $txt['current_password'], ' </label></strong><br />
Search for:
<label for="pm_settings">', $txt['pm_display_mode'], ':</label>
Replace with:
<label for="pm_settings">', $txt['pm_display_mode'], '</label>
Search for:
<label for="calendar_start_day">', $txt['calendar_start_day'], ':</label>
Replace with:
<label for="calendar_start_day">', $txt['calendar_start_day'], '</label>
Search for:
<label for="notify_regularity">', $txt['notify_regularity'], ':</label>
Replace with:
<label for="notify_regularity">', $txt['notify_regularity'], '</label>
Search for:
<label for="notify_types">', $txt['notify_send_types'], ':</label>
Replace with:
<label for="notify_types">', $txt['notify_send_types'], '</label>
Search for:
<strong>', $txt['primary_membergroup'], ': </strong><br />
Replace with:
<strong>', $txt['primary_membergroup'], ' </strong><br />
Search for:
<strong>', $txt['additional_membergroups'], ':</strong>
Replace with:
<strong>', $txt['additional_membergroups'], '</strong>
Search for:
<strong>', $txt['dob'], ':</strong><br />
Replace with:
<strong>', $txt['dob'], '</strong><br />
Search for:
<strong>', $txt['signature'], ':</strong><br />
Replace with:
<strong>', $txt['signature'], '</strong><br />
Search for:
<strong><label for="easyformat">', $txt['time_format'], ':</label></strong><br />
Replace with:
<strong><label for="easyformat">', $txt['time_format'], '</label></strong><br />
Search for:
<strong', (isset($context['modify_error']['bad_offset']) ? ' class="error"' : ''), '><label for="time_offset">', $txt['time_offset'], ':</label></strong><br />
Replace with:
<strong', (isset($context['modify_error']['bad_offset']) ? ' class="error"' : ''), '><label for="time_offset">', $txt['time_offset'], '</label></strong><br />
Search for:
<strong>', $txt['current_theme'], ':</strong>
Replace with:
<strong>', $txt['current_theme'], '</strong>
If you want colons in the profile you must add them now to the language file
Profile.language.php.
@emanuele Here's the file if you wanna use it for RC2 and final. There seem to be no inconsistencies at first sight.
Seems like this should be added for RC2 as well ?
I guess so, I probably misunderstood, I thought you wanted to have the colons, but more them to the language files, that would potentially cause problems if strings are used elsewhere (as they likely are), but remove colons should be safe enough. :)
If all happens in the language files and not in the template files every admin can decide for himself if he wants to use colons or not. He simply has to edit the language files then. I think this ist the best and cleanest way.
I'll get this added to my pending PR :)
Okay!
Then I'll wait merging the PR until then. ;D
Done (plus some additional template cleanup) O:-) ... Need to look at the who's online one for this PR as well
So it's ready for RC2? O:-)
Probably yes! ... have you looked at the site error log ? I forgot to last time I was in the ACP :-[
Damn-it ... just noticed an error I put in ... I'll make a quick fix >:(
Last time I updated it was clean. :P
I drafted the release at github.
Darn, you should not suggest to check the error log... :P