ElkArte Community

Project Support => Support => Topic started by: Ruth on January 22, 2018, 07:31:21 am

Title: How to do the Upgrade?
Post by: Ruth on January 22, 2018, 07:31:21 am
I did never an upgrade by myself and I need a step-by step-instruction O:-)

My testforum is running with 1.0.10 and yesterday I deinstalled the two addons there (SimplePortal and Tabbed Smileys)
I don't need a backup, because there is nothing important in my testforum.

First I have to do the Upgrade to the 1.1.Final and afterwards I have to install the patch to 1.1.1.
Is this correct?

I do not understand, what Emanuele answered here. This topic is closed (why?) https://www.elkarte.net/community/index.php?topic=4712.msg34075#msg34075

QuoteWhat be the proper procedure to upgrade my forum from 1.0.10? Replace all files from the zip or can this be installed from package manager?

Quote1) backup (you never know)[1]
2) the "replace all files" is the way[2] (then pointing to the forum should bring you to the upgrade procedure, otherwise just go to forum/install/upgrade.php).
3) follow the upgrade instructions and delete the "install" directory (the upgrade script tries to do, but if it fails you have to do it manually).
1 Actually, the ideal situation is: do a test upgrade on a clone of your forum and verify nothing breaks.↵
2 Even better would be to remove any thing except Settings.php and Settings_bak.php and upload the new files.↵

It seems not to be possible to do an upgrade via package manager? I tried this yesterday, but I got a warning message, which I did not understand. Something about "empty package", wrong permissions and that I should install the unzipped files via FTP:

QuoteDas Hochladen des Paketes ist aufgrund des folgenden Fehlers fehlgeschlagen:
"Auch wenn das Paket auf den Server kopiert wurde, scheint es leer zu sein. Bitte überprüfe, dass der "/packages"-Ordner und das "/temp"-Unterverzeichnis beschreibbar sind. Solltest du dieses Problem weiterhin haben, solltest du versuchen, das Paket auf deinem eigenen Computer zu entpacken und in ein neues Unterverzeichnis in das "/packages"-Verzeichnis auf den Server zu kopieren. Wenn das Paket zum Beispiel "shout.tar.gt" heißt, solltest Du:
1) Das Paket auf deinen PC herunterladen und entpacken.
2) Mit einem FTP-Programm ein neues Verzeichnis im "/packages"-Ordner erstellen und dieses, in unserem Beispiel, "shout" nennen.
3) Lade alle entpackten Dateien in dieses Verzeichnis.
4) Gehe zurück zum Paketmanager und prüfe, ob das Paket automatisch gefunden wurde (dies sollte nun der Fall sein)."

The adminpanel shows me this at the moment:

Title: Re: How to do the Upgrade?
Post by: Ruth on January 22, 2018, 07:32:08 am
And this is "packages" via FTP at the moment. What do I have to do now?  O:-)
Uploading the zipped (or unzipped?) files from 1.1.Final into this directory?
Title: Re: How to do the Upgrade?
Post by: radu81 on January 22, 2018, 08:28:05 am
To update to 1.1.1 I just unzipped the files and uploaded using an ftp client, after the upload just point your browser to your test forum and the update procedure should begin.
Title: Re: How to do the Upgrade?
Post by: Ruth on January 22, 2018, 08:33:34 am
Thank you, Radu.

So I do not need to use 1.1. Final first?

Where should the unzipped files from 1.1.1. be uploaded?

In "packages"?
Title: Re: How to do the Upgrade?
Post by: radu81 on January 22, 2018, 10:43:49 am
I downloaded the file from here: https://github.com/elkarte/Elkarte/releases (file ElkArte_v1-1-1_install.zip (https://github.com/elkarte/Elkarte/releases/download/v1.1.1/ElkArte_v1-1-1_install.zip))

Unzip the file and overwrite the files on your forum: 


Title: Re: How to do the Upgrade?
Post by: Ruth on January 22, 2018, 04:50:59 pm
Thank you very much, Radu. :)

It worked that way. Everything seems to be okay.

It was a lot of stuff, :P  I hope, I did not miss something.
Title: Re: How to do the Upgrade?
Post by: Ruth on January 22, 2018, 05:39:35 pm
I missed something.... ::)

The editor does not show any BBC-Tags or smileys (but they are working) and the preview is not working.
Title: Re: How to do the Upgrade?
Post by: radu81 on January 22, 2018, 06:43:58 pm
You can change the behaviour and show the full editor under the last post if this is what you'd like to see. (ACP -> Theme Management -> Member Option)

What do you mean the preview is not working? It has any errors? I suggest you to open a new topic if you have other problems, we are going off-topic here ;)
Title: Re: How to do the Upgrade?
Post by: Ruth on January 22, 2018, 06:51:03 pm
I don't mean the quickreply, Radu....I mean the normal editor, if I reply or start a new topic.
The button "preview" ist not working, no preview to see.

Anything else seems to work as usual.
Title: Re: How to do the Upgrade?
Post by: Ruth on January 22, 2018, 06:54:25 pm
There are no errors in the log, I checked all files again on the Server, but I cannot find a file, wich I had missed to upload.

The "console" shows me this errors:
Title: Re: How to do the Upgrade?
Post by: radu81 on January 22, 2018, 07:12:03 pm
I have no idea, first time I see it.
I can suggest to check in ACP > Forum > Posts and topics > Bulletin Board Code
if the option Enable bulletin board code (BBC) is enabled? But I don't think is this, you should at least see the smileys and also a few buttons from the editor.

Do you have any addons installed? Before upgrading to elkarte 1.1 did you have any mods installed on 1.0.10 or did you uninstalled the addons before the update?

== edit ==
I saw now the screenshot and the edit you just made, don't know if could be useful, try to remove elkarte cache and browser cache
Title: Re: How to do the Upgrade?
Post by: Ruth on January 22, 2018, 07:20:15 pm
Yes, BBC-Tags are enabeld in the Admin-Panel, also the smileys are there to see.

I can use BBC or smileys in my posts, if I "write them by hand" but they are missing in the "toolbar"

I deinstalled the two addons yesterday, I had in my testforum before.

Title: Re: How to do the Upgrade?
Post by: Ruth on January 22, 2018, 07:21:40 pm
Quote from: radu81 – I saw now the screenshot and the edit you just made, don't know if could be useful, try to remove elkarte cache and browser cache

Yes, I will try this, thank you, Radu
Title: Re: How to do the Upgrade?
Post by: Ruth on January 22, 2018, 07:29:21 pm
It was this stupid browser cache, Radu! (or stupid me) ;)

Everything is fine now, even the preview is working.

Thank you!
Title: Re: How to do the Upgrade?
Post by: radu81 on January 22, 2018, 07:34:31 pm
Glad you solved and that I could help ;)
Title: Re: How to do the Upgrade?
Post by: Jorin on January 23, 2018, 02:58:42 am
What language files are you using with 1.1.1, Ruth? The german files are not tested with the new ElkArte version. Could be some text strings are missing and not translated.
Title: Re: How to do the Upgrade?
Post by: Ruth on January 23, 2018, 10:42:44 am
I am still using the "old ones", Jorin. They are working without any error, as I have seen until now - there are just a few strings shown in english, as you said.

Don't matter in a testforum. ;)
Title: Re: How to do the Upgrade?
Post by: emanuele on January 23, 2018, 10:52:11 am
Quote from: Ruth – It was this stupid browser cache, Radu! (or stupid me) ;)
hmm... that's odd, in theory the ?R111 at the end of the URL should invalidate the browser cache... O_o
Title: Re: How to do the Upgrade?
Post by: Ruth on January 23, 2018, 11:05:14 am
I am using Opera, Emanuele...and this browser is always a little "strange" since a few months. ;)

 I had a lot of irritations by working in the files, because of the brower cache, doing things again and again...
And  in my resolution the layout/styling of many pages is somehow broken, also here on ElkArte.net and in my forums.



Title: Re: How to do the Upgrade?
Post by: Ruth on January 23, 2018, 08:15:34 pm
Not sure about it, but I think, there is something wrong here?

Every time, when I attach a picture, I will get an error in the log:
 
QuoteNotice: Undefined index: public_attachid
in sources/subs/Attachments.subs.php on line 619

And the attachment details are not centered, see the first screenshot.

It should be display: inline-block instead of display: block here in index.css on line 3127

Code: [Select]
.attachment_name, .attachment_details {
    display: block;
    width: 18em;
    white-space: nowrap;
    overflow: hidden;
    text-overflow: ellipsis;
    padding: 0 .5em;
}
Title: Re: How to do the Upgrade?
Post by: emanuele on January 24, 2018, 06:05:41 pm
Quote from: Ruth – Not sure about it, but I think, there is something wrong here?
Not unlikely. :P

Quote from: Ruth – Every time, when I attach a picture, I will get an error in the log:
 
QuoteNotice: Undefined index: public_attachid
in sources/subs/Attachments.subs.php on line 619
hmm... which one is it the URL associated to the error?

Quote from: Ruth – And the attachment details are not centered, see the first screenshot.
hmm... I thought this was fixed in 1.1.1... I guess I was wrong?
Title: Re: How to do the Upgrade?
Post by: Ruth on January 24, 2018, 06:41:23 pm
I have canged this about the attachment details in index.css.

Quotehmm... which one is it the URL associated to the error?

Not sure, what you mean, Emanuele? It is the URL of my testforum:

Quote   Notice: Undefined index: public_attachid
http://meinforum.de/ea_test/index.php?action=dlattach;sa=tmpattach;attach=post_tmp_1_6025cc6e537c3e713f739da3052680aa;topic=114
Datei: /var/www/vhosts/meinforum.de/httpdocs/ea_test/sources/subs/Attachments.subs.php
Zeile: 619

I got another error in the log last night, while I had installed a copy of the default theme to work in the css-files:

QuoteNotice: Undefined index: copy
http://meinforum.de/ea_test/index.php?action=admin;area=theme;sa=install
Datei: /var/www/vhosts/meinforum.de/httpdocs/ea_test/sources/admin/ManageThemes.controller.php
Zeile: 1358

And as I have noticed right now, I am not able to upload any attachments in posts if I use this theme, ::)
It is only possible in the default theme. But I will get an error in the log, if I attach pictures.

Title: Re: How to do the Upgrade?
Post by: emanuele on January 25, 2018, 07:24:00 am
Quote from: Ruth – Not sure, what you mean, Emanuele? It is the URL of my testforum:

Quote   Notice: Undefined index: public_attachid
http://meinforum.de/ea_test/index.php?action=dlattach;sa=tmpattach;attach=post_tmp_1_6025cc6e537c3e713f739da3052680aa;topic=114
Datei: /var/www/vhosts/meinforum.de/httpdocs/ea_test/sources/subs/Attachments.subs.php
Zeile: 619
That piece is all I need.
By chance, could it be you:
1) uploaded the attachment,
2) inserted inline
3) delete the attachment,
4) uploaded another one,
5) hit preview with the old attachment still in-line?
I'm trying to figure out the path that lead to this error.

Quote from: Ruth –
QuoteNotice: Undefined index: copy
http://meinforum.de/ea_test/index.php?action=admin;area=theme;sa=install
Datei: /var/www/vhosts/meinforum.de/httpdocs/ea_test/sources/admin/ManageThemes.controller.php
Zeile: 1358
Little bug.
Tracked.

Quote from: Ruth – And as I have noticed right now, I am not able to upload any attachments in posts if I use this theme, ::)
It is only possible in the default theme. But I will get an error in the log, if I attach pictures.
That's odd. :-\
I'm not sure why this would happen.
Will check.
Title: Re: How to do the Upgrade?
Post by: Ruth on January 25, 2018, 07:46:15 am
Thank you, Emanuele

Quote from: emanuele – By chance, could it be you:
1) uploaded the attachment,
2) inserted inline
3) delete the attachment,
4) uploaded another one,
5) hit preview with the old attachment still in-line?
I'm trying to figure out the path that lead to this error.

No. I did nothing with inline. I just used the button to upload a picture from my pc and send my post. No preview, no deleting of an attachment.

In the copy of the default the button for uploading is not working, no reaction, if I try to use it. This theme includes a custom css file, so maybe this is the reason?

I made another copy of the default yesterday, in which I don't use a custom.css and in this theme the upload is possible, but with the same errors in the log as in the original default.
Title: Re: How to do the Upgrade?
Post by: emanuele on January 25, 2018, 09:26:44 am
hmm... the attachments issue is weird.
I'll try a fresh install this evening, I do not exclude I broke something during the actual release, because I was sure I fixed this bug before releasing the patch.

For the theme, let me give a try first, I want to see how it works here.

BTW what version of PHP?
Title: Re: How to do the Upgrade?
Post by: Ruth on January 25, 2018, 09:38:07 am
It is PHP-Version: 5.6.33, Emanuele

Title: Re: How to do the Upgrade?
Post by: emanuele on January 25, 2018, 12:00:39 pm
Darn I had to unisntall 5.6 a couple of days ago in order to install 7 because I was not able to let the two live together! xD
Well, let me see how it goes.
Title: Re: How to do the Upgrade?
Post by: emanuele on January 25, 2018, 03:46:46 pm
Okay, I could reproduce all the bugs except the attachments details.
Can you give me some more hints? What kind of settings do you have for the attachments? Thumbnails? Full size? What sizes?

These are the fixes:
https://github.com/elkarte/Elkarte/pull/3108/files
Title: Re: How to do the Upgrade?
Post by: Ruth on January 25, 2018, 05:13:24 pm
Thank you very much, Emanuele!

I never used something from github.  O:-) Therefore I better ask....

For example, now I have to edit the sources/Load.php , in this part:

Code: [Select]
}
else
{
$cache_staler = '';
$params['basename'] = $filename;
}
$this_id = empty($id) ? strtr(basename($filename), '?', '_') : $id;

and instead of this line:
Code: [Select]
$cache_staler = '';

I have to add this?
Code: [Select]
$cache_staler = $staler_string;


QuoteWhat kind of settings do you have for the attachments? Thumbnails? Full size? What sizes?

We don't use thumbnails, our pictures are always to see in full size: 780 x 700 Pixel, 150 KB, 3 attachments per post, see screenshot.

Inline attachments was not enabled yesterday, I made a first try with this today.
Title: Re: How to do the Upgrade?
Post by: Ruth on January 27, 2018, 07:54:58 am
I made those changes in the files from github, Emanuele.

Now there are no more errors in the log by attaching pictures or by making a copy of the default theme.

But it was still not possible to upload pictures, if I use my custom.css, until now. :D

The only problem was this part in my custom.css:

Code: [Select]
.drop_area {
    background-color: #fbecce;
    border: dashed 1px #6993bb;
}

The font and the button are quite big (and ugly) there, so I always had a font-size: 1.1em; in there.
But it seems, that it has to be  font-size: 1.643em; as in index.css now.

Because of this wrong font-size in my custom.css the upload-button did not work before.

Now everything is fine, the upload ist working without any error. ;)
Thank you for your help!
Title: Re: How to do the Upgrade?
Post by: emanuele on January 27, 2018, 08:22:08 am
Interesting problem.
So you had:
Code: [Select]
.drop_area {
    font-size: 1.1em
}
and this breaks the upload?
Good to know, something to look at.
Title: Re: How to do the Upgrade?
Post by: Ruth on January 27, 2018, 08:36:35 am
Yes, Emanuele. I think, it was just this font-size, I changed nothing else.
Title: Re: How to do the Upgrade?
Post by: Feline on January 30, 2018, 06:13:41 am
there is a ; at the end Missing  ;)
Title: Re: How to do the Upgrade?
Post by: Ruth on January 30, 2018, 06:35:14 am
I had this code before, while it was not working:
Code: [Select]
.drop_area {
    background-color: #fbecce;
    border: dashed 1px #6993bb;
    font-size: 1.1em;
}

But there was also a mistake about the font-size here:
Code: [Select]
/* Common button styling. */
.button_submit, .right_submit, .left_submit, .button_reset, .drop_area_fileselect_text,

because it changed to this with 1.1.1:
Code: [Select]
/* Common button styling. */
input[type="submit"], .drop_area_fileselect_text, button[type="submit"], input[type="button"],


Title: Re: How to do the Upgrade?
Post by: emanuele on January 30, 2018, 04:38:46 pm
Quote from: Feline – there is a ; at the end Missing  ;)

Technically the last line of a CSS definition doesn't need he ";". O:-)
Title: Re: How to do the Upgrade?
Post by: Feline on February 02, 2018, 09:21:08 pm
Quote from: emanuele – Technically the last line of a CSS definition doesn't need he ";". O:-)
Technically .. yes .. but many browser have problems without a ; at the end  ;)
Title: Re: How to do the Upgrade?
Post by: emanuele on February 05, 2018, 04:37:15 pm
Never heard of that one...