Text only | Text with Images

ElkArte Community

Project Support => General ElkArte discussions => Topic started by: emanuele on March 12, 2015, 10:16:15 am

Title: Preparing 1.0.3 release
Post by: emanuele on March 12, 2015, 10:16:15 am
Does any of you remember any change in the 1.0.3 code that admins should be reminded about or that requires admin actions?
Title: Re: Preparing 1.0.3 release
Post by: Spuds on March 12, 2015, 11:32:23 am
Do new text strings count?
Title: Re: Preparing 1.0.3 release
Post by: emanuele on March 12, 2015, 12:43:07 pm
hmm... do we have new strings? I missed them... :-[

I was thinking about things like the avatars for 1.0.2, where admins were supposed to check the settings and fix anything not good for them.
Title: Re: Preparing 1.0.3 release
Post by: Spuds on March 12, 2015, 02:03:58 pm
Ah ... not that I can think of (wrt a settings change that the admin needs to know about)

Just a few text strings, nothing major.
$editortxt['Close'] = 'Close';
$txt['pm_approve_warning'] = 'Approve this personal message with CAUTION!
   The PM being replied to has been REMOVED.
   The system attempts to find others in that conversation but the results are not 100% accurate.
   If in doubt, its better to bounce!';
$txt['mentions_what'] = 'Message';
$txt['whoall_pm_byemail'] = 'Sending a personal message by email.';
$txt['mark_these_as_read'] = 'Mark THESE messages as read';

We should also update define('CACHE_STALE', '?102'); to 103 I believe, I think we had a couple of JS changes? (had to look, thats a yup :P)
Title: Re: Preparing 1.0.3 release
Post by: emanuele on March 12, 2015, 03:44:24 pm
Ouch!
Forgot about the stale... :-\
Title: Re: Preparing 1.0.3 release
Post by: emanuele on March 12, 2015, 06:19:04 pm
Updated the stale and I have the patch ready.
I just don't have a clean forum to test it. xD

Well, I attached it here, I'm not sure it even works, so test with care. ;)

ETA: removed the patch to avoid confusion.
Title: Re: Preparing 1.0.3 release
Post by: Spuds on March 12, 2015, 10:47:41 pm
Couple of small bugs that need to be fixed, will update tomorrow ...

one simple on is the language edits need to point to /english/ in the .xml file.  One edit is missing but I think I forgot to update one area with the new langauge string :(

Also the unzipo and untgz files are placed in /sources/sources/subs instead of /sources/subs

Also seeing the following in a quick test
Undefined index: href
/public_html/forum/sources/Subs.php
Line: 2562
      
Undefined index: image
public_html/forum/sources/Subs.php
Line: 2563
Title: Re: Preparing 1.0.3 release
Post by: Jorin on March 13, 2015, 04:01:27 am
...which brings us back to this:

Quote from: Spuds – Do new text strings count?

lol
Title: Re: Preparing 1.0.3 release
Post by: emanuele on March 13, 2015, 03:05:46 pm
I won't be able to touch it until Sunday (if I will be able on Sunday).

New language strings may count in the sense of "hey admin there are new strings, if you have another language you should consider updating it[1]".
A short notice may be worth, to consider.
1 Provided language strings have been translated to the language, of course. And yes, that brings us back to the topic to inform people doing translations that I guess it was not updated. Honestly I lost track of strings on this round, so I have no idea.↵
Title: Re: Preparing 1.0.3 release
Post by: Spuds on March 13, 2015, 05:30:44 pm
Here is an updated package that fixes the install errors that I noted above.

However:
- It does not have the PR that I submitted to tweak a couple areas, that can wait to 1.0.4 as well
- It does not fix the undefined errors that I was getting as noted above, have not had time to look at that :(
Title: Re: Preparing 1.0.3 release
Post by: emanuele on March 13, 2015, 06:09:52 pm
/me marks as unread
Title: Re: Preparing 1.0.3 release
Post by: emanuele on March 16, 2015, 08:58:28 am
Found the undefined index issue.
In a couple of cases, determineAvatar returns an empty array, and this is the cause of the undefined index.

About the fix: one way to fix it would be to always return an array of data, but I feel in some cases the avatar index is checked as not empty, and returning something would break these checks.
So, for 1.0.3 I'd just add a pair of !empty to the new code in Subs.php.
Title: Re: Preparing 1.0.3 release
Post by: Spuds on March 16, 2015, 09:09:51 am
!empty() it is then :D
Title: Re: Preparing 1.0.3 release
Post by: emanuele on March 16, 2015, 11:11:07 am
:D

I'm finishing to add stuff to the xml.
I'll upload a new version before evening (CET).
Title: Re: Preparing 1.0.3 release
Post by: emanuele on March 16, 2015, 11:22:21 am
Faster than expected.

Attached a new version of the patch. :D

I'll start committing this to the repo, so there is a starting point (and hopefully and ending one).

I moved the milestone at github to Thursday (the 19th), though, if there are no other issues it can be released.
Title: Re: Preparing 1.0.3 release
Post by: Spuds on March 16, 2015, 11:29:44 am
Just did a test, it installed fine on 1.0.2 ... and the site is still running :P  ;D
Title: Re: Preparing 1.0.3 release
Post by: emanuele on March 16, 2015, 11:37:47 am
/me added an easter egg that blows the site only when it becomes non-obvious. :P
Title: Re: Preparing 1.0.3 release
Post by: emanuele on March 18, 2015, 05:11:55 am
https://github.com/elkarte/Elkarte/releases/edit/untagged-ad19a1794626ade72ee5 <= (empty) draft of the release announcement... @Spuds do you know what we changed in 1.0.3 worth of mention?
Title: Re: Preparing 1.0.3 release
Post by: Spuds on March 18, 2015, 09:50:29 am
Hummm 114 commits and 78 files changed, you would have thought we did something of mention :P but really it was a bunch of smallish or esoteric bug fixes with some very nice tweaks here and there.  Probably best just to point to the commit list instead?

One thing we may want to note is that due to a change in parse_bbc, IF you are using SP you should uninstall it before installing this patch, then install the latest version of SP. 


Title: Re: Preparing 1.0.3 release
Post by: emanuele on March 18, 2015, 03:18:19 pm
So my feeling was not wrong at all! LOL

Good point about SP.
Title: Re: Preparing 1.0.3 release
Post by: emanuele on March 19, 2015, 07:02:31 pm
Arg... sorry, today I had another round of problems and I didn't find the time to prepare the release... tomorrow! For sure... I hope. :P
Title: Re: Preparing 1.0.3 release
Post by: emanuele on March 20, 2015, 06:28:20 am
Now it is tomorrow, I've fixed the text of the release announcement. I'm preparing the package now hoping I didn't break anything in the meantime. :P
Title: Re: Preparing 1.0.3 release
Post by: radu81 on March 21, 2015, 04:17:28 pm
Quote from: Spuds – Ah ... not that I can think of (wrt a settings change that the admin needs to know about)

Just a few text strings, nothing major.
$editortxt['Close'] = 'Close';
$txt['pm_approve_warning'] = 'Approve this personal message with CAUTION!
   The PM being replied to has been REMOVED.
   The system attempts to find others in that conversation but the results are not 100% accurate.
   If in doubt, its better to bounce!';
$txt['mentions_what'] = 'Message';
$txt['whoall_pm_byemail'] = 'Sending a personal message by email.';
$txt['mark_these_as_read'] = 'Mark THESE messages as read';

We should also update define('CACHE_STALE', '?102'); to 103 I believe, I think we had a couple of JS changes? (had to look, thats a yup :P)
After updating to 1.0.3 I download the italian translation but the text for "Mark THESE messages as read" it's not included. I think new phrases should be included. I did not checked the others strings.
Beside that I don't understand why it was added this new string and what is the difference betweem the old "Mark ALL messages as read" and the new "Mark THESE messages as read". Once you used the "Mark THESE messages as read" all unread messages are marked as read. Am I missing something?
Title: Re: Preparing 1.0.3 release
Post by: Spuds on March 21, 2015, 05:12:28 pm
http://www.elkarte.net/community/index.php?topic=2401.msg15793#msg15793
Title: Re: Preparing 1.0.3 release
Post by: emanuele on March 21, 2015, 05:34:53 pm
I guess the files should be uploaded at transifex... :-[
Text only | Text with Images