Print Page - [RC2] split single post

Title: [RC2] split single post
Post by: Jorin on August 16, 2014, 04:56:25 am

Oops! Where's the button?

Title: Re: [RC2] split single post
Post by: emanuele on August 16, 2014, 05:29:04 am

arg...

Title: Re: [RC2] split single post
Post by: Jorin on August 16, 2014, 05:30:42 am

ElkArte 1.1: Now with the new feature "hiding buttons"! We are the first! :D

It's a funny one and I hope I'm not the only one with this problem?

Title: Re: [RC2] split single post
Post by: emanuele on August 16, 2014, 05:38:40 am

I would fix that one with:

Code: [Select]

#split_topics .submitbutton {
    width: 100%;
}

somewhere in index.css

For 1.0 should do the trick, I used a very specific selector to avoid problems in other places, but there may be others... :-\

Unless @Spuds has another idea!

Title: Re: [RC2] split single post
Post by: Spuds on August 16, 2014, 09:26:14 am

Only other thought would be to change the button div from

Code: [Select]

<div class="submitbutton">

Code: [Select]

<div class="submitbutton clear">

This will place Split button at the bottom of the page
or

Code: [Select]

<div class="submitbutton clear_right">

This will place the button at the bottom of the right side "selected" column, which may be the best place for it really

Also the script is thorwing an error topic.js when you select the arrows to add to the split list.

Code: [Select]

TypeError: XMLDoc.getElementsByTagName is not a function
pageIndex = XMLDoc.getElementsByTagName("pageIndex")[i];
http://localhost/elkarte/themes/default/scripts/topic.js Line 1145

Can't look at that one ATM

Title: Re: [RC2] split single post
Post by: emanuele on August 16, 2014, 11:25:08 am

Cool! Will add it.

The js error looks like a bug in the returned document... :-\
Will check it now.

Title: Re: [RC2] split single post
Post by: emanuele on August 16, 2014, 04:19:00 pm

Button: https://github.com/emanuele45/Dialogo/commit/c8df952b0a89a9446c83125265ea8a0584963024
js error: https://github.com/emanuele45/Dialogo/commit/f90e53ebde562bd62e7ec5b82b2be31eb094e60d

ElkArte Community

Elk Development => Bug Reports => Exterminated Bugs => Topic started by: Jorin on August 16, 2014, 04:56:25 am