ElkArte Community

Elk Development => Bug Reports => Exterminated Bugs => Topic started by: TE on September 06, 2013, 04:12:39 am

Title: Ajax mark all messages read bug
Post by: TE on September 06, 2013, 04:12:39 am
When marking all messages as read in action unread there's a bug with the ajax feedback somewhere...
The DIV with the text "No unread topics found since your last visit" is automatically added, howeder the unread messages stay visible. I believe the expected behaviour is:
- add the text "No unread topics found since your last visit"
- hide all messages from the list
Title: Re: Ajax mark all messages read bug
Post by: emanuele on September 06, 2013, 05:36:36 am
Probably due to changes in ids and classes.

The attached diff should fix it.

ETA: .txt otherwise I cannot attached it.

Darn, the un_preparse doesn't work on quick edit too now... ::)
Title: Re: Ajax mark all messages read bug
Post by: emanuele on September 06, 2013, 05:39:12 am
 For the record, feel free to apply it, I would avoid any other "small fix" in my small_things branch... LOL
Title: Re: Ajax mark all messages read bug
Post by: TE on September 06, 2013, 07:18:37 am
Quote from: emanuele – For the record, feel free to apply it, I would avoid any other "small fix" in my small_things branch... LOL
ROFL
Title: Re: Ajax mark all messages read bug
Post by: emanuele on September 06, 2013, 07:24:44 am
 If you apply that one, could you please add this too? O:-)
In themes/default/css/index.css
Code: (find) [Select]
.topic_sorting #sortby, #sortby,
.topic_sorting:hover #sortby, #sortby:hover {
Code: (replace with) [Select]
.topic_sorting #sortby {
width: 8.4em;
}
.topic_sorting:hover #sortby, #sortby:hover {

Sorry for the trouble... :-[

ETA: it's not perfect (because there is still a slight "jump"), though it's better than before...
Title: Re: Ajax mark all messages read bug
Post by: TE on September 06, 2013, 07:56:12 am
yep, will fix it tomorrow ..
Title: Re: Ajax mark all messages read bug
Post by: emanuele on September 06, 2013, 03:46:19 pm
 Never mind, I created another branch while I stopped working on "small_things"...

/me whistles innocently
Title: Re: Ajax mark all messages read bug
Post by: Burke Knight on September 09, 2013, 08:05:49 pm
Also, when hit mark as read, the loading box at top stays, until close it.
However, it does mark as read.
Title: Re: Ajax mark all messages read bug
Post by: emanuele on September 10, 2013, 04:54:57 am
Fixed here:
https://github.com/emanuele45/Dialogo/commit/49d9a2f6bdefc7491869dc2e10be0a005a485369
Title: Re: Ajax mark all messages read bug
Post by: Burke Knight on September 10, 2013, 05:31:17 am
Yeah... But not here on the site. ;)
Title: Re: Ajax mark all messages read bug
Post by: emanuele on September 10, 2013, 07:28:49 am
Ahh..okay.
Yep, the site is not updated automagically (though it may be cool 8)), it requires teh Spuds upload the files and be ready to fix what is (usually) broken. O:-)
Title: Re: Ajax mark all messages read bug
Post by: Spuds on September 10, 2013, 07:50:56 am
QuoteYep, the site is not updated automagically (though it may be cool 8)), it requires teh Spuds upload the files and be ready to fix what is (usually) broken. O:-)
Should be updated here now, as of this AM  :) and yes an auto script would be cool and possible with the API