Yes, it's not the first time... lol
https://gist.github.com/emanuele45/8966233
This list contains, for each file in ElkArte, the longest line it has, along with the number of chars.
Long lines are not good in my book: they are badTM: most of them are the result of numerous concatenations and repeated and nested ternary operations, etc.
Well, if some one has nothing to do and wants to try to break up some of them, it's an easy task (mostly) that will bring you around the whole code. :P
What length did you use for to long? I'm surprised there are only that many left :P
There is no cut-off, this is just the longest of each file. :P
The one in DataValidator can be nixed as soon as you bump the version to >= 5.2. Just use Filter.
Where is the fun in that when you can have a completely undecipherable regex like that :P Excellent point really, and then we can also remove the duplicate one in QueryString !
You can also replace all of those validations with Zend Validator or Symfony's or anyone's really. They're more likely to stay on top of bugs.
Oh, filter... I never used that one. I know I considered it. And then I wondered if it was better than a regex. I suppose so.
It uses regular expressions but they are compiled in C so they are likely faster.
Do we want to kill the IPv6 validation for filters?
Forgot about this ... heck yes we do!