[ADDON][WIP] In Line Attachments

Topic: [ADDON][WIP] In Line Attachments (Read 34035 times) previous topic - next topic

0 Members and 1 Guest are viewing this topic.

Re: [ADDON][WIP] In Line Attachments

Reply #45 – July 31, 2015, 04:24:41 pm

Little example of the current state.

Re: [ADDON][WIP] In Line Attachments

Reply #46 – July 31, 2015, 05:17:38 pm

Wow coolio

Re: [ADDON][WIP] In Line Attachments

Reply #47 – August 07, 2015, 09:56:06 am

today a member sent me a PM with a critical error. He told me that he got that error when looking into drafts. I have no other information, in the error log I got:

Code: [Select]

 7630ef95227de92c28f925fa7de35e28
 Tipo di errore: Critico
Wrong value type sent to the database. Integer expected. (msg)
Function: _ila_get_topic  URL	http://www.skodaclub.it/index.php?action=profile;area=showdrafts;u=511
File: /../sources/subs/ILA.subs.php
Raw: 729

I checked my drafts but I was not able to reproduce this error. Anyone else with this error?
In the error log, in the last week I only see 8 of this errors, but all are from the same user.

Re: [ADDON][WIP] In Line Attachments

Reply #48 – August 07, 2015, 10:11:42 am

That would be a bug with inline attachments ...

I'd say they saved a draft using the ILA tags which the system is trying to fulfill one way or another. I should be able to reproduce this and come up with a fix this weekend.

Re: [ADDON][WIP] In Line Attachments

Reply #49 – August 25, 2015, 05:18:22 am

Quote from: radu81 – February 07, 2015, 06:44:45 am
Quote from: radu81 – January 02, 2015, 05:43:34 pmI know this addon is wip, but in the future would be nice to have responsive images inserted with [attachimg=x]
Please remember about this, maybe is just a simple trick with css, but I don't know how to solve it

Please don't forget about this

you can see it here: skodaclub.it/index.php?topic=1683

Re: [ADDON][WIP] In Line Attachments

Reply #50 – August 25, 2015, 05:52:41 am

Yeah it's a missing max-width: 100% on images.

Re: [ADDON][WIP] In Line Attachments

Reply #51 – August 26, 2015, 03:28:55 am

I don't know if it's a good solution but I solved the problem with responsive images inserted with [ attachimg=x ] by changing the line 531 in ILA.subs.php from

Code: [Select]

$inlinedtext = '<img src="' . $this->_attachment['href'] . ';image" alt="" title="' . $ila_title . '" id="thumb_' . $uniqueID . '" style="width:' . $this->_curr_tag['width'] . 'px;" />';

Code: [Select]

$inlinedtext = '<img src="' . $this->_attachment['href'] . ';image" alt="" title="' . $ila_title . '" id="thumb_' . $uniqueID . '" style="max-width: 100%;" />';

Re: [ADDON][WIP] In Line Attachments

Reply #52 – August 26, 2015, 03:39:50 am

I think it should work, I don't know if @Spuds has other coding standards or something, but it works and it's responsive regardless of the selected theme

Re: [ADDON][WIP] In Line Attachments

Reply #53 – August 26, 2015, 03:47:32 am

for me is working

Quote from: radu81 – August 25, 2015, 05:18:22 amyou can see it here: skodaclub.it/index.php?topic=1683

Re: [ADDON][WIP] In Line Attachments

Reply #54 – August 26, 2015, 04:44:06 am

I know it does, because I had tried it

Re: [ADDON][WIP] In Line Attachments

Reply #55 – August 27, 2015, 08:40:06 am

Tracked for 1.1 https://github.com/elkarte/Elkarte/issues/2191

ETA: just to explain why "1.1 beta 2", I set it as "blocker", so no release until it's fixed, but is a little tweak, so if it is fixed for beta 1 good, otherwise it must be fixed for beta 2.

Re: [ADDON][WIP] In Line Attachments

Reply #56 – August 27, 2015, 08:56:51 am

I also found error for "1.1 beta 2" => https://github.com/elkarte/Elkarte/issues/2189.

Re: [ADDON][WIP] In Line Attachments

Reply #57 – August 27, 2015, 09:29:40 am

if this addon it will be in the core maybe you have to revisit openimporter and/or ILA, because most forums had inline attachements into core and most of them are using the same bbcode [attach=x) or [attachimg=x) where x is the id of attachment in the forum, not in topic. ILA is not using the id of the attachment in the whole forum, but the id of attachment in that topic. With the first solution you can embed an attachment inline in different topics.

Re: [ADDON][WIP] In Line Attachments

Reply #58 – August 27, 2015, 05:29:35 pm

There could be a "compatibility mode", where the id is the attachment id instead of the message id?
Or the other way around: change ILA code to use the attachment id and have a compatibility-mode that uses the message attachment id?

Re: [ADDON][WIP] In Line Attachments

Reply #59 – February 10, 2016, 03:54:51 am

Installed, works fine. German translation added. Is there any need of translating the help text? I didn't find where the translation is used anyway.

Some news on the editor problem?