Skip to main content
Topic: Feature request: Image Proxy (Read 23337 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

Re: Feature request: Image Proxy

Reply #75



Quick test of proxy updates and 1.1.1 fixes (scale up issue)
Last Edit: November 21, 2017, 01:44:57 pm by Spuds

Re: Feature request: Image Proxy

Reply #76

The proxy still doesn't catch avatars used on board index.
I just noticed and not investigated, thought I'm not sure why because they should use the avatar function I fixed a while ago... I guess I didn't fix it entirely. xD
Bugs creator.
Features destroyer.
Template killer.

Re: Feature request: Image Proxy

Reply #77

I put up a fix here.
Bugs creator.
Features destroyer.
Template killer.

Re: Feature request: Image Proxy

Reply #78

Darn avatars !

Re: Feature request: Image Proxy

Reply #79

We should remove them along with attachments! xD
Bugs creator.
Features destroyer.
Template killer.

Re: Feature request: Image Proxy

Reply #80

I like it :D LOL


Re: Feature request: Image Proxy

Reply #82

Remember to also remove messages :stuck_out_tongue_winking_eye:
LiveGallery - Simple gallery addon for ElkArte

[ADDON] Image Proxy

Reply #83

This topic was difficult to find, @Spuds‍ what do you think about moving it to add-ons board and add it to addons.elkarte.net ?

I am using it with Elkarte 1.1.7 and PHP 7.4, I have some errors in elkarte log:

    Type of error: General
    Notice: Trying to access array offset on value of type bool
    index.php?action=mentions;sa=fetch;api=json;lastsent=0&_=1619502095109
    File: /sources/subs/ImageCache.integrate.php
    Line: 174

Code: [Select]
173: 	// No need if its already on this site (like uploaded avatars)
174: if ($parseImg['host'] === $parseBoard['host'])
175: {
176: return false;
177: }
sorry for my bad english

Re: [ADDON] Image Proxy

Reply #84

Looks like just the 1.0 version is on the addon site .... someone is lazy!

Thanks for the bug report, I'll have a look.

Moving this topic to addons

Re: [ADDON] Image Proxy

Reply #85

Try this php7.4 update
Last Edit: April 27, 2021, 09:40:18 pm by Spuds

Re: [ADDON] Image Proxy

Reply #86

I tried, but the image is not displayed

here is what I see with the latest version:
01.png

and with the previous version:
02.png

I did the test with same image. Finding an http image is not an easy task :)

I post the same image here. (here works fine)
sorry for my bad english

Re: [ADDON] Image Proxy

Reply #87

Strange, that image works fine on my local.

- You can try toggling it  off/on on the core features page
- Maybe you are using an older browser?  I did update the headers that are sent for inline images but what I'm using is the norm these days.
- Perhaps it failed to download the image and for some reason its not displaying the default icon instead?

Any clues in the development console ? or a link to where I can take a quick look as well?

ETA: Oh FFS ... I have a comma where a period should be.  I'll upload a new one in a bit
Last Edit: April 27, 2021, 06:49:37 pm by Spuds

Re: [ADDON] Image Proxy

Reply #88

Give this one a try
Last Edit: April 28, 2021, 12:29:34 pm by Spuds

Re: [ADDON] Image Proxy

Reply #89

This works, thanks! 8)

if I really have to be picky: if you open in a new tab the image you see on forum, the full path to image is displayed. You can see it on also on this forum. IIRC I reported something similar for attachments and was solved.

P.S. For the others: if you uninstall and install a new version of this add-on, don't forget to enable the add-on on ACP -> Configuration -> Core features. When I uninstalled and installed the new version took me some time to understand why  the menu ACP -> Configuration -> Image cache settings was missing.
Last Edit: April 28, 2021, 02:58:51 am by radu81
sorry for my bad english