ElkArte Community

Elk Development => Bug Reports => Exterminated Bugs => Topic started by: Jorin on February 25, 2014, 04:05:32 am

Title: Small issues with mobile layout in Beta 2
Post by: Jorin on February 25, 2014, 04:05:32 am
1. With empty boards the vertical lines aren't in a row (see first screenshot).
2. The logo isn't centered (see second screenshot).
Title: Re: Small issues with mobile layout in Beta 2
Post by: TE on February 25, 2014, 07:58:15 am
the first one is a bit more complex, the second one should be easy to fix..
I'll check.
Title: Re: Small issues with mobile layout in Beta 2
Post by: Antechinus on February 25, 2014, 04:51:28 pm
First one should be easy. What's complex about it? (serious question, not sarc).
Title: Re: Small issues with mobile layout in Beta 2
Post by: emanuele on February 25, 2014, 06:24:14 pm
Hey @Antechinus!!

Nice to see you around from time to time! ;D
Title: Re: Small issues with mobile layout in Beta 2
Post by: TE on February 26, 2014, 01:02:45 am
Quote from: Antechinus – First one should be easy. What's complex about it? (serious question, not sarc).
the width for the rows (max-width property mainly) can cause unwanted effects while resizing the window, primarily with older Browsers (IE8/IE9).
Title: Re: Small issues with mobile layout in Beta 2
Post by: Antechinus on February 26, 2014, 01:49:14 am
Just looking at the screenshot in the OP, my impression is that it's more likely to be a minimum width problem. It looks as if the upper "cell" is being pushed out by its content (you can see the left padding next to the content) while the lower cell, lacking content, doesn't have anything to push the padding to the left, so it collapses to a smaller size. The dfference in width appears to be exactly the same as the left padding on the upper "cell".

Are IE8 and IE9 at all relevant for mobile layouts? I would have thought they could be ignored.
Title: Re: Small issues with mobile layout in Beta 2
Post by: TE on February 26, 2014, 02:09:50 am
Quote from: Antechinus – Just looking at the screenshot in the OP, my impression is that it's more likely to be a minimum width problem. It looks as if the upper "cell" is being pushed out by its content (you can see the left padding next to the content) while the lower cell, lacking content, doesn't have anything to push the padding to the left, so it collapses to a smaller size. The dfference in width appears to be exactly the same as the left padding on the upper "cell".

Are IE8 and IE9 at all relevant for mobile layouts? I would have thought they could be ignored.
yep, meant min-width, not max .. sorry for the confusion.
IE8 & 9 aren't available on mobile devices (IIRC) but since we still support them resizing the Window should work on them, too.
Title: Re: Small issues with mobile layout in Beta 2
Post by: Antechinus on February 26, 2014, 02:14:31 am
K. Well my 2c is that I wouldn't worry about them, since it's unlikely anyone will be using the smallest window size on desktop. IE8 is legacy anyway and some minor bugs probably have to be tolerated (and XP must be near to EOL now).
Title: Re: Small issues with mobile layout in Beta 2
Post by: TE on February 28, 2014, 11:53:42 am
@Jorin
1) is fixed (https://github.com/eurich/Elkarte/commit/d2054df65a2cb264a9073ea48f46304594a812c0)
2) is related to your custom theme. Show logo left and no forumtitle isn't part of the default theme options.
Title: Re: Small issues with mobile layout in Beta 2
Post by: Antechinus on March 01, 2014, 01:35:02 am
Just found out that XP is being EOL'd at the end of next month, which means IE8 is basically irrelevant, or will be by the time Elk is stable. I'd just totally ignore IE8, and would probably throw out any code specifically related to IE8.
Title: Re: Small issues with mobile layout in Beta 2
Post by: Jorin on March 03, 2014, 02:43:49 am
Quote from: TE – 2) is related to your custom theme. Show logo left and no forumtitle isn't part of the default theme options.

:o

I use this:

QuoteOnly logo: only the logo is displayed, in a centered position

And this is part of the default theme options.  ;)
Title: Re: Small issues with mobile layout in Beta 2
Post by: TE on March 03, 2014, 03:57:51 am
mhh, ok.. thought you have modified the index file / css of your Theme because your logo isn't centered at all, I'll re-check...
Title: Re: Small issues with mobile layout in Beta 2
Post by: Jorin on March 03, 2014, 04:31:54 am
I've only changed color codes.  ;)
Title: Re: Small issues with mobile layout in Beta 2
Post by: emanuele on March 03, 2014, 02:22:10 pm
Yup, that option is my fault... :-[

Let me know if I have to fight with it on your behalf! :D (I can break it! :P)
Title: Re: Small issues with mobile layout in Beta 2
Post by: TE on March 03, 2014, 02:46:21 pm
It's fixed in the repo, (tested with your logo and my local repo copy). I know I fixed some days ago (found it on the hybrid-piloten import) but I can't find the related commit ;)