Skip to main content
Topic: Position of goto top/bottom buttons (Read 6968 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

Position of goto top/bottom buttons

https://github.com/elkarte/Elkarte/issues/1274

Any idea?
Maybe "attached" to the border of the wrapper instead of the border of the page?
Bugs creator.
Features destroyer.
Template killer.

Re: Position of goto top/bottom buttons

Reply #1

ROFL. That's where I had them to start with, and you lot complained like hell.

(well some of you did)
Master of Expletives: Now with improved family f@&king friendliness! :D

Sources code: making easy front end changes difficult since 1873. :P

Re: Position of goto top/bottom buttons

Reply #2

Can't you just use some CSS to get around the OSx scrollbars?

One obvious solution is just to make the buttons a bit wider, so they're easier to hit on a Mac. Or, if you can sniff Mac somehow, use Mac-specific CSS.
Master of Expletives: Now with improved family f@&king friendliness! :D

Sources code: making easy front end changes difficult since 1873. :P

Re: Position of goto top/bottom buttons

Reply #3

LOL
If I complained, I was drunk. :P

No idea, I don't have OSx and I have no idea what CSS means. O:-)
Bugs creator.
Features destroyer.
Template killer.

Re: Position of goto top/bottom buttons

Reply #4

It means Complicated Stupid Stuffz. :P

I don't have a Mac either. However, if the buttons were doubled in width, they'd be wide enough to not be hidden by Mac scrollbars. Admittedly this would make them a bit too wide on useful operating systems, so perhaps go 50% wider or whatever will stop Macheads from complaining. That is going to be the easiest option. If that's not good enough, you'll need some way of sniffing Mac.

ETA: Obviously all of this assumes leaving them at the edge of the page, so people don't go back to flipping out about them being on the edge of the wrapper. :D
Last Edit: March 15, 2014, 07:49:21 pm by Antechinus
Master of Expletives: Now with improved family f@&king friendliness! :D

Sources code: making easy front end changes difficult since 1873. :P

Re: Position of goto top/bottom buttons

Reply #5

Frankly, I do not find them that useful.  <shrug>

How about sticking them on the right side of the body? Fixed at the midpoint between top and bottom of the screen? That would solve the Mac scroll bar issue.

That or maybe float it between the body and wrapper? Leave if fixed there.

Just don't let the button scroll up and down with the screen. Fix it in one place, like it currently is on the wrapper.  I am finding that folks find that kind of item moving around to be annoying.
Last Edit: March 15, 2014, 08:09:32 pm by AaronB

Re: Position of goto top/bottom buttons

Reply #6

Umm, it is already fixed at the right side of the body. :P
Master of Expletives: Now with improved family f@&king friendliness! :D

Sources code: making easy front end changes difficult since 1873. :P

Re: Position of goto top/bottom buttons

Reply #7

Ummm ... see image.

Would likely be called the #bodyarea in SMF. What it is in elkarte I do not know. 

My deepest and most sincerest apologies for stating the incorrect area and for not knowing the insides of elkarte.

Re: Position of goto top/bottom buttons

Reply #8

The problem appears to be that on Macs the body extends beneath the scrollbar. It's really weird behaviour, but then Mac is really weird anyway.
Master of Expletives: Now with improved family f@&king friendliness! :D

Sources code: making easy front end changes difficult since 1873. :P

Re: Position of goto top/bottom buttons

Reply #9

@AaronB I think we are talking about the same thing! :D
I'll give it a try "later". ;)
Bugs creator.
Features destroyer.
Template killer.

 

Re: Position of goto top/bottom buttons

Reply #10

:)  thanks.

This theme is a challenge for me, not that I am that good to begin with. I have worked with it last night and this morning. Now have some different colours, a static logo in the header, slogan to the right and still maintain the ElkArte branded logo in the Support Topics bar. Changed colour depth of iconadmin type icons, added quotes around some font names in index.css or its variant ( don't recall which ), made a change in index.template for the static logo, removed the linkable logo stuff, have alternate colours on posts and removed all box-shadow calls.

My brain hurts.   ;D

Re: Position of goto top/bottom buttons

Reply #11

What did you find more difficult to do/change?
Bugs creator.
Features destroyer.
Template killer.

Re: Position of goto top/bottom buttons

Reply #12

I would say the placing of the custom logo in the header area.

As it stands, there does not seem to be a straight forward way for a user to add their own logo in the css, however, it is simple enough in Themes if they simply add a URL to the logo image they wish to use. It is much simpler to add the URL but sometimes a person wants something a bit more complicated. The logobox and the .centered left and right stuff seems to really be designed for only the ElkArte branded logo. If a user adds their own logo and simply change the name to logo_elk.png then the user logo will appear in the Support Information bar, which should only house the ElkArte logo.

I removed all the .center stuff, added a background image to the header area, made the necessary placement adjustments,  removed the logobox stuff in the CSS file and in index.template.php, template_above_body I removed the original logo stuff and removed this.


Code: [Select]
echo '
            <div id="logobox">
                <img id="logo" src="', $context['header_logo_url_html_safe'], '" alt="', $context['forum_name'], '" title="', $context['forum_name'], '" />', empty($settings['site_slogan']) ? '' : '
                <div id="siteslogan">' . $settings['site_slogan'] . '</div>', '
            </div>';


and added this.

Code: [Select]
    // Lets remove the logobox and display only the site slogan. Not the Factory Default.
    echo '
            <div id="siteslogan">' , $settings['site_slogan'] , '</div>';


Which was a challenge because even though I spent 8 or so years in 'C', I don't know a think about .php.  :)


Keep in mind that I am not a CSS master at all but I can get around with FF and Firebug.  Of course, anytime you read someone elses work you have to follow it and try to understand their reasoning. The changes I have made so far I have tested and retested to be certain the header was stable and all other areas functioned properly.

It took me a bit of time to understand the variants theme. Had to figure out how and where they were being called from. Once that was sorted and I understood how varients work, I had a clearer mind as to what to do with the theme. I also discovered that to properly create a theme that does not use the default varients of _light and _besocial!! that you have to remember to change the path in the index.css and index_varient.css files for the images to be found.  :)


edit: first paragraph clarity ... I think.
Last Edit: March 16, 2014, 03:05:52 pm by AaronB

Re: Position of goto top/bottom buttons

Reply #13

Quote from: AaronB – I would say the placing of the custom logo in the header area.

As it stands, there does not seem to be a straight forward way for a user to add their own logo. The logobox and the .centered left and right stuff seems to really be designed for only the ElkArte branded logo. If a user adds their own logo and simply change the name to logo_elk.png then the user logo will appear in the Support Information bar, which should only house the ElkArte logo.
The logo area is designed exactly to handle "one" logo at a time.
You can change it by going to:
admin > configuration > current theme
and putting an url in the Logo image URL box.
That would replace the Elk logo with the one of the site/forum.
When I changed it to be like that it seemed to me more likely that an admin want to have just the logo of his own forum and not the logo of the software up in the header.

Quote from: AaronB –
Keep in mind that I am not a CSS master at all but I can get around with FF and Firebug.
 emanuele knows the feeling... O:-)

Quote from: AaronB – It took me a bit of time to understand the variants theme.
Yeah, variants may be a bit tough to approach at first...

Quote from: AaronB – I also discovered that to properly create a theme that does not use the default varients of _light and _besocial!! that you have to remember to change the path in the index.css and index_varient.css files for the images to be found.  :)
That is true...and something I didn't like me too.
I wonder if it wouldn't be easier to have all the css into /css/ and not into /css/_variant/... @TE?
Bugs creator.
Features destroyer.
Template killer.

Re: Position of goto top/bottom buttons

Reply #14

If you're going to try putting the buttons on the wrapper, just be warned it gets tricky with changing resolutions. The wrapper edge sits in different x positions depending on res, and fixed buttons are defined with reference to the screen boundaries.
Master of Expletives: Now with improved family f@&king friendliness! :D

Sources code: making easy front end changes difficult since 1873. :P