Skip to main content
nested functions in Packages.php Started by TE · · Read 7536 times 0 Members and 1 Guest are viewing this topic. previous topic - next topic

nested functions in Packages.php

Something really odd: function sort_table_first($a, $b) is defined inside public function action_install(). There are more like that in Packages.php
Technically it's allowed but do we want this? IMO it isn't really good practice..
Thorsten "TE" Eurich
------------------------

 

Re: nested functions in Packages.php

Reply #1

I tend to agree... They were probably not meant to be reused so defined where needed, but we don't need to continue the practice methinks.
The best moment for testing your PR is right after you merge it. Can't miss with that one.