Skip to main content
Topic: Quickedit haz no 'Last edit by' (Read 4388 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

Quickedit haz no 'Last edit by'

# modify a post
# display it
=> it has 'last edit by...'.
#quick edit the post, save
=> 'last edit by' bit is no longer displayed.

# reload it
=> 'last edit by' is displayed.
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: Quickedit haz no 'Last edit by'

Reply #1

Yup. JS buglet. There's another one too. Save by quick edit > thread title shows above post >reload > thread title goes away.
Master of Expletives: Now with improved family f@&king friendliness! :D

Sources code: making easy front end changes difficult since 1873. :P

 

Re: Quickedit haz no 'Last edit by'

Reply #2

I fixed the last edit by problem ... needed to update the xml response so it did not add in the << >> stuff and since the last edit by was moved inside the subject div, the subject template description also needed to be updated so the last edit div was restored (really added) so it could be updated.

Have not looked at the other issue yet, need to see what crazy markup Ant added :P

Re: Quickedit haz no 'Last edit by'

Reply #3

OK I see the other issue now ... but are we going to add the subject back in, whats the plan for that area these days?

Re: Quickedit haz no 'Last edit by'

Reply #4

Dunno. I'll go with whatever results in the least bitching, because I can change it in a couple of minutes anyway. I like the way I've got my test theme set up over at the old den of iniquity. I'm finding that works really well.
Master of Expletives: Now with improved family f@&king friendliness! :D

Sources code: making easy front end changes difficult since 1873. :P

Re: Quickedit haz no 'Last edit by'

Reply #5

Subject back in, please.

Re: Quickedit haz no 'Last edit by'

Reply #6

My test theme does have subject back in. :P

 emanuele adds last edited

 emanuele edits again from quick edit
Last Edit: September 05, 2013, 09:38:06 am by emanuele
Master of Expletives: Now with improved family f@&king friendliness! :D

Sources code: making easy front end changes difficult since 1873. :P