ElkArte Community

Elk Development => Feature Discussion => Topic started by: emanuele on October 24, 2013, 12:33:09 pm

Title: A query in ManageThemes.controller.php
Post by: emanuele on October 24, 2013, 12:33:09 pm
https://github.com/elkarte/Elkarte/blob/0e19c550e246d216365391f197a8115e6ba8fc54/sources/admin/ManageThemes.controller.php#L1190

TBH, I'm not completely sure about what that query is trying to obtain... :-[
Title: Re: A query in ManageThemes.controller.php
Post by: TE on October 24, 2013, 01:13:02 pm

Quote from: emanuele – TBH, I'm not completely sure about what that query is trying to obtain... :-[
LOL, I can only imagine what that query tries to do.. From the code above and the two INNER JOINS it seems to be used for the "based_on" info and group it in the preview under the parent theme? Not sure though..
I'd name  a function with this qeuery "determineParentTheme()"
Title: Re: A query in ManageThemes.controller.php
Post by: emanuele on October 24, 2013, 01:50:01 pm
O:-)

It's not only about the name of the function, but also to understand if it is possible to reuse something we already have around. like the loadOptionsInto (or something similar :P).