Minor tweak to current theme page.

Topic: Minor tweak to current theme page. (Read 6961 times) previous topic - next topic

0 Members and 1 Guest are viewing this topic.

Minor tweak to current theme page.

June 26, 2013, 07:29:13 pm

It bugs me a bit that the current theme page in admin doesn't contain lynx to edit the stylesheet, etc. I know said lynx reside quite happily in the forests of area=theme;sa=themelist; but their absence from the current theme page seems a bit incongruous.

My 2c is we should breed more lynx and use them to populate the current theme page. When I go to the page that handles the current theme, I sorta expect to see basic editing lynx there too.

Re: Minor tweak to current theme page.

Reply #1 – July 13, 2013, 10:29:31 am

Maybe instead of having another menu entry (or in parallel to the menu entry) we could add a link to the "modify theme" page.

Re: Minor tweak to current theme page.

Reply #2 – July 13, 2013, 04:36:05 pm

Well on 1.1.x there was a link to edit stylesheets, etc on the current theme page. It was kind of handy if you were doing interface work on a site that had multiple themes, because you could just go straight to current instead of hunting through a list iof themes. Not sure how big a deal that is for most users though.

A link to the modify page for that particular theme woud be fine. IOW, link them to the browse area for that theme id, so they get what they want straight away without jumping through extra hoops. It's not really another menu entry. It's just a link on the page.

My 2c.

Re: Minor tweak to current theme page.

Reply #3 – July 14, 2013, 08:21:37 am

I expressed myself very badly...I was still tired.

At the moment there is the menu item "Modify Themes" that has a list of themes and links to modify something.
It may be worth remove that page and just list the edit links in "Theme settings" along with the new "Edit this theme's settings".

Re: Minor tweak to current theme page.

Reply #4 – July 14, 2013, 09:30:51 am

Something like that:

Code: [Select]

				<div class="content">
					<ul class="settings themes_list">
						<li class="button_link floatleft"><a href="', $scripturl, '?action=admin;area=theme;th=', $theme['id'], ';', $context['session_var'], '=', $context['session_id'], ';sa=list">', $txt['theme_edit_settings'], '</a></li>
						<li class="button_link floatleft"><a href="', $scripturl, '?action=admin;area=theme;th=', $theme['id'], ';', $context['session_var'], '=', $context['session_id'], ';sa=browse">', $txt['themeadmin_edit_browse'], '</a></li>', $theme['can_edit_style'] ? '
						<li class="button_link floatleft"><a href="' . $scripturl . '?action=admin;area=theme;th=' . $theme['id'] . ';' . $context['session_var'] . '=' . $context['session_id'] . ';sa=browse;directory=css">' . $txt['themeadmin_edit_style'] . '</a></li>' : '', '
						<li class="button_link floatleft"><a href="', $scripturl, '?action=admin;area=theme;th=', $theme['id'], ';', $context['session_var'], '=', $context['session_id'], ';sa=copy">', $txt['themeadmin_edit_copy_template'], '</a></li>
					</ul>
					<dl class="settings themes_list">
						<dt>', $txt['themeadmin_list_theme_dir'], ':</dt>
						<dd', $theme['valid_path'] ? '' : ' class="error"', '>', $theme['theme_dir'], $theme['valid_path'] ? '' : ' ' . $txt['themeadmin_list_invalid'], '</dd>
						<dt>', $txt['themeadmin_list_theme_url'], ':</dt>
						<dd>', $theme['theme_url'], '</dd>
						<dt>', $txt['themeadmin_list_images_url'], ':</dt>
						<dd>', $theme['images_url'], '</dd>
					</dl>
				</div>

And this to admin.css:

Code: [Select]

ul.themes_list {
	padding-bottom: 0.5em;
}
ul.themes_list li{
	width: 45%;
}
ul.themes_list:after{
	display: block;
	clear: both;
	content:"";
}

Or maybe something simpler in terms of css, you know I'm not good at that things.

Re: Minor tweak to current theme page.

Reply #5 – July 14, 2013, 09:58:20 am

Eh? I don't get it. You'd still need the full list of themes, so you'd still need that page.

Re: Minor tweak to current theme page.

Reply #6 – July 14, 2013, 10:35:00 am

http://img818.imageshack.us/img818/918/xhz8.png

At the moment it looks almost horrible, I know, but it's just to have an idea of what I talking about.
And then remove the menu item ""Modify Themes".

Re: Minor tweak to current theme page.

Reply #7 – July 14, 2013, 05:37:25 pm

Oh I see. Yeah I suppose that makes sense. Not entirely sure though. I still kinda think the current theme page should have that stuff too.

Re: Minor tweak to current theme page.

Reply #8 – July 14, 2013, 05:47:21 pm

Ahhh...okay I think I misunderstood where you wanted them. lol